Update HISTORY.md and bump version to 6.20.4

Summary:
Some file systems (especially distributed FS) do not support reopening a file for writing. The ExternalSstFileIngestionJob calls ReopenWritableFile in order to sync the ingested file, which typically makes sense only on a local file system with a page cache (i.e Posix). So this change tries to sync the ingested file only if ReopenWritableFile doesn't return Status::NotSupported().

Tests:
Add a new unit test in external_sst_file_basic_test

Pull Request resolved: https://github.com/facebook/rocksdb/pull/8296

Reviewed By: jay-zhuang

Differential Revision: D28420865

Pulled By: anand1976

fbshipit-source-id: 380e7f5ff95324997f7a59864a9ac96ebbd0100c

.circleci/config.yml

@@ -572,58 +572,6 @@ jobs:
             gtest-parallel $(</tmp/test_list) --output_dir=/tmp | cat  # pipe to cat to continuously output status on circleci UI. Otherwise, no status will be printed while the job is running.
       - post-steps
 
-  build-linux-arm-test-full:
-    machine:
-      image: ubuntu-2004:202101-01
-    resource_class: arm.large
-    steps:
-      - pre-steps
-      - install-gflags
-      - run: make V=1 J=4 -j4 check | .circleci/cat_ignore_eagain
-      - post-steps
-
-  build-linux-arm:
-    machine:
-      image: ubuntu-2004:202101-01
-    resource_class: arm.large
-    steps:
-      - pre-steps
-      - install-gflags
-      - run: ROCKSDBTESTS_PLATFORM_DEPENDENT=only make V=1 J=4 -j4 all_but_some_tests check_some | .circleci/cat_ignore_eagain
-      - post-steps
-
-  build-linux-arm-cmake-no_test_run:
-    machine:
-      image: ubuntu-2004:202101-01
-    resource_class: arm.large
-    environment:
-      JAVA_HOME: /usr/lib/jvm/java-8-openjdk-arm64
-    steps:
-      - pre-steps
-      - run:
-          name: "Set Java Environment"
-          command: |
-            echo "JAVA_HOME=${JAVA_HOME}"
-            echo 'export PATH=$JAVA_HOME/bin:$PATH' >> $BASH_ENV
-            which java && java -version
-            which javac && javac -version
-      - run:
-          name: "Build with cmake"
-          command: |
-            mkdir build
-            cd build
-            cmake -DCMAKE_BUILD_TYPE=Release -DWITH_TESTS=0 -DWITH_GFLAGS=0 -DWITH_BENCHMARK_TOOLS=0 -DWITH_TOOLS=0 -DWITH_CORE_TOOLS=1 ..
-            make -j4
-      - run:
-          name: "Build Java with cmake"
-          command: |
-            rm -rf build
-            mkdir build
-            cd build
-            cmake -DJNI=1 -DCMAKE_BUILD_TYPE=Release -DWITH_GFLAGS=0 ..
-            make -j4 rocksdb rocksdbjni
-      - post-steps
-
   build-format-compatible:
     machine:
       image: ubuntu-1604:202007-01
@@ -734,7 +682,6 @@ workflows:
       - build-linux-gcc-8-no_test_run
       - build-linux-gcc-9-no_test_run
       - build-linux-gcc-10-cxx20-no_test_run
-      - build-linux-arm-cmake-no_test_run
   build-macos:
     jobs:
       - build-macos
@@ -744,9 +691,6 @@ workflows:
   build-cmake-mingw:
     jobs:
       - build-cmake-mingw
-  build-linux-arm:
-    jobs:
-      - build-linux-arm
   nightly:
     triggers:
       - schedule:
@@ -757,4 +701,3 @@ workflows:
                 - master
     jobs:
       - build-format-compatible
-      - build-linux-arm-test-full

.travis.yml

@@ -61,10 +61,6 @@ matrix:
     env: JOB_NAME=make-gcc4.8
   - os: linux
     compiler: clang
-  - if: type = pull_request AND commit_message !~ /FULL_CI/
-    os: linux
-    arch: arm64
-    env: TEST_GROUP=platform_dependent
   - if: type = pull_request AND commit_message !~ /FULL_CI/
     os : linux
     arch: arm64
@@ -97,10 +93,6 @@ matrix:
     os: linux
     arch: ppc64le
     env: TEST_GROUP=4
-  - if: type = pull_request AND commit_message !~ /FULL_CI/
-    os : linux
-    arch: arm64
-    env: JOB_NAME=cmake
   - if: type = pull_request AND commit_message !~ /FULL_CI/ AND commit_message !~ /java/
     os : linux
     arch: arm64

CMakeLists.txt

@@ -296,7 +296,6 @@ else()
 endif()
 
 include(CheckCXXSourceCompiles)
-set(OLD_CMAKE_REQUIRED_FLAGS ${CMAKE_REQUIRED_FLAGS})
 if(NOT MSVC)
   set(CMAKE_REQUIRED_FLAGS "-msse4.2 -mpclmul")
 endif()
@@ -313,6 +312,7 @@ int main() {
   auto d = _mm_cvtsi128_si64(c);
 }
 " HAVE_SSE42)
+unset(CMAKE_REQUIRED_FLAGS)
 if(HAVE_SSE42)
   add_definitions(-DHAVE_SSE42)
   add_definitions(-DHAVE_PCLMUL)
@@ -320,27 +320,6 @@ elseif(FORCE_SSE42)
   message(FATAL_ERROR "FORCE_SSE42=ON but unable to compile with SSE4.2 enabled")
 endif()
 
-# Check if -latomic is required or not
-if (NOT MSVC)
-  set(CMAKE_REQUIRED_FLAGS "--std=c++11")
-  CHECK_CXX_SOURCE_COMPILES("
-#include <atomic>
-std::atomic<uint64_t> x(0);
-int main() {
-  uint64_t i = x.load(std::memory_order_relaxed);
-  bool b = x.is_lock_free();
-  return 0;
-}
-" BUILTIN_ATOMIC)
-if (NOT BUILTIN_ATOMIC)
-  #TODO: Check if -latomic exists
-  list(APPEND THIRDPARTY_LIBS atomic)
-endif()
-endif()
-
-# Reset the required flags
-set(CMAKE_REQUIRED_FLAGS ${OLD_CMAKE_REQUIRED_FLAGS})
-
 CHECK_CXX_SOURCE_COMPILES("
 #if defined(_MSC_VER) && !defined(__thread)
 #define __thread __declspec(thread)
@@ -1348,8 +1327,7 @@ if(WITH_BENCHMARK_TOOLS)
     ${ROCKSDB_LIB} ${THIRDPARTY_LIBS})
 
   add_executable(cache_bench${ARTIFACT_SUFFIX}
-    cache/cache_bench.cc
-    cache/cache_bench_tool.cc)
+    cache/cache_bench.cc)
   target_link_libraries(cache_bench${ARTIFACT_SUFFIX}
     ${ROCKSDB_LIB} ${GFLAGS_LIB})
 

HISTORY.md

@@ -1,5 +1,13 @@
 # Rocksdb Change Log
-## Unreleased
+## 6.20.3 (05/05/2021)
+### Bug Fixes
+* In the IngestExternalFile() API, only try to sync the ingested file if the file is linked and the FileSystem/Env supports reopening a writable file.
+
+## 6.20.3 (05/05/2021)
+### Bug Fixes
+* Fixed a bug where `GetLiveFiles()` output included a non-existent file called "OPTIONS-000000". Backups and checkpoints, which use `GetLiveFiles()`, failed on DBs impacted by this bug. Read-write DBs were impacted when the latest OPTIONS file failed to write and `fail_if_options_file_error == false`. Read-only DBs were impacted when no OPTIONS files existed.
+
+## 6.20.2 (04/23/2021)
 ### Bug Fixes
 * Fixed a bug in handling file rename error in distributed/network file systems when the server succeeds but client returns error. The bug can cause CURRENT file to point to non-existing MANIFEST file, thus DB cannot be opened.
 * Fixed a bug where ingested files were written with incorrect boundary key metadata. In rare cases this could have led to a level's files being wrongly ordered and queries for the boundary keys returning wrong results.
@@ -9,9 +17,6 @@
 ### Behavior Changes
 * Due to the fix of false-postive alert of "SST file is ahead of WAL", all the CFs with no SST file (CF empty) will bypass the consistency check. We fixed a false-positive, but introduced a very rare true-negative which will be triggered in the following conditions: A CF with some delete operations in the last a few queries which will result in an empty CF (those are flushed to SST file and a compaction triggered which combines this file and all other SST files and generates an empty CF, or there is another reason to write a manifest entry for this CF after a flush that generates no SST file from an empty CF). The deletion entries are logged in a WAL and this WAL was corrupted, while the CF's log number points to the next WAL (due to the flush). Therefore, the DB can only recover to the point without these trailing deletions and cause the inconsistent DB status.
 
-### New Features
-* Add new option allow_stall passed during instance creation of WriteBufferManager. When allow_stall is set, WriteBufferManager will stall all writers shared across multiple DBs and columns if memory usage goes beyond specified WriteBufferManager::buffer_size (soft limit). Stall will be cleared when memory is freed after flush and memory usage goes down below buffer_size.
-
 ## 6.20.0 (04/16/2021)
 ### Behavior Changes
 * `ColumnFamilyOptions::sample_for_compression` now takes effect for creation of all block-based tables. Previously it only took effect for block-based tables created by flush.
@@ -26,6 +31,8 @@
 * Fixed crash (divide by zero) when compression dictionary is applied to a file containing only range tombstones.
 * Fixed a backward iteration bug with partitioned filter enabled: not including the prefix of the last key of the previous filter partition in current filter partition can cause wrong iteration result.
 * Fixed a bug that allowed `DBOptions::max_open_files` to be set with a non-negative integer with `ColumnFamilyOptions::compaction_style = kCompactionStyleFIFO`.
+* Fixed a bug in handling file rename error in distributed/network file systems when the server succeeds but client returns error. The bug can cause CURRENT file to point to non-existing MANIFEST file, thus DB cannot be opened.
+* Fixed a data race between insertion into memtables and the retrieval of the DB properties `rocksdb.cur-size-active-mem-table`, `rocksdb.cur-size-all-mem-tables`, and `rocksdb.size-all-mem-tables`.
 
 ### Performance Improvements
 * On ARM platform, use `yield` instead of `wfe` to relax cpu to gain better performance.
@@ -43,7 +50,6 @@
 * Added BackupEngine::GetBackupInfo / GetLatestBackupInfo for querying individual backups.
 * Made the Ribbon filter a long-term supported feature in terms of the SST schema(compatible with version >= 6.15.0) though the API for enabling it is expected to change.
 
-
 ## 6.19.0 (03/21/2021)
 ### Bug Fixes
 * Fixed the truncation error found in APIs/tools when dumping block-based SST files in a human-readable format. After fix, the block-based table can be fully dumped as a readable file.

Makefile

@@ -491,14 +491,13 @@ VALGRIND_OPTS = --error-exitcode=$(VALGRIND_ERROR) --leak-check=full
 
 TEST_OBJECTS = $(patsubst %.cc, $(OBJ_DIR)/%.o, $(TEST_LIB_SOURCES) $(MOCK_LIB_SOURCES)) $(GTEST)
 BENCH_OBJECTS = $(patsubst %.cc, $(OBJ_DIR)/%.o, $(BENCH_LIB_SOURCES))
-CACHE_BENCH_OBJECTS = $(patsubst %.cc, $(OBJ_DIR)/%.o, $(CACHE_BENCH_LIB_SOURCES))
 TOOL_OBJECTS = $(patsubst %.cc, $(OBJ_DIR)/%.o, $(TOOL_LIB_SOURCES))
 ANALYZE_OBJECTS = $(patsubst %.cc, $(OBJ_DIR)/%.o, $(ANALYZER_LIB_SOURCES))
 STRESS_OBJECTS =  $(patsubst %.cc, $(OBJ_DIR)/%.o, $(STRESS_LIB_SOURCES))
 
 # Exclude build_version.cc -- a generated source file -- from all sources.  Not needed for dependencies
-ALL_SOURCES  = $(LIB_SOURCES) $(TEST_LIB_SOURCES) $(MOCK_LIB_SOURCES) $(GTEST_DIR)/gtest/gtest-all.cc
-ALL_SOURCES += $(TOOL_LIB_SOURCES) $(BENCH_LIB_SOURCES) $(CACHE_BENCH_LIB_SOURCES) $(ANALYZER_LIB_SOURCES) $(STRESS_LIB_SOURCES)
+ALL_SOURCES  = $(filter-out util/build_version.cc, $(LIB_SOURCES)) $(TEST_LIB_SOURCES) $(MOCK_LIB_SOURCES) $(GTEST_DIR)/gtest/gtest-all.cc
+ALL_SOURCES += $(TOOL_LIB_SOURCES) $(BENCH_LIB_SOURCES) $(ANALYZER_LIB_SOURCES) $(STRESS_LIB_SOURCES)
 ALL_SOURCES += $(TEST_MAIN_SOURCES) $(TOOL_MAIN_SOURCES) $(BENCH_MAIN_SOURCES)
 
 TESTS = $(patsubst %.cc, %, $(notdir $(TEST_MAIN_SOURCES)))
@@ -1253,7 +1252,7 @@ folly_synchronization_distributed_mutex_test: $(OBJ_DIR)/third-party/folly/folly
 	$(AM_LINK)
 endif
 
-cache_bench: $(OBJ_DIR)/cache/cache_bench.o $(CACHE_BENCH_OBJECTS) $(LIBRARY)
+cache_bench: $(OBJ_DIR)/cache/cache_bench.o $(LIBRARY)
 	$(AM_LINK)
 
 persistent_cache_bench: $(OBJ_DIR)/utilities/persistent_cache/persistent_cache_bench.o $(LIBRARY)
@@ -1860,9 +1859,6 @@ io_tracer_parser: $(OBJ_DIR)/tools/io_tracer_parser.o $(TOOLS_LIBRARY) $(LIBRARY
 
 db_blob_corruption_test: $(OBJ_DIR)/db/blob/db_blob_corruption_test.o $(TEST_LIBRARY) $(LIBRARY)
 	$(AM_LINK)
-
-db_write_buffer_manager_test: $(OBJ_DIR)/db/db_write_buffer_manager_test.o $(TEST_LIBRARY) $(LIBRARY)
-	$(AM_LINK)
 #-------------------------------------------------
 # make install related stuff
 PREFIX ?= /usr/local

PLUGINS.md

@@ -1,4 +1,3 @@
 This is the list of all known third-party plugins for RocksDB. If something is missing, please open a pull request to add it.
 
 * [Dedupfs](https://github.com/ajkr/dedupfs): an example for plugin developers to reference
-* [ZenFS](https://github.com/westerndigitalcorporation/zenfs): a file system for zoned block devices

TARGETS

@@ -794,21 +794,6 @@ cpp_library(
     link_whole = False,
 )
 
-cpp_library(
-    name = "rocksdb_cache_bench_tools_lib",
-    srcs = ["cache/cache_bench_tool.cc"],
-    auto_headers = AutoHeaders.RECURSIVE_GLOB,
-    arch_preprocessor_flags = ROCKSDB_ARCH_PREPROCESSOR_FLAGS,
-    compiler_flags = ROCKSDB_COMPILER_FLAGS,
-    os_deps = ROCKSDB_OS_DEPS,
-    os_preprocessor_flags = ROCKSDB_OS_PREPROCESSOR_FLAGS,
-    preprocessor_flags = ROCKSDB_PREPROCESSOR_FLAGS,
-    include_paths = ROCKSDB_INCLUDE_PATHS,
-    deps = [":rocksdb_lib"],
-    external_deps = ROCKSDB_EXTERNAL_DEPS,
-    link_whole = False,
-)
-
 cpp_library(
     name = "rocksdb_stress_lib",
     srcs = [
@@ -1426,13 +1411,6 @@ ROCKS_TESTS = [
         [],
         [],
     ],
-    [
-        "db_write_buffer_manager_test",
-        "db/db_write_buffer_manager_test.cc",
-        "parallel",
-        [],
-        [],
-    ],
     [
         "db_write_test",
         "db/db_write_test.cc",

buckifier/buckify_rocksdb.py

@@ -173,11 +173,6 @@ def generate_targets(repo_path, deps_map):
         src_mk.get("ANALYZER_LIB_SOURCES", []) +
         ["test_util/testutil.cc"],
         [":rocksdb_lib"])
-    # rocksdb_cache_bench_tools_lib
-    TARGETS.add_library(
-        "rocksdb_cache_bench_tools_lib",
-        src_mk.get("CACHE_BENCH_LIB_SOURCES", []),
-        [":rocksdb_lib"])
     # rocksdb_stress_lib
     TARGETS.add_rocksdb_library(
         "rocksdb_stress_lib",

cache/cache_bench.cc

@@ -1,11 +1,7 @@
-//  Copyright (c) 2013-present, Facebook, Inc.  All rights reserved.
+//  Copyright (c) 2011-present, Facebook, Inc.  All rights reserved.
 //  This source code is licensed under both the GPLv2 (found in the
 //  COPYING file in the root directory) and Apache 2.0 License
 //  (found in the LICENSE.Apache file in the root directory).
-//
-// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file. See the AUTHORS file for names of contributors.
 
 #ifndef GFLAGS
 #include <cstdio>
@@ -14,8 +10,375 @@ int main() {
   return 1;
 }
 #else
-#include <rocksdb/cache_bench_tool.h>
-int main(int argc, char** argv) {
-  return ROCKSDB_NAMESPACE::cache_bench_tool(argc, argv);
+
+#include <sys/types.h>
+
+#include <cinttypes>
+#include <cstdio>
+#include <limits>
+
+#include "port/port.h"
+#include "rocksdb/cache.h"
+#include "rocksdb/db.h"
+#include "rocksdb/env.h"
+#include "rocksdb/system_clock.h"
+#include "util/coding.h"
+#include "util/gflags_compat.h"
+#include "util/hash.h"
+#include "util/mutexlock.h"
+#include "util/random.h"
+
+using GFLAGS_NAMESPACE::ParseCommandLineFlags;
+
+static constexpr uint32_t KiB = uint32_t{1} << 10;
+static constexpr uint32_t MiB = KiB << 10;
+static constexpr uint64_t GiB = MiB << 10;
+
+DEFINE_uint32(threads, 16, "Number of concurrent threads to run.");
+DEFINE_uint64(cache_size, 1 * GiB,
+              "Number of bytes to use as a cache of uncompressed data.");
+DEFINE_uint32(num_shard_bits, 6, "shard_bits.");
+
+DEFINE_double(resident_ratio, 0.25,
+              "Ratio of keys fitting in cache to keyspace.");
+DEFINE_uint64(ops_per_thread, 0,
+              "Number of operations per thread. (Default: 5 * keyspace size)");
+DEFINE_uint32(value_bytes, 8 * KiB, "Size of each value added.");
+
+DEFINE_uint32(skew, 5, "Degree of skew in key selection");
+DEFINE_bool(populate_cache, true, "Populate cache before operations");
+
+DEFINE_uint32(lookup_insert_percent, 87,
+              "Ratio of lookup (+ insert on not found) to total workload "
+              "(expressed as a percentage)");
+DEFINE_uint32(insert_percent, 2,
+              "Ratio of insert to total workload (expressed as a percentage)");
+DEFINE_uint32(lookup_percent, 10,
+              "Ratio of lookup to total workload (expressed as a percentage)");
+DEFINE_uint32(erase_percent, 1,
+              "Ratio of erase to total workload (expressed as a percentage)");
+
+DEFINE_bool(use_clock_cache, false, "");
+
+namespace ROCKSDB_NAMESPACE {
+
+class CacheBench;
+namespace {
+// State shared by all concurrent executions of the same benchmark.
+class SharedState {
+ public:
+  explicit SharedState(CacheBench* cache_bench)
+      : cv_(&mu_),
+        num_initialized_(0),
+        start_(false),
+        num_done_(0),
+        cache_bench_(cache_bench) {}
+
+  ~SharedState() {}
+
+  port::Mutex* GetMutex() {
+    return &mu_;
+  }
+
+  port::CondVar* GetCondVar() {
+    return &cv_;
+  }
+
+  CacheBench* GetCacheBench() const {
+    return cache_bench_;
+  }
+
+  void IncInitialized() {
+    num_initialized_++;
+  }
+
+  void IncDone() {
+    num_done_++;
+  }
+
+  bool AllInitialized() const { return num_initialized_ >= FLAGS_threads; }
+
+  bool AllDone() const { return num_done_ >= FLAGS_threads; }
+
+  void SetStart() {
+    start_ = true;
+  }
+
+  bool Started() const {
+    return start_;
+  }
+
+ private:
+  port::Mutex mu_;
+  port::CondVar cv_;
+
+  uint64_t num_initialized_;
+  bool start_;
+  uint64_t num_done_;
+
+  CacheBench* cache_bench_;
+};
+
+// Per-thread state for concurrent executions of the same benchmark.
+struct ThreadState {
+  uint32_t tid;
+  Random64 rnd;
+  SharedState* shared;
+
+  ThreadState(uint32_t index, SharedState* _shared)
+      : tid(index), rnd(1000 + index), shared(_shared) {}
+};
+
+struct KeyGen {
+  char key_data[27];
+
+  Slice GetRand(Random64& rnd, uint64_t max_key) {
+    uint64_t raw = rnd.Next();
+    // Skew according to setting
+    for (uint32_t i = 0; i < FLAGS_skew; ++i) {
+      raw = std::min(raw, rnd.Next());
+    }
+    uint64_t key = FastRange64(raw, max_key);
+    // Variable size and alignment
+    size_t off = key % 8;
+    key_data[0] = char{42};
+    EncodeFixed64(key_data + 1, key);
+    key_data[9] = char{11};
+    EncodeFixed64(key_data + 10, key);
+    key_data[18] = char{4};
+    EncodeFixed64(key_data + 19, key);
+    return Slice(&key_data[off], sizeof(key_data) - off);
+  }
+};
+
+char* createValue(Random64& rnd) {
+  char* rv = new char[FLAGS_value_bytes];
+  // Fill with some filler data, and take some CPU time
+  for (uint32_t i = 0; i < FLAGS_value_bytes; i += 8) {
+    EncodeFixed64(rv + i, rnd.Next());
+  }
+  return rv;
 }
+
+void deleter(const Slice& /*key*/, void* value) {
+  delete[] static_cast<char*>(value);
+}
+}  // namespace
+
+class CacheBench {
+  static constexpr uint64_t kHundredthUint64 =
+      std::numeric_limits<uint64_t>::max() / 100U;
+
+ public:
+  CacheBench()
+      : max_key_(static_cast<uint64_t>(FLAGS_cache_size / FLAGS_resident_ratio /
+                                       FLAGS_value_bytes)),
+        lookup_insert_threshold_(kHundredthUint64 *
+                                 FLAGS_lookup_insert_percent),
+        insert_threshold_(lookup_insert_threshold_ +
+                          kHundredthUint64 * FLAGS_insert_percent),
+        lookup_threshold_(insert_threshold_ +
+                          kHundredthUint64 * FLAGS_lookup_percent),
+        erase_threshold_(lookup_threshold_ +
+                         kHundredthUint64 * FLAGS_erase_percent) {
+    if (erase_threshold_ != 100U * kHundredthUint64) {
+      fprintf(stderr, "Percentages must add to 100.\n");
+      exit(1);
+    }
+    if (FLAGS_use_clock_cache) {
+      cache_ = NewClockCache(FLAGS_cache_size, FLAGS_num_shard_bits);
+      if (!cache_) {
+        fprintf(stderr, "Clock cache not supported.\n");
+        exit(1);
+      }
+    } else {
+      cache_ = NewLRUCache(FLAGS_cache_size, FLAGS_num_shard_bits);
+    }
+    if (FLAGS_ops_per_thread == 0) {
+      FLAGS_ops_per_thread = 5 * max_key_;
+    }
+  }
+
+  ~CacheBench() {}
+
+  void PopulateCache() {
+    Random64 rnd(1);
+    KeyGen keygen;
+    for (uint64_t i = 0; i < 2 * FLAGS_cache_size; i += FLAGS_value_bytes) {
+      cache_->Insert(keygen.GetRand(rnd, max_key_), createValue(rnd),
+                     FLAGS_value_bytes, &deleter);
+    }
+  }
+
+  bool Run() {
+    ROCKSDB_NAMESPACE::Env* env = ROCKSDB_NAMESPACE::Env::Default();
+    const auto& clock = env->GetSystemClock();
+
+    PrintEnv();
+    SharedState shared(this);
+    std::vector<std::unique_ptr<ThreadState> > threads(FLAGS_threads);
+    for (uint32_t i = 0; i < FLAGS_threads; i++) {
+      threads[i].reset(new ThreadState(i, &shared));
+      env->StartThread(ThreadBody, threads[i].get());
+    }
+    {
+      MutexLock l(shared.GetMutex());
+      while (!shared.AllInitialized()) {
+        shared.GetCondVar()->Wait();
+      }
+      // Record start time
+      uint64_t start_time = clock->NowMicros();
+
+      // Start all threads
+      shared.SetStart();
+      shared.GetCondVar()->SignalAll();
+
+      // Wait threads to complete
+      while (!shared.AllDone()) {
+        shared.GetCondVar()->Wait();
+      }
+
+      // Record end time
+      uint64_t end_time = clock->NowMicros();
+      double elapsed = static_cast<double>(end_time - start_time) * 1e-6;
+      uint32_t qps = static_cast<uint32_t>(
+          static_cast<double>(FLAGS_threads * FLAGS_ops_per_thread) / elapsed);
+      fprintf(stdout, "Complete in %.3f s; QPS = %u\n", elapsed, qps);
+    }
+    return true;
+  }
+
+ private:
+  std::shared_ptr<Cache> cache_;
+  const uint64_t max_key_;
+  // Cumulative thresholds in the space of a random uint64_t
+  const uint64_t lookup_insert_threshold_;
+  const uint64_t insert_threshold_;
+  const uint64_t lookup_threshold_;
+  const uint64_t erase_threshold_;
+
+  static void ThreadBody(void* v) {
+    ThreadState* thread = static_cast<ThreadState*>(v);
+    SharedState* shared = thread->shared;
+
+    {
+      MutexLock l(shared->GetMutex());
+      shared->IncInitialized();
+      if (shared->AllInitialized()) {
+        shared->GetCondVar()->SignalAll();
+      }
+      while (!shared->Started()) {
+        shared->GetCondVar()->Wait();
+      }
+    }
+    thread->shared->GetCacheBench()->OperateCache(thread);
+
+    {
+      MutexLock l(shared->GetMutex());
+      shared->IncDone();
+      if (shared->AllDone()) {
+        shared->GetCondVar()->SignalAll();
+      }
+    }
+  }
+
+  void OperateCache(ThreadState* thread) {
+    // To use looked-up values
+    uint64_t result = 0;
+    // To hold handles for a non-trivial amount of time
+    Cache::Handle* handle = nullptr;
+    KeyGen gen;
+    for (uint64_t i = 0; i < FLAGS_ops_per_thread; i++) {
+      Slice key = gen.GetRand(thread->rnd, max_key_);
+      uint64_t random_op = thread->rnd.Next();
+      if (random_op < lookup_insert_threshold_) {
+        if (handle) {
+          cache_->Release(handle);
+          handle = nullptr;
+        }
+        // do lookup
+        handle = cache_->Lookup(key);
+        if (handle) {
+          // do something with the data
+          result += NPHash64(static_cast<char*>(cache_->Value(handle)),
+                             FLAGS_value_bytes);
+        } else {
+          // do insert
+          cache_->Insert(key, createValue(thread->rnd), FLAGS_value_bytes,
+                         &deleter, &handle);
+        }
+      } else if (random_op < insert_threshold_) {
+        if (handle) {
+          cache_->Release(handle);
+          handle = nullptr;
+        }
+        // do insert
+        cache_->Insert(key, createValue(thread->rnd), FLAGS_value_bytes,
+                       &deleter, &handle);
+      } else if (random_op < lookup_threshold_) {
+        if (handle) {
+          cache_->Release(handle);
+          handle = nullptr;
+        }
+        // do lookup
+        handle = cache_->Lookup(key);
+        if (handle) {
+          // do something with the data
+          result += NPHash64(static_cast<char*>(cache_->Value(handle)),
+                             FLAGS_value_bytes);
+        }
+      } else if (random_op < erase_threshold_) {
+        // do erase
+        cache_->Erase(key);
+      } else {
+        // Should be extremely unlikely (noop)
+        assert(random_op >= kHundredthUint64 * 100U);
+      }
+    }
+    if (handle) {
+      cache_->Release(handle);
+      handle = nullptr;
+    }
+  }
+
+  void PrintEnv() const {
+    printf("RocksDB version     : %d.%d\n", kMajorVersion, kMinorVersion);
+    printf("Number of threads   : %u\n", FLAGS_threads);
+    printf("Ops per thread      : %" PRIu64 "\n", FLAGS_ops_per_thread);
+    printf("Cache size          : %" PRIu64 "\n", FLAGS_cache_size);
+    printf("Num shard bits      : %u\n", FLAGS_num_shard_bits);
+    printf("Max key             : %" PRIu64 "\n", max_key_);
+    printf("Resident ratio      : %g\n", FLAGS_resident_ratio);
+    printf("Skew degree         : %u\n", FLAGS_skew);
+    printf("Populate cache      : %d\n", int{FLAGS_populate_cache});
+    printf("Lookup+Insert pct   : %u%%\n", FLAGS_lookup_insert_percent);
+    printf("Insert percentage   : %u%%\n", FLAGS_insert_percent);
+    printf("Lookup percentage   : %u%%\n", FLAGS_lookup_percent);
+    printf("Erase percentage    : %u%%\n", FLAGS_erase_percent);
+    printf("----------------------------\n");
+  }
+};
+}  // namespace ROCKSDB_NAMESPACE
+
+int main(int argc, char** argv) {
+  ParseCommandLineFlags(&argc, &argv, true);
+
+  if (FLAGS_threads <= 0) {
+    fprintf(stderr, "threads number <= 0\n");
+    exit(1);
+  }
+
+  ROCKSDB_NAMESPACE::CacheBench bench;
+  if (FLAGS_populate_cache) {
+    bench.PopulateCache();
+    printf("Population complete\n");
+    printf("----------------------------\n");
+  }
+  if (bench.Run()) {
+    return 0;
+  } else {
+    return 1;
+  }
+}
+
 #endif  // GFLAGS

cache/cache_bench_tool.cc

@@ -1,504 +0,0 @@
-//  Copyright (c) 2011-present, Facebook, Inc.  All rights reserved.
-//  This source code is licensed under both the GPLv2 (found in the
-//  COPYING file in the root directory) and Apache 2.0 License
-//  (found in the LICENSE.Apache file in the root directory).
-
-#ifdef GFLAGS
-#include "rocksdb/cache_bench_tool.h"
-
-#include <sys/types.h>
-
-#include <cinttypes>
-#include <cstdio>
-#include <limits>
-
-#include "options/configurable_helper.h"
-#include "port/port.h"
-#include "rocksdb/cache.h"
-#include "rocksdb/db.h"
-#include "rocksdb/env.h"
-#include "rocksdb/system_clock.h"
-#include "rocksdb/tiered_cache.h"
-#include "rocksdb/utilities/object_registry.h"
-#include "rocksdb/utilities/options_type.h"
-#include "util/coding.h"
-#include "util/gflags_compat.h"
-#include "util/hash.h"
-#include "util/mutexlock.h"
-#include "util/random.h"
-#include "util/stop_watch.h"
-
-using GFLAGS_NAMESPACE::ParseCommandLineFlags;
-
-static constexpr uint32_t KiB = uint32_t{1} << 10;
-static constexpr uint32_t MiB = KiB << 10;
-static constexpr uint64_t GiB = MiB << 10;
-
-DEFINE_uint32(threads, 16, "Number of concurrent threads to run.");
-DEFINE_uint64(cache_size, 1 * GiB,
-              "Number of bytes to use as a cache of uncompressed data.");
-DEFINE_uint32(num_shard_bits, 6, "shard_bits.");
-
-DEFINE_double(resident_ratio, 0.25,
-              "Ratio of keys fitting in cache to keyspace.");
-DEFINE_uint64(ops_per_thread, 0,
-              "Number of operations per thread. (Default: 5 * keyspace size)");
-DEFINE_uint32(value_bytes, 8 * KiB, "Size of each value added.");
-
-DEFINE_uint32(skew, 5, "Degree of skew in key selection");
-DEFINE_bool(populate_cache, true, "Populate cache before operations");
-
-DEFINE_uint32(lookup_insert_percent, 87,
-              "Ratio of lookup (+ insert on not found) to total workload "
-              "(expressed as a percentage)");
-DEFINE_uint32(insert_percent, 2,
-              "Ratio of insert to total workload (expressed as a percentage)");
-DEFINE_uint32(lookup_percent, 10,
-              "Ratio of lookup to total workload (expressed as a percentage)");
-DEFINE_uint32(erase_percent, 1,
-              "Ratio of erase to total workload (expressed as a percentage)");
-
-DEFINE_bool(use_clock_cache, false, "");
-
-DEFINE_bool(skewed, false, "If true, skew the key access distribution");
-#ifndef ROCKSDB_LITE
-DEFINE_string(tiered_cache_uri, "",
-              "Full URI for creating a custom NVM cache object");
-static class std::shared_ptr<ROCKSDB_NAMESPACE::TieredCache> tiered_cache;
-#endif
-
-namespace ROCKSDB_NAMESPACE {
-class CacheBench;
-
-namespace {
-// State shared by all concurrent executions of the same benchmark.
-class SharedState {
- public:
-  explicit SharedState(CacheBench* cache_bench)
-      : cv_(&mu_),
-        num_initialized_(0),
-        start_(false),
-        num_done_(0),
-        cache_bench_(cache_bench) {}
-
-  ~SharedState() {}
-
-  port::Mutex* GetMutex() { return &mu_; }
-
-  port::CondVar* GetCondVar() { return &cv_; }
-
-  CacheBench* GetCacheBench() const { return cache_bench_; }
-
-  void IncInitialized() { num_initialized_++; }
-
-  void IncDone() { num_done_++; }
-
-  bool AllInitialized() const { return num_initialized_ >= FLAGS_threads; }
-
-  bool AllDone() const { return num_done_ >= FLAGS_threads; }
-
-  void SetStart() { start_ = true; }
-
-  bool Started() const { return start_; }
-
- private:
-  port::Mutex mu_;
-  port::CondVar cv_;
-
-  uint64_t num_initialized_;
-  bool start_;
-  uint64_t num_done_;
-
-  CacheBench* cache_bench_;
-};
-
-class Stats {
- private:
-  uint64_t hits;
-  uint64_t misses;
-  uint64_t lookup_us;
-  uint64_t insert_us;
-
- public:
-  Stats() : hits(0), misses(0), lookup_us(0), insert_us(0) {}
-
-  void AddHits(uint64_t inc) { hits += inc; }
-  void AddMisses(uint64_t inc) { misses += inc; }
-  void AddLookupUs(uint64_t lookup) { lookup_us += lookup; }
-  void AddInsertUs(uint64_t insert) { insert_us += insert; }
-  void Merge(const Stats& other) {
-    hits += other.hits;
-    misses += other.misses;
-    lookup_us += other.lookup_us;
-    insert_us += other.insert_us;
-  }
-  void Report() {
-    fprintf(stdout, "%llu hits, %llu misses, %llu lookup_us, %llu insert_us\n",
-            (unsigned long long)hits, (unsigned long long)misses,
-            (unsigned long long)lookup_us, (unsigned long long)insert_us);
-    fflush(stdout);
-  }
-};
-
-// Per-thread state for concurrent executions of the same benchmark.
-struct ThreadState {
-  uint32_t tid;
-  Random64 rnd;
-  Stats stats;
-  SharedState* shared;
-
-  ThreadState(uint32_t index, SharedState* _shared)
-      : tid(index), rnd(1000 + index), shared(_shared) {}
-};
-
-struct KeyGen {
-  char key_data[27];
-
-  Slice GetRand(Random64& rnd, uint64_t max_key, int max_log) {
-    uint64_t key = 0;
-    if (!FLAGS_skewed) {
-      uint64_t raw = rnd.Next();
-      // Skew according to setting
-      for (uint32_t i = 0; i < FLAGS_skew; ++i) {
-        raw = std::min(raw, rnd.Next());
-      }
-      key = FastRange64(raw, max_key);
-    } else {
-      key = rnd.Skewed(max_log);
-      if (key > max_key) {
-        key -= max_key;
-      }
-    }
-    // Variable size and alignment
-    size_t off = key % 8;
-    key_data[0] = char{42};
-    EncodeFixed64(key_data + 1, key);
-    key_data[9] = char{11};
-    EncodeFixed64(key_data + 10, key);
-    key_data[18] = char{4};
-    EncodeFixed64(key_data + 19, key);
-    return Slice(&key_data[off], sizeof(key_data) - off);
-  }
-};
-
-char* createValue(Random64& rnd) {
-  char* rv = new char[FLAGS_value_bytes];
-  // Fill with some filler data, and take some CPU time
-  for (uint32_t i = 0; i < FLAGS_value_bytes; i += 8) {
-    EncodeFixed64(rv + i, rnd.Next());
-  }
-  return rv;
-}
-
-void helperCallback(Cache::SizeCallback* size_cb,
-                    Cache::SaveToCallback* save_cb,
-                    Cache::DeletionCallback* del_cb) {
-  if (size_cb) {
-    *size_cb = [](void* /*obj*/) -> size_t { return FLAGS_value_bytes; };
-  }
-  if (save_cb) {
-    *save_cb = [](void* obj, size_t /*offset*/, size_t size,
-                  void* out) -> Status {
-      memcpy(out, obj, size);
-      return Status::OK();
-    };
-  }
-  if (del_cb) {
-    *del_cb = [](const Slice& /*key*/, void* obj) -> void {
-      delete[] static_cast<char*>(obj);
-    };
-  }
-}
-}  // namespace
-
-class CacheBench {
-  static constexpr uint64_t kHundredthUint64 =
-      std::numeric_limits<uint64_t>::max() / 100U;
-
- public:
-  CacheBench()
-      : max_key_(static_cast<uint64_t>(FLAGS_cache_size / FLAGS_resident_ratio /
-                                       FLAGS_value_bytes)),
-        lookup_insert_threshold_(kHundredthUint64 *
-                                 FLAGS_lookup_insert_percent),
-        insert_threshold_(lookup_insert_threshold_ +
-                          kHundredthUint64 * FLAGS_insert_percent),
-        lookup_threshold_(insert_threshold_ +
-                          kHundredthUint64 * FLAGS_lookup_percent),
-        erase_threshold_(lookup_threshold_ +
-                         kHundredthUint64 * FLAGS_erase_percent),
-        skewed_(FLAGS_skewed) {
-    if (erase_threshold_ != 100U * kHundredthUint64) {
-      fprintf(stderr, "Percentages must add to 100.\n");
-      exit(1);
-    }
-
-    max_log_ = 0;
-    if (skewed_) {
-      uint64_t max_key = max_key_;
-      while (max_key >>= 1) max_log_++;
-      if (max_key > (1u << max_log_)) max_log_++;
-    }
-
-    if (FLAGS_use_clock_cache) {
-      cache_ = NewClockCache(FLAGS_cache_size, FLAGS_num_shard_bits);
-      if (!cache_) {
-        fprintf(stderr, "Clock cache not supported.\n");
-        exit(1);
-      }
-    } else {
-      LRUCacheOptions opts(FLAGS_cache_size, FLAGS_num_shard_bits, false, 0.5);
-#ifndef ROCKSDB_LITE
-      if (!FLAGS_tiered_cache_uri.empty()) {
-        Status s = ObjectRegistry::NewInstance()->NewSharedObject<TieredCache>(
-            FLAGS_tiered_cache_uri, &tiered_cache);
-        if (tiered_cache == nullptr) {
-          fprintf(stderr,
-                  "No tiered cache registered matching string: %s status=%s\n",
-                  FLAGS_tiered_cache_uri.c_str(), s.ToString().c_str());
-          exit(1);
-        }
-        opts.tiered_cache = tiered_cache;
-      }
-#endif
-
-      cache_ = NewLRUCache(opts);
-    }
-    if (FLAGS_ops_per_thread == 0) {
-      FLAGS_ops_per_thread = 5 * max_key_;
-    }
-  }
-
-  ~CacheBench() {}
-
-  void PopulateCache() {
-    Random64 rnd(1);
-    KeyGen keygen;
-    for (uint64_t i = 0; i < 10 * FLAGS_cache_size; i += FLAGS_value_bytes) {
-      cache_->Insert(keygen.GetRand(rnd, max_key_, max_log_), createValue(rnd),
-                     helperCallback, FLAGS_value_bytes);
-    }
-  }
-
-  bool Run() {
-    ROCKSDB_NAMESPACE::Env* env = ROCKSDB_NAMESPACE::Env::Default();
-    const auto& clock = env->GetSystemClock();
-
-    PrintEnv();
-    SharedState shared(this);
-    std::vector<std::unique_ptr<ThreadState> > threads(FLAGS_threads);
-    for (uint32_t i = 0; i < FLAGS_threads; i++) {
-      threads[i].reset(new ThreadState(i, &shared));
-      env->StartThread(ThreadBody, threads[i].get());
-    }
-    {
-      MutexLock l(shared.GetMutex());
-      while (!shared.AllInitialized()) {
-        shared.GetCondVar()->Wait();
-      }
-      // Record start time
-      uint64_t start_time = clock->NowMicros();
-
-      // Start all threads
-      shared.SetStart();
-      shared.GetCondVar()->SignalAll();
-
-      // Wait threads to complete
-      while (!shared.AllDone()) {
-        shared.GetCondVar()->Wait();
-      }
-
-      // Record end time
-      uint64_t end_time = clock->NowMicros();
-      double elapsed = static_cast<double>(end_time - start_time) * 1e-6;
-      uint32_t qps = static_cast<uint32_t>(
-          static_cast<double>(FLAGS_threads * FLAGS_ops_per_thread) / elapsed);
-      fprintf(stdout, "Complete in %.3f s; QPS = %u\n", elapsed, qps);
-
-      Stats merge_stats;
-      for (uint32_t i = 0; i < FLAGS_threads; ++i) {
-        merge_stats.Merge(threads[i]->stats);
-      }
-      merge_stats.Report();
-    }
-    return true;
-  }
-
- private:
-  std::shared_ptr<Cache> cache_;
-  const uint64_t max_key_;
-  // Cumulative thresholds in the space of a random uint64_t
-  const uint64_t lookup_insert_threshold_;
-  const uint64_t insert_threshold_;
-  const uint64_t lookup_threshold_;
-  const uint64_t erase_threshold_;
-  const bool skewed_;
-  int max_log_;
-
-  static void ThreadBody(void* v) {
-    ThreadState* thread = static_cast<ThreadState*>(v);
-    SharedState* shared = thread->shared;
-
-    {
-      MutexLock l(shared->GetMutex());
-      shared->IncInitialized();
-      if (shared->AllInitialized()) {
-        shared->GetCondVar()->SignalAll();
-      }
-      while (!shared->Started()) {
-        shared->GetCondVar()->Wait();
-      }
-    }
-    thread->shared->GetCacheBench()->OperateCache(thread);
-
-    {
-      MutexLock l(shared->GetMutex());
-      shared->IncDone();
-      if (shared->AllDone()) {
-        shared->GetCondVar()->SignalAll();
-      }
-    }
-  }
-
-  void OperateCache(ThreadState* thread) {
-    // To use looked-up values
-    uint64_t result = 0;
-    // To hold handles for a non-trivial amount of time
-    Cache::Handle* handle = nullptr;
-    KeyGen gen;
-    ROCKSDB_NAMESPACE::Env* env = ROCKSDB_NAMESPACE::Env::Default();
-    SystemClock* clock = env->GetSystemClock().get();
-    for (uint64_t i = 0; i < FLAGS_ops_per_thread; i++) {
-      Slice key = gen.GetRand(thread->rnd, max_key_, max_log_);
-      uint64_t random_op = thread->rnd.Next();
-      Cache::CreateCallback create_cb =
-          [](void* buf, size_t size, void** out_obj, size_t* charge) -> Status {
-        *out_obj = reinterpret_cast<void*>(new char[size]);
-        memcpy(*out_obj, buf, size);
-        *charge = size;
-        return Status::OK();
-      };
-
-      if (random_op < lookup_insert_threshold_) {
-        if (handle) {
-          cache_->Release(handle);
-          handle = nullptr;
-        }
-        // do lookup
-        {
-          uint64_t elapsed = 0;
-          {
-            StopWatch sw(clock, nullptr, 0, &elapsed);
-            handle = cache_->Lookup(key, helperCallback, create_cb,
-                                    Cache::Priority::LOW, true);
-          }
-          thread->stats.AddLookupUs(elapsed);
-        }
-        if (handle) {
-          thread->stats.AddHits(1);
-          // do something with the data
-          result += NPHash64(static_cast<char*>(cache_->Value(handle)),
-                             FLAGS_value_bytes);
-        } else {
-          thread->stats.AddMisses(1);
-          // do insert
-          {
-            uint64_t elapsed = 0;
-            {
-              StopWatch sw(clock, nullptr, 0, &elapsed);
-              cache_->Insert(key, createValue(thread->rnd), helperCallback,
-                             FLAGS_value_bytes, &handle);
-            }
-            thread->stats.AddInsertUs(elapsed);
-          }
-        }
-      } else if (random_op < insert_threshold_) {
-        if (handle) {
-          cache_->Release(handle);
-          handle = nullptr;
-        }
-        // do insert
-        {
-          uint64_t elapsed = 0;
-          {
-            StopWatch sw(clock, nullptr, 0, &elapsed);
-            cache_->Insert(key, createValue(thread->rnd), helperCallback,
-                           FLAGS_value_bytes, &handle);
-          }
-          thread->stats.AddInsertUs(elapsed);
-        }
-      } else if (random_op < lookup_threshold_) {
-        if (handle) {
-          cache_->Release(handle);
-          handle = nullptr;
-        }
-        // do lookup
-        {
-          uint64_t elapsed = 0;
-          {
-            StopWatch sw(clock, nullptr, 0, &elapsed);
-            handle = cache_->Lookup(key, helperCallback, create_cb,
-                                    Cache::Priority::LOW, true);
-          }
-          thread->stats.AddLookupUs(elapsed);
-        }
-        if (handle) {
-          thread->stats.AddHits(1);
-          // do something with the data
-          result += NPHash64(static_cast<char*>(cache_->Value(handle)),
-                             FLAGS_value_bytes);
-        }
-      } else if (random_op < erase_threshold_) {
-        // do erase
-        cache_->Erase(key);
-      } else {
-        // Should be extremely unlikely (noop)
-        assert(random_op >= kHundredthUint64 * 100U);
-      }
-    }
-    if (handle) {
-      cache_->Release(handle);
-      handle = nullptr;
-    }
-  }
-
-  void PrintEnv() const {
-    printf("RocksDB version     : %d.%d\n", kMajorVersion, kMinorVersion);
-    printf("Number of threads   : %u\n", FLAGS_threads);
-    printf("Ops per thread      : %" PRIu64 "\n", FLAGS_ops_per_thread);
-    printf("Cache size          : %" PRIu64 "\n", FLAGS_cache_size);
-    printf("Num shard bits      : %u\n", FLAGS_num_shard_bits);
-    printf("Max key             : %" PRIu64 "\n", max_key_);
-    printf("Resident ratio      : %g\n", FLAGS_resident_ratio);
-    printf("Skew degree         : %u\n", FLAGS_skew);
-    printf("Populate cache      : %d\n", int{FLAGS_populate_cache});
-    printf("Lookup+Insert pct   : %u%%\n", FLAGS_lookup_insert_percent);
-    printf("Insert percentage   : %u%%\n", FLAGS_insert_percent);
-    printf("Lookup percentage   : %u%%\n", FLAGS_lookup_percent);
-    printf("Erase percentage    : %u%%\n", FLAGS_erase_percent);
-    printf("----------------------------\n");
-  }
-};
-
-int cache_bench_tool(int argc, char** argv) {
-  ParseCommandLineFlags(&argc, &argv, true);
-
-  if (FLAGS_threads <= 0) {
-    fprintf(stderr, "threads number <= 0\n");
-    exit(1);
-  }
-
-  ROCKSDB_NAMESPACE::CacheBench bench;
-  if (FLAGS_populate_cache) {
-    bench.PopulateCache();
-    printf("Population complete\n");
-    printf("----------------------------\n");
-  }
-  if (bench.Run()) {
-    return 0;
-  } else {
-    return 1;
-  }
-}
-}  // namespace ROCKSDB_NAMESPACE
-#endif

cache/clock_cache.cc

@@ -271,27 +271,7 @@ class ClockCacheShard final : public CacheShard {
   Status Insert(const Slice& key, uint32_t hash, void* value, size_t charge,
                 void (*deleter)(const Slice& key, void* value),
                 Cache::Handle** handle, Cache::Priority priority) override;
-  Status Insert(const Slice& key, uint32_t hash, void* value,
-                Cache::CacheItemHelperCallback helper_cb, size_t charge,
-                Cache::Handle** handle, Cache::Priority priority) override {
-    Cache::DeletionCallback delete_cb;
-    (*helper_cb)(nullptr, nullptr, &delete_cb);
-    return Insert(key, hash, value, charge, delete_cb, handle, priority);
-  }
   Cache::Handle* Lookup(const Slice& key, uint32_t hash) override;
-  Cache::Handle* Lookup(const Slice& key, uint32_t hash,
-                        Cache::CacheItemHelperCallback /*helper_cb*/,
-                        const Cache::CreateCallback& /*create_cb*/,
-                        Cache::Priority /*priority*/, bool /*wait*/) override {
-    return Lookup(key, hash);
-  }
-  bool Release(Cache::Handle* handle, bool /*useful*/,
-               bool force_erase) override {
-    return Release(handle, force_erase);
-  }
-  bool isReady(Cache::Handle* /*handle*/) override { return true; }
-  void Wait(Cache::Handle* /*handle*/) override {}
-
   // If the entry in in cache, increase reference count and return true.
   // Return false otherwise.
   //
@@ -768,8 +748,6 @@ class ClockCache final : public ShardedCache {
 
   void DisownData() override { shards_ = nullptr; }
 
-  void WaitAll(std::vector<Handle*>& /*handles*/) override {}
-
  private:
   ClockCacheShard* shards_;
 };

cache/lru_cache.cc

@@ -97,8 +97,7 @@ void LRUHandleTable::Resize() {
 LRUCacheShard::LRUCacheShard(size_t capacity, bool strict_capacity_limit,
                              double high_pri_pool_ratio,
                              bool use_adaptive_mutex,
-                             CacheMetadataChargePolicy metadata_charge_policy,
-                             const std::shared_ptr<TieredCache>& tiered_cache)
+                             CacheMetadataChargePolicy metadata_charge_policy)
     : capacity_(0),
       high_pri_pool_usage_(0),
       strict_capacity_limit_(strict_capacity_limit),
@@ -106,8 +105,7 @@ LRUCacheShard::LRUCacheShard(size_t capacity, bool strict_capacity_limit,
       high_pri_pool_capacity_(0),
       usage_(0),
       lru_usage_(0),
-      mutex_(use_adaptive_mutex),
-      tiered_cache_(tiered_cache) {
+      mutex_(use_adaptive_mutex) {
   set_metadata_charge_policy(metadata_charge_policy);
   // Make empty circular linked list
   lru_.next = &lru_;
@@ -258,14 +256,8 @@ void LRUCacheShard::SetCapacity(size_t capacity) {
     EvictFromLRU(0, &last_reference_list);
   }
 
-  // Try to insert the evicted entries into tiered cache
   // Free the entries outside of mutex for performance reasons
   for (auto entry : last_reference_list) {
-    if (tiered_cache_ && entry->IsTieredCacheCompatible() &&
-        !entry->IsPromoted()) {
-      tiered_cache_->Insert(entry->key(), entry->value, entry->info_.helper_cb)
-          .PermitUncheckedError();
-    }
     entry->Free();
   }
 }
@@ -275,126 +267,17 @@ void LRUCacheShard::SetStrictCapacityLimit(bool strict_capacity_limit) {
   strict_capacity_limit_ = strict_capacity_limit;
 }
 
-Status LRUCacheShard::InsertItem(LRUHandle* e, Cache::Handle** handle) {
-  Status s = Status::OK();
-  autovector<LRUHandle*> last_reference_list;
-  size_t total_charge = e->CalcTotalCharge(metadata_charge_policy_);
-
-  {
-    MutexLock l(&mutex_);
-
-    // Free the space following strict LRU policy until enough space
-    // is freed or the lru list is empty
-    EvictFromLRU(total_charge, &last_reference_list);
-
-    if ((usage_ + total_charge) > capacity_ &&
-        (strict_capacity_limit_ || handle == nullptr)) {
-      if (handle == nullptr) {
-        // Don't insert the entry but still return ok, as if the entry inserted
-        // into cache and get evicted immediately.
-        e->SetInCache(false);
-        last_reference_list.push_back(e);
-      } else {
-        delete[] reinterpret_cast<char*>(e);
-        *handle = nullptr;
-        s = Status::Incomplete("Insert failed due to LRU cache being full.");
-      }
-    } else {
-      // Insert into the cache. Note that the cache might get larger than its
-      // capacity if not enough space was freed up.
-      LRUHandle* old = table_.Insert(e);
-      usage_ += total_charge;
-      if (old != nullptr) {
-        s = Status::OkOverwritten();
-        assert(old->InCache());
-        old->SetInCache(false);
-        if (!old->HasRefs()) {
-          // old is on LRU because it's in cache and its reference count is 0
-          LRU_Remove(old);
-          size_t old_total_charge =
-              old->CalcTotalCharge(metadata_charge_policy_);
-          assert(usage_ >= old_total_charge);
-          usage_ -= old_total_charge;
-          last_reference_list.push_back(old);
-        }
-      }
-      if (handle == nullptr) {
-        LRU_Insert(e);
-      } else {
-        e->Ref();
-        *handle = reinterpret_cast<Cache::Handle*>(e);
-      }
-    }
-  }
-
-  // Try to insert the evicted entries into NVM cache
-  // Free the entries here outside of mutex for performance reasons
-  for (auto entry : last_reference_list) {
-    if (tiered_cache_ && entry->IsTieredCacheCompatible() &&
-        !entry->IsPromoted()) {
-      tiered_cache_->Insert(entry->key(), entry->value, entry->info_.helper_cb)
-          .PermitUncheckedError();
-    }
-    entry->Free();
-  }
-
-  return s;
-}
-
-Cache::Handle* LRUCacheShard::Lookup(
-    const Slice& key, uint32_t hash,
-    ShardedCache::CacheItemHelperCallback helper_cb,
-    const ShardedCache::CreateCallback& create_cb, Cache::Priority priority,
-    bool wait) {
-  LRUHandle* e = nullptr;
-  {
-    MutexLock l(&mutex_);
-    e = table_.Lookup(key, hash);
-    if (e != nullptr) {
-      assert(e->InCache());
-      if (!e->HasRefs()) {
-        // The entry is in LRU since it's in hash and has no external references
-        LRU_Remove(e);
-      }
-      e->Ref();
-      e->SetHit();
-    }
-  }
-
-  // If handle table lookup failed, then allocate a handle outside the
-  // mutex if we're going to lookup in the NVM cache
-  // Only support synchronous for now
-  // TODO: Support asynchronous lookup in NVM cache
-  if (!e && tiered_cache_ && helper_cb && wait) {
-    assert(create_cb);
-    std::unique_ptr<TieredCacheHandle> tiered_handle =
-        tiered_cache_->Lookup(key, create_cb, wait);
-    if (tiered_handle != nullptr) {
-      e = reinterpret_cast<LRUHandle*>(
-          new char[sizeof(LRUHandle) - 1 + key.size()]);
-
-      e->flags = 0;
-      e->SetPromoted(true);
-      e->SetTieredCacheCompatible(true);
-      e->info_.helper_cb = helper_cb;
-      e->key_length = key.size();
-      e->hash = hash;
-      e->refs = 0;
-      e->next = e->prev = nullptr;
-      e->SetInCache(true);
-      e->SetPriority(priority);
-      memcpy(e->key_data, key.data(), key.size());
-
-      e->value = tiered_handle->Value();
-      e->charge = tiered_handle->Size();
-
-      // This call could nullify e if the cache is over capacity and
-      // strict_capacity_limit_ is true. In such a case, the caller will try
-      // to insert later, which might again fail, but its ok as this should
-      // not be common
-      InsertItem(e, reinterpret_cast<Cache::Handle**>(&e))
-          .PermitUncheckedError();
+Cache::Handle* LRUCacheShard::Lookup(const Slice& key, uint32_t hash) {
+  MutexLock l(&mutex_);
+  LRUHandle* e = table_.Lookup(key, hash);
+  if (e != nullptr) {
+    assert(e->InCache());
+    if (!e->HasRefs()) {
+      // The entry is in LRU since it's in hash and has no external references
+      LRU_Remove(e);
     }
+    e->Ref();
+    e->SetHit();
   }
   return reinterpret_cast<Cache::Handle*>(e);
 }
@@ -455,32 +338,81 @@ bool LRUCacheShard::Release(Cache::Handle* handle, bool force_erase) {
 Status LRUCacheShard::Insert(const Slice& key, uint32_t hash, void* value,
                              size_t charge,
                              void (*deleter)(const Slice& key, void* value),
-                             Cache::CacheItemHelperCallback helper_cb,
                              Cache::Handle** handle, Cache::Priority priority) {
   // Allocate the memory here outside of the mutex
   // If the cache is full, we'll have to release it
   // It shouldn't happen very often though.
   LRUHandle* e = reinterpret_cast<LRUHandle*>(
       new char[sizeof(LRUHandle) - 1 + key.size()]);
+  Status s = Status::OK();
+  autovector<LRUHandle*> last_reference_list;
 
   e->value = value;
-  e->flags = 0;
-  if (helper_cb) {
-    e->SetTieredCacheCompatible(true);
-    e->info_.helper_cb = helper_cb;
-  } else {
-    e->info_.deleter = deleter;
-  }
+  e->deleter = deleter;
   e->charge = charge;
   e->key_length = key.size();
+  e->flags = 0;
   e->hash = hash;
   e->refs = 0;
   e->next = e->prev = nullptr;
   e->SetInCache(true);
   e->SetPriority(priority);
   memcpy(e->key_data, key.data(), key.size());
+  size_t total_charge = e->CalcTotalCharge(metadata_charge_policy_);
 
-  return InsertItem(e, handle);
+  {
+    MutexLock l(&mutex_);
+
+    // Free the space following strict LRU policy until enough space
+    // is freed or the lru list is empty
+    EvictFromLRU(total_charge, &last_reference_list);
+
+    if ((usage_ + total_charge) > capacity_ &&
+        (strict_capacity_limit_ || handle == nullptr)) {
+      if (handle == nullptr) {
+        // Don't insert the entry but still return ok, as if the entry inserted
+        // into cache and get evicted immediately.
+        e->SetInCache(false);
+        last_reference_list.push_back(e);
+      } else {
+        delete[] reinterpret_cast<char*>(e);
+        *handle = nullptr;
+        s = Status::Incomplete("Insert failed due to LRU cache being full.");
+      }
+    } else {
+      // Insert into the cache. Note that the cache might get larger than its
+      // capacity if not enough space was freed up.
+      LRUHandle* old = table_.Insert(e);
+      usage_ += total_charge;
+      if (old != nullptr) {
+        s = Status::OkOverwritten();
+        assert(old->InCache());
+        old->SetInCache(false);
+        if (!old->HasRefs()) {
+          // old is on LRU because it's in cache and its reference count is 0
+          LRU_Remove(old);
+          size_t old_total_charge =
+              old->CalcTotalCharge(metadata_charge_policy_);
+          assert(usage_ >= old_total_charge);
+          usage_ -= old_total_charge;
+          last_reference_list.push_back(old);
+        }
+      }
+      if (handle == nullptr) {
+        LRU_Insert(e);
+      } else {
+        e->Ref();
+        *handle = reinterpret_cast<Cache::Handle*>(e);
+      }
+    }
+  }
+
+  // Free the entries here outside of mutex for performance reasons
+  for (auto entry : last_reference_list) {
+    entry->Free();
+  }
+
+  return s;
 }
 
 void LRUCacheShard::Erase(const Slice& key, uint32_t hash) {
@@ -536,8 +468,7 @@ LRUCache::LRUCache(size_t capacity, int num_shard_bits,
                    bool strict_capacity_limit, double high_pri_pool_ratio,
                    std::shared_ptr<MemoryAllocator> allocator,
                    bool use_adaptive_mutex,
-                   CacheMetadataChargePolicy metadata_charge_policy,
-                   const std::shared_ptr<TieredCache>& tiered_cache)
+                   CacheMetadataChargePolicy metadata_charge_policy)
     : ShardedCache(capacity, num_shard_bits, strict_capacity_limit,
                    std::move(allocator)) {
   num_shards_ = 1 << num_shard_bits;
@@ -547,7 +478,7 @@ LRUCache::LRUCache(size_t capacity, int num_shard_bits,
   for (int i = 0; i < num_shards_; i++) {
     new (&shards_[i])
         LRUCacheShard(per_shard, strict_capacity_limit, high_pri_pool_ratio,
-                      use_adaptive_mutex, metadata_charge_policy, tiered_cache);
+                      use_adaptive_mutex, metadata_charge_policy);
   }
 }
 
@@ -612,12 +543,19 @@ double LRUCache::GetHighPriPoolRatio() {
   return result;
 }
 
+std::shared_ptr<Cache> NewLRUCache(const LRUCacheOptions& cache_opts) {
+  return NewLRUCache(cache_opts.capacity, cache_opts.num_shard_bits,
+                     cache_opts.strict_capacity_limit,
+                     cache_opts.high_pri_pool_ratio,
+                     cache_opts.memory_allocator, cache_opts.use_adaptive_mutex,
+                     cache_opts.metadata_charge_policy);
+}
+
 std::shared_ptr<Cache> NewLRUCache(
     size_t capacity, int num_shard_bits, bool strict_capacity_limit,
     double high_pri_pool_ratio,
     std::shared_ptr<MemoryAllocator> memory_allocator, bool use_adaptive_mutex,
-    CacheMetadataChargePolicy metadata_charge_policy,
-    const std::shared_ptr<TieredCache>& tiered_cache) {
+    CacheMetadataChargePolicy metadata_charge_policy) {
   if (num_shard_bits >= 20) {
     return nullptr;  // the cache cannot be sharded into too many fine pieces
   }
@@ -630,25 +568,7 @@ std::shared_ptr<Cache> NewLRUCache(
   }
   return std::make_shared<LRUCache>(
       capacity, num_shard_bits, strict_capacity_limit, high_pri_pool_ratio,
-      std::move(memory_allocator), use_adaptive_mutex, metadata_charge_policy,
-      tiered_cache);
+      std::move(memory_allocator), use_adaptive_mutex, metadata_charge_policy);
 }
 
-std::shared_ptr<Cache> NewLRUCache(const LRUCacheOptions& cache_opts) {
-  return NewLRUCache(
-      cache_opts.capacity, cache_opts.num_shard_bits,
-      cache_opts.strict_capacity_limit, cache_opts.high_pri_pool_ratio,
-      cache_opts.memory_allocator, cache_opts.use_adaptive_mutex,
-      cache_opts.metadata_charge_policy, cache_opts.tiered_cache);
-}
-
-std::shared_ptr<Cache> NewLRUCache(
-    size_t capacity, int num_shard_bits, bool strict_capacity_limit,
-    double high_pri_pool_ratio,
-    std::shared_ptr<MemoryAllocator> memory_allocator, bool use_adaptive_mutex,
-    CacheMetadataChargePolicy metadata_charge_policy) {
-  return NewLRUCache(capacity, num_shard_bits, strict_capacity_limit,
-                     high_pri_pool_ratio, memory_allocator, use_adaptive_mutex,
-                     metadata_charge_policy, nullptr);
-}
 }  // namespace ROCKSDB_NAMESPACE

cache/lru_cache.h

@@ -11,9 +11,9 @@
 #include <string>
 
 #include "cache/sharded_cache.h"
+
 #include "port/malloc.h"
 #include "port/port.h"
-#include "rocksdb/tiered_cache.h"
 #include "util/autovector.h"
 
 namespace ROCKSDB_NAMESPACE {
@@ -49,14 +49,7 @@ namespace ROCKSDB_NAMESPACE {
 
 struct LRUHandle {
   void* value;
-  union Info {
-    Info() {}
-    ~Info() {}
-    void (*deleter)(const Slice&, void* value);
-    ShardedCache::CacheItemHelperCallback helper_cb;
-    // This needs to be explicitly constructed and destructed
-    std::unique_ptr<TieredCacheHandle> tiered_handle;
-  } info_;
+  void (*deleter)(const Slice&, void* value);
   LRUHandle* next_hash;
   LRUHandle* next;
   LRUHandle* prev;
@@ -76,12 +69,6 @@ struct LRUHandle {
     IN_HIGH_PRI_POOL = (1 << 2),
     // Whether this entry has had any lookups (hits).
     HAS_HIT = (1 << 3),
-    // Can this be inserted into the tiered cache
-    IS_TIERED_CACHE_COMPATIBLE = (1 << 4),
-    // Is the handle still being read from a lower tier
-    IS_PENDING = (1 << 5),
-    // Has the item been promoted from a lower tier
-    IS_PROMOTED = (1 << 6),
   };
 
   uint8_t flags;
@@ -108,11 +95,6 @@ struct LRUHandle {
   bool IsHighPri() const { return flags & IS_HIGH_PRI; }
   bool InHighPriPool() const { return flags & IN_HIGH_PRI_POOL; }
   bool HasHit() const { return flags & HAS_HIT; }
-  bool IsTieredCacheCompatible() const {
-    return flags & IS_TIERED_CACHE_COMPATIBLE;
-  }
-  bool IsPending() const { return flags & IS_PENDING; }
-  bool IsPromoted() const { return flags & IS_PROMOTED; }
 
   void SetInCache(bool in_cache) {
     if (in_cache) {
@@ -140,38 +122,10 @@ struct LRUHandle {
 
   void SetHit() { flags |= HAS_HIT; }
 
-  void SetTieredCacheCompatible(bool tiered) {
-    if (tiered) {
-      flags |= IS_TIERED_CACHE_COMPATIBLE;
-    } else {
-      flags &= ~IS_TIERED_CACHE_COMPATIBLE;
-    }
-  }
-
-  void SetIncomplete(bool incomp) {
-    if (incomp) {
-      flags |= IS_PENDING;
-    } else {
-      flags &= ~IS_PENDING;
-    }
-  }
-
-  void SetPromoted(bool promoted) {
-    if (promoted) {
-      flags |= IS_PROMOTED;
-    } else {
-      flags &= ~IS_PROMOTED;
-    }
-  }
-
   void Free() {
     assert(refs == 0);
-    if (!IsTieredCacheCompatible() && info_.deleter) {
-      (*info_.deleter)(key(), value);
-    } else if (IsTieredCacheCompatible()) {
-      ShardedCache::DeletionCallback del_cb;
-      (*info_.helper_cb)(nullptr, nullptr, &del_cb);
-      (*del_cb)(key(), value);
+    if (deleter) {
+      (*deleter)(key(), value);
     }
     delete[] reinterpret_cast<char*>(this);
   }
@@ -239,8 +193,7 @@ class ALIGN_AS(CACHE_LINE_SIZE) LRUCacheShard final : public CacheShard {
  public:
   LRUCacheShard(size_t capacity, bool strict_capacity_limit,
                 double high_pri_pool_ratio, bool use_adaptive_mutex,
-                CacheMetadataChargePolicy metadata_charge_policy,
-                const std::shared_ptr<TieredCache>& tiered_cache);
+                CacheMetadataChargePolicy metadata_charge_policy);
   virtual ~LRUCacheShard() override = default;
 
   // Separate from constructor so caller can easily make an array of LRUCache
@@ -259,32 +212,8 @@ class ALIGN_AS(CACHE_LINE_SIZE) LRUCacheShard final : public CacheShard {
                         size_t charge,
                         void (*deleter)(const Slice& key, void* value),
                         Cache::Handle** handle,
-                        Cache::Priority priority) override {
-    return Insert(key, hash, value, charge, deleter, nullptr, handle, priority);
-  }
-  virtual Status Insert(const Slice& key, uint32_t hash, void* value,
-                        Cache::CacheItemHelperCallback helper_cb, size_t charge,
-                        Cache::Handle** handle,
-                        Cache::Priority priority) override {
-    return Insert(key, hash, value, charge, nullptr, helper_cb, handle,
-                  priority);
-  }
-  // If helper_cb is null, the values of the following arguments don't
-  // matter
-  virtual Cache::Handle* Lookup(const Slice& key, uint32_t hash,
-                                ShardedCache::CacheItemHelperCallback helper_cb,
-                                const ShardedCache::CreateCallback& create_cb,
-                                ShardedCache::Priority priority,
-                                bool wait) override;
-  virtual Cache::Handle* Lookup(const Slice& key, uint32_t hash) override {
-    return Lookup(key, hash, nullptr, nullptr, Cache::Priority::LOW, true);
-  }
-  virtual bool Release(Cache::Handle* handle, bool /*useful*/,
-                       bool force_erase) override {
-    return Release(handle, force_erase);
-  }
-  virtual bool isReady(Cache::Handle* /*handle*/) override { return true; }
-  virtual void Wait(Cache::Handle* /*handle*/) override {}
+                        Cache::Priority priority) override;
+  virtual Cache::Handle* Lookup(const Slice& key, uint32_t hash) override;
   virtual bool Ref(Cache::Handle* handle) override;
   virtual bool Release(Cache::Handle* handle,
                        bool force_erase = false) override;
@@ -314,11 +243,6 @@ class ALIGN_AS(CACHE_LINE_SIZE) LRUCacheShard final : public CacheShard {
   double GetHighPriPoolRatio();
 
  private:
-  Status InsertItem(LRUHandle* item, Cache::Handle** handle);
-  Status Insert(const Slice& key, uint32_t hash, void* value, size_t charge,
-                void (*deleter)(const Slice& key, void* value),
-                Cache::CacheItemHelperCallback helper_cb,
-                Cache::Handle** handle, Cache::Priority priority);
   void LRU_Remove(LRUHandle* e);
   void LRU_Insert(LRUHandle* e);
 
@@ -379,8 +303,6 @@ class ALIGN_AS(CACHE_LINE_SIZE) LRUCacheShard final : public CacheShard {
   // We don't count mutex_ as the cache's internal state so semantically we
   // don't mind mutex_ invoking the non-const actions.
   mutable port::Mutex mutex_;
-
-  std::shared_ptr<TieredCache> tiered_cache_;
 };
 
 class LRUCache
@@ -394,8 +316,7 @@ class LRUCache
            std::shared_ptr<MemoryAllocator> memory_allocator = nullptr,
            bool use_adaptive_mutex = kDefaultToAdaptiveMutex,
            CacheMetadataChargePolicy metadata_charge_policy =
-               kDontChargeCacheMetadata,
-           const std::shared_ptr<TieredCache>& tiered_cache = nullptr);
+               kDontChargeCacheMetadata);
   virtual ~LRUCache();
   virtual const char* Name() const override { return "LRUCache"; }
   virtual CacheShard* GetShard(int shard) override;
@@ -404,7 +325,6 @@ class LRUCache
   virtual size_t GetCharge(Handle* handle) const override;
   virtual uint32_t GetHash(Handle* handle) const override;
   virtual void DisownData() override;
-  virtual void WaitAll(std::vector<Handle*>& /*handles*/) override {}
 
   //  Retrieves number of elements in LRU, for unit test purpose only
   size_t TEST_GetLRUSize();

cache/lru_cache_test.cc

@@ -7,12 +7,8 @@
 
 #include <string>
 #include <vector>
-
 #include "port/port.h"
-#include "rocksdb/cache.h"
 #include "test_util/testharness.h"
-#include "util/coding.h"
-#include "util/random.h"
 
 namespace ROCKSDB_NAMESPACE {
 
@@ -34,9 +30,9 @@ class LRUCacheTest : public testing::Test {
     DeleteCache();
     cache_ = reinterpret_cast<LRUCacheShard*>(
         port::cacheline_aligned_alloc(sizeof(LRUCacheShard)));
-    new (cache_) LRUCacheShard(
-        capacity, false /*strict_capcity_limit*/, high_pri_pool_ratio,
-        use_adaptive_mutex, kDontChargeCacheMetadata, nullptr /*tiered_cache*/);
+    new (cache_) LRUCacheShard(capacity, false /*strict_capacity_limit*/,
+                               high_pri_pool_ratio, use_adaptive_mutex,
+                               kDontChargeCacheMetadata);
   }
 
   void Insert(const std::string& key,
@@ -195,175 +191,6 @@ TEST_F(LRUCacheTest, EntriesWithPriority) {
   ValidateLRUList({"e", "f", "g", "Z", "d"}, 2);
 }
 
-class TestTieredCache : public TieredCache {
- public:
-  TestTieredCache(size_t capacity) : num_inserts_(0), num_lookups_(0) {
-    cache_ = NewLRUCache(capacity, 0, false, 0.5, nullptr,
-                         kDefaultToAdaptiveMutex, kDontChargeCacheMetadata);
-  }
-  ~TestTieredCache() { cache_.reset(); }
-
-  std::string Name() override { return "TestTieredCache"; }
-
-  Status Insert(const Slice& key, void* value,
-                Cache::CacheItemHelperCallback helper_cb) override {
-    Cache::SizeCallback size_cb;
-    Cache::SaveToCallback save_cb;
-    size_t size;
-    char* buf;
-    Status s;
-
-    num_inserts_++;
-    (*helper_cb)(&size_cb, &save_cb, nullptr);
-    size = (*size_cb)(value);
-    buf = new char[size + sizeof(uint64_t)];
-    EncodeFixed64(buf, size);
-    s = (*save_cb)(value, 0, size, buf + sizeof(uint64_t));
-    EXPECT_OK(s);
-    return cache_->Insert(key, buf, size,
-                          [](const Slice& /*key*/, void* val) -> void {
-                            delete[] reinterpret_cast<char*>(val);
-                          });
-  }
-
-  std::unique_ptr<TieredCacheHandle> Lookup(
-      const Slice& key, const Cache::CreateCallback& create_cb,
-      bool /*wait*/) override {
-    std::unique_ptr<TieredCacheHandle> tiered_handle;
-    Cache::Handle* handle = cache_->Lookup(key);
-    num_lookups_++;
-    if (handle) {
-      void* value;
-      size_t charge;
-      char* ptr = (char*)cache_->Value(handle);
-      size_t size = DecodeFixed64(ptr);
-      ptr += sizeof(uint64_t);
-      Status s = create_cb(ptr, size, &value, &charge);
-      EXPECT_OK(s);
-      tiered_handle.reset(
-          new TestTieredCacheHandle(cache_.get(), handle, value, charge));
-    }
-    return tiered_handle;
-  }
-
-  void Erase(const Slice& /*key*/) override {}
-
-  void WaitAll(std::vector<TieredCacheHandle*> /*handles*/) override {}
-
-  std::string GetPrintableOptions() const override { return ""; }
-
-  uint32_t num_inserts() { return num_inserts_; }
-
-  uint32_t num_lookups() { return num_lookups_; }
-
- private:
-  class TestTieredCacheHandle : public TieredCacheHandle {
-   public:
-    TestTieredCacheHandle(Cache* cache, Cache::Handle* handle, void* value,
-                          size_t size)
-        : cache_(cache), handle_(handle), value_(value), size_(size) {}
-    ~TestTieredCacheHandle() { cache_->Release(handle_); }
-
-    bool isReady() override { return true; }
-
-    void Wait() override {}
-
-    void* Value() override { return value_; }
-
-    size_t Size() override { return size_; }
-
-   private:
-    Cache* cache_;
-    Cache::Handle* handle_;
-    void* value_;
-    size_t size_;
-  };
-
-  std::shared_ptr<Cache> cache_;
-  uint32_t num_inserts_;
-  uint32_t num_lookups_;
-};
-
-TEST_F(LRUCacheTest, TestTieredCache) {
-  LRUCacheOptions opts(1024, 0, false, 0.5, nullptr, kDefaultToAdaptiveMutex,
-                       kDontChargeCacheMetadata);
-  std::shared_ptr<TestTieredCache> tiered_cache(new TestTieredCache(2048));
-  opts.tiered_cache = tiered_cache;
-  std::shared_ptr<Cache> cache = NewLRUCache(opts);
-
-  class TestItem {
-   public:
-    TestItem(const char* buf, size_t size) : buf_(new char[size]), size_(size) {
-      memcpy(buf_.get(), buf, size);
-    }
-    ~TestItem() {}
-
-    char* Buf() { return buf_.get(); }
-    size_t Size() { return size_; }
-
-   private:
-    std::unique_ptr<char[]> buf_;
-    size_t size_;
-  };
-
-  Cache::CacheItemHelperCallback helper_cb =
-      [](Cache::SizeCallback* size_cb, Cache::SaveToCallback* saveto_cb,
-         Cache::DeletionCallback* del_cb) -> void {
-    if (size_cb) {
-      *size_cb = [](void* obj) -> size_t {
-        return reinterpret_cast<TestItem*>(obj)->Size();
-      };
-    }
-    if (saveto_cb) {
-      *saveto_cb = [](void* obj, size_t offset, size_t size,
-                      void* out) -> Status {
-        TestItem* item = reinterpret_cast<TestItem*>(obj);
-        char* buf = item->Buf();
-        EXPECT_EQ(size, item->Size());
-        EXPECT_EQ(offset, 0);
-        memcpy(out, buf, size);
-        return Status::OK();
-      };
-    }
-    if (del_cb) {
-      *del_cb = [](const Slice& /*key*/, void* obj) -> void {
-        delete reinterpret_cast<TestItem*>(obj);
-      };
-    }
-  };
-
-  int create_count = 0;
-  Cache::CreateCallback test_item_creator =
-      [&create_count](void* buf, size_t size, void** out_obj,
-                      size_t* charge) -> Status {
-    create_count++;
-    *out_obj = reinterpret_cast<void*>(new TestItem((char*)buf, size));
-    *charge = size;
-    return Status::OK();
-  };
-
-  Random rnd(301);
-  std::string str1 = rnd.RandomString(1020);
-  TestItem* item1 = new TestItem(str1.data(), str1.length());
-  ASSERT_OK(cache->Insert("k1", item1, helper_cb, str1.length()));
-  std::string str2 = rnd.RandomString(1020);
-  TestItem* item2 = new TestItem(str2.data(), str2.length());
-  // k2 should be demoted to NVM
-  ASSERT_OK(cache->Insert("k2", item2, helper_cb, str2.length()));
-
-  Cache::Handle* handle;
-  handle = cache->Lookup("k2", helper_cb, test_item_creator,
-                         Cache::Priority::LOW, true);
-  ASSERT_NE(handle, nullptr);
-  cache->Release(handle);
-  // This lookup should promote k1 and demote k2
-  handle = cache->Lookup("k1", helper_cb, test_item_creator,
-                         Cache::Priority::LOW, true);
-  ASSERT_NE(handle, nullptr);
-  cache->Release(handle);
-  ASSERT_EQ(tiered_cache->num_inserts(), 2u);
-  ASSERT_EQ(tiered_cache->num_lookups(), 1u);
-}
 }  // namespace ROCKSDB_NAMESPACE
 
 int main(int argc, char** argv) {

cache/sharded_cache.cc

@@ -51,39 +51,11 @@ Status ShardedCache::Insert(const Slice& key, void* value, size_t charge,
       ->Insert(key, hash, value, charge, deleter, handle, priority);
 }
 
-Status ShardedCache::Insert(const Slice& key, void* value,
-                            CacheItemHelperCallback helper_cb, size_t charge,
-                            Handle** handle, Priority priority) {
-  uint32_t hash = HashSlice(key);
-  return GetShard(Shard(hash))
-      ->Insert(key, hash, value, helper_cb, charge, handle, priority);
-}
-
 Cache::Handle* ShardedCache::Lookup(const Slice& key, Statistics* /*stats*/) {
   uint32_t hash = HashSlice(key);
   return GetShard(Shard(hash))->Lookup(key, hash);
 }
 
-Cache::Handle* ShardedCache::Lookup(const Slice& key,
-                                    CacheItemHelperCallback helper_cb,
-                                    const CreateCallback& create_cb,
-                                    Priority priority, bool wait,
-                                    Statistics* /*stats*/) {
-  uint32_t hash = HashSlice(key);
-  return GetShard(Shard(hash))
-      ->Lookup(key, hash, helper_cb, create_cb, priority, wait);
-}
-
-bool ShardedCache::isReady(Handle* handle) {
-  uint32_t hash = GetHash(handle);
-  return GetShard(Shard(hash))->isReady(handle);
-}
-
-void ShardedCache::Wait(Handle* handle) {
-  uint32_t hash = GetHash(handle);
-  GetShard(Shard(hash))->Wait(handle);
-}
-
 bool ShardedCache::Ref(Handle* handle) {
   uint32_t hash = GetHash(handle);
   return GetShard(Shard(hash))->Ref(handle);
@@ -94,11 +66,6 @@ bool ShardedCache::Release(Handle* handle, bool force_erase) {
   return GetShard(Shard(hash))->Release(handle, force_erase);
 }
 
-bool ShardedCache::Release(Handle* handle, bool useful, bool force_erase) {
-  uint32_t hash = GetHash(handle);
-  return GetShard(Shard(hash))->Release(handle, useful, force_erase);
-}
-
 void ShardedCache::Erase(const Slice& key) {
   uint32_t hash = HashSlice(key);
   GetShard(Shard(hash))->Erase(key, hash);

cache/sharded_cache.h

@@ -28,20 +28,9 @@ class CacheShard {
                         size_t charge,
                         void (*deleter)(const Slice& key, void* value),
                         Cache::Handle** handle, Cache::Priority priority) = 0;
-  virtual Status Insert(const Slice& key, uint32_t hash, void* value,
-                        Cache::CacheItemHelperCallback helper_cb, size_t charge,
-                        Cache::Handle** handle, Cache::Priority priority) = 0;
   virtual Cache::Handle* Lookup(const Slice& key, uint32_t hash) = 0;
-  virtual Cache::Handle* Lookup(const Slice& key, uint32_t hash,
-                                Cache::CacheItemHelperCallback helper_cb,
-                                const Cache::CreateCallback& create_cb,
-                                Cache::Priority priority, bool wait) = 0;
-  virtual bool Release(Cache::Handle* handle, bool useful,
-                       bool force_erase) = 0;
-  virtual bool isReady(Cache::Handle* handle) = 0;
-  virtual void Wait(Cache::Handle* handle) = 0;
   virtual bool Ref(Cache::Handle* handle) = 0;
-  virtual bool Release(Cache::Handle* handle, bool force_erase) = 0;
+  virtual bool Release(Cache::Handle* handle, bool force_erase = false) = 0;
   virtual void Erase(const Slice& key, uint32_t hash) = 0;
   virtual void SetCapacity(size_t capacity) = 0;
   virtual void SetStrictCapacityLimit(bool strict_capacity_limit) = 0;
@@ -73,7 +62,6 @@ class ShardedCache : public Cache {
   virtual const CacheShard* GetShard(int shard) const = 0;
   virtual void* Value(Handle* handle) override = 0;
   virtual size_t GetCharge(Handle* handle) const override = 0;
-  virtual void WaitAll(std::vector<Handle*>& handles) override = 0;
 
   virtual uint32_t GetHash(Handle* handle) const = 0;
   virtual void DisownData() override = 0;
@@ -84,18 +72,7 @@ class ShardedCache : public Cache {
   virtual Status Insert(const Slice& key, void* value, size_t charge,
                         void (*deleter)(const Slice& key, void* value),
                         Handle** handle, Priority priority) override;
-  virtual Status Insert(const Slice& key, void* value,
-                        CacheItemHelperCallback helper_cb, size_t chargge,
-                        Handle** handle = nullptr,
-                        Priority priority = Priority::LOW) override;
   virtual Handle* Lookup(const Slice& key, Statistics* stats) override;
-  virtual Handle* Lookup(const Slice& key, CacheItemHelperCallback helper_cb,
-                         const CreateCallback& create_cb, Priority priority,
-                         bool wait, Statistics* stats = nullptr) override;
-  virtual bool Release(Handle* handle, bool useful,
-                       bool force_erase = false) override;
-  virtual bool isReady(Handle* handle) override;
-  virtual void Wait(Handle* handle) override;
   virtual bool Ref(Handle* handle) override;
   virtual bool Release(Handle* handle, bool force_erase = false) override;
   virtual void Erase(const Slice& key) override;

db/blob/blob_file_builder.cc

@@ -190,7 +190,7 @@ Status BlobFileBuilder::OpenBlobFileIfNeeded() {
       std::move(file), blob_file_paths_->back(), *file_options_,
       immutable_cf_options_->clock, io_tracer_, statistics,
       immutable_cf_options_->listeners,
-      immutable_cf_options_->file_checksum_gen_factory.get(),
+      immutable_cf_options_->file_checksum_gen_factory,
       tmp_set.Contains(FileType::kBlobFile)));
 
   constexpr bool do_flush = false;

db/blob/blob_file_reader.cc

@@ -120,7 +120,7 @@ Status BlobFileReader::OpenFile(
   file_reader->reset(new RandomAccessFileReader(
       std::move(file), blob_file_path, immutable_cf_options.clock, io_tracer,
       immutable_cf_options.statistics, BLOB_DB_BLOB_FILE_READ_MICROS,
-      blob_file_read_hist, immutable_cf_options.rate_limiter.get(),
+      blob_file_read_hist, immutable_cf_options.rate_limiter,
       immutable_cf_options.listeners));
 
   return Status::OK();

db/blob/db_blob_basic_test.cc

@@ -267,49 +267,6 @@ TEST_F(DBBlobBasicTest, GenerateIOTracing) {
 }
 #endif  // !ROCKSDB_LITE
 
-TEST_F(DBBlobBasicTest, BestEffortsRecovery_MissingNewestBlobFile) {
-  Options options = GetDefaultOptions();
-  options.enable_blob_files = true;
-  options.min_blob_size = 0;
-  options.create_if_missing = true;
-  Reopen(options);
-
-  ASSERT_OK(dbfull()->DisableFileDeletions());
-  constexpr int kNumTableFiles = 2;
-  for (int i = 0; i < kNumTableFiles; ++i) {
-    for (char ch = 'a'; ch != 'c'; ++ch) {
-      std::string key(1, ch);
-      ASSERT_OK(Put(key, "value" + std::to_string(i)));
-    }
-    ASSERT_OK(Flush());
-  }
-
-  Close();
-
-  std::vector<std::string> files;
-  ASSERT_OK(env_->GetChildren(dbname_, &files));
-  std::string blob_file_path;
-  uint64_t max_blob_file_num = kInvalidBlobFileNumber;
-  for (const auto& fname : files) {
-    uint64_t file_num = 0;
-    FileType type;
-    if (ParseFileName(fname, &file_num, /*info_log_name_prefix=*/"", &type) &&
-        type == kBlobFile) {
-      if (file_num > max_blob_file_num) {
-        max_blob_file_num = file_num;
-        blob_file_path = dbname_ + "/" + fname;
-      }
-    }
-  }
-  ASSERT_OK(env_->DeleteFile(blob_file_path));
-
-  options.best_efforts_recovery = true;
-  Reopen(options);
-  std::string value;
-  ASSERT_OK(db_->Get(ReadOptions(), "a", &value));
-  ASSERT_EQ("value" + std::to_string(kNumTableFiles - 2), value);
-}
-
 class DBBlobBasicIOErrorTest : public DBBlobBasicTest,
                                public testing::WithParamInterface<std::string> {
  protected:

db/builder.cc

@@ -156,7 +156,7 @@ Status BuildTable(
       file_writer.reset(new WritableFileWriter(
           std::move(file), fname, file_options, ioptions.clock, io_tracer,
           ioptions.statistics, ioptions.listeners,
-          ioptions.file_checksum_gen_factory.get(),
+          ioptions.file_checksum_gen_factory,
           tmp_set.Contains(FileType::kTableFile)));
 
       builder = NewTableBuilder(
@@ -168,7 +168,7 @@ Status BuildTable(
     }
 
     MergeHelper merge(env, internal_comparator.user_comparator(),
-                      ioptions.merge_operator.get(), nullptr, ioptions.info_log,
+                      ioptions.merge_operator, nullptr, ioptions.info_log,
                       true /* internal key corruption is not ok */,
                       snapshots.empty() ? 0 : snapshots.back(),
                       snapshot_checker);

db/c.cc

@@ -79,8 +79,6 @@ using ROCKSDB_NAMESPACE::IngestExternalFileOptions;
 using ROCKSDB_NAMESPACE::Iterator;
 using ROCKSDB_NAMESPACE::LiveFileMetaData;
 using ROCKSDB_NAMESPACE::Logger;
-using ROCKSDB_NAMESPACE::LRUCacheOptions;
-using ROCKSDB_NAMESPACE::MemoryAllocator;
 using ROCKSDB_NAMESPACE::MemoryUtil;
 using ROCKSDB_NAMESPACE::MergeOperator;
 using ROCKSDB_NAMESPACE::NewBloomFilterPolicy;
@@ -152,12 +150,6 @@ struct rocksdb_filelock_t        { FileLock*         rep; };
 struct rocksdb_logger_t {
   std::shared_ptr<Logger> rep;
 };
-struct rocksdb_lru_cache_options_t {
-  LRUCacheOptions rep;
-};
-struct rocksdb_memory_allocator_t {
-  std::shared_ptr<MemoryAllocator> rep;
-};
 struct rocksdb_cache_t {
   std::shared_ptr<Cache> rep;
 };
@@ -4163,50 +4155,12 @@ unsigned char rocksdb_flushoptions_get_wait(rocksdb_flushoptions_t* opt) {
   return opt->rep.wait;
 }
 
-rocksdb_memory_allocator_t* rocksdb_jemalloc_nodump_allocator_create(
-    char** errptr) {
-  rocksdb_memory_allocator_t* allocator = new rocksdb_memory_allocator_t;
-  ROCKSDB_NAMESPACE::JemallocAllocatorOptions options;
-  SaveError(errptr, ROCKSDB_NAMESPACE::NewJemallocNodumpAllocator(
-                        options, &allocator->rep));
-  return allocator;
-}
-
-void rocksdb_memory_allocator_destroy(rocksdb_memory_allocator_t* allocator) {
-  delete allocator;
-}
-
-rocksdb_lru_cache_options_t* rocksdb_lru_cache_options_create() {
-  return new rocksdb_lru_cache_options_t;
-}
-
-void rocksdb_lru_cache_options_destroy(rocksdb_lru_cache_options_t* opt) {
-  delete opt;
-}
-
-void rocksdb_lru_cache_options_set_capacity(rocksdb_lru_cache_options_t* opt,
-                                            size_t capacity) {
-  opt->rep.capacity = capacity;
-}
-
-void rocksdb_lru_cache_options_set_memory_allocator(
-    rocksdb_lru_cache_options_t* opt, rocksdb_memory_allocator_t* allocator) {
-  opt->rep.memory_allocator = allocator->rep;
-}
-
 rocksdb_cache_t* rocksdb_cache_create_lru(size_t capacity) {
   rocksdb_cache_t* c = new rocksdb_cache_t;
   c->rep = NewLRUCache(capacity);
   return c;
 }
 
-rocksdb_cache_t* rocksdb_cache_create_lru_opts(
-    rocksdb_lru_cache_options_t* opt) {
-  rocksdb_cache_t* c = new rocksdb_cache_t;
-  c->rep = NewLRUCache(opt->rep);
-  return c;
-}
-
 void rocksdb_cache_destroy(rocksdb_cache_t* cache) {
   delete cache;
 }

db/c_test.c

@@ -2381,37 +2381,6 @@ int main(int argc, char** argv) {
     rocksdb_cache_destroy(co);
   }
 
-  StartPhase("jemalloc_nodump_allocator");
-  {
-    rocksdb_memory_allocator_t* allocator;
-    allocator = rocksdb_jemalloc_nodump_allocator_create(&err);
-    if (err != NULL) {
-      // not supported on all platforms, allow unsupported error
-      const char* ni = "Not implemented: ";
-      size_t ni_len = strlen(ni);
-      size_t err_len = strlen(err);
-
-      CheckCondition(err_len >= ni_len);
-      CheckCondition(memcmp(ni, err, ni_len) == 0);
-      Free(&err);
-    } else {
-      rocksdb_cache_t* co;
-      rocksdb_lru_cache_options_t* copts;
-
-      copts = rocksdb_lru_cache_options_create();
-
-      rocksdb_lru_cache_options_set_capacity(copts, 100);
-      rocksdb_lru_cache_options_set_memory_allocator(copts, allocator);
-
-      co = rocksdb_cache_create_lru_opts(copts);
-      CheckCondition(100 == rocksdb_cache_get_capacity(co));
-
-      rocksdb_cache_destroy(co);
-      rocksdb_lru_cache_options_destroy(copts);
-    }
-    rocksdb_memory_allocator_destroy(allocator);
-  }
-
   StartPhase("env");
   {
     rocksdb_env_t* e;

db/compaction/compaction_job.cc

@@ -312,19 +312,14 @@ CompactionJob::CompactionJob(
     const std::atomic<int>* manual_compaction_paused, const std::string& db_id,
     const std::string& db_session_id, std::string full_history_ts_low,
     BlobFileCompletionCallback* blob_callback)
-    : compact_(new CompactionState(compaction)),
-      compaction_stats_(compaction->compaction_reason(), 1),
-      db_options_(db_options),
-      log_buffer_(log_buffer),
-      output_directory_(output_directory),
-      stats_(stats),
-      bottommost_level_(false),
-      write_hint_(Env::WLTH_NOT_SET),
-      job_id_(job_id),
+    : job_id_(job_id),
+      compact_(new CompactionState(compaction)),
       compaction_job_stats_(compaction_job_stats),
+      compaction_stats_(compaction->compaction_reason(), 1),
       dbname_(dbname),
       db_id_(db_id),
       db_session_id_(db_session_id),
+      db_options_(db_options),
       file_options_(file_options),
       env_(db_options.env),
       io_tracer_(io_tracer),
@@ -335,8 +330,11 @@ CompactionJob::CompactionJob(
       shutting_down_(shutting_down),
       manual_compaction_paused_(manual_compaction_paused),
       preserve_deletes_seqnum_(preserve_deletes_seqnum),
+      log_buffer_(log_buffer),
       db_directory_(db_directory),
+      output_directory_(output_directory),
       blob_output_directory_(blob_output_directory),
+      stats_(stats),
       db_mutex_(db_mutex),
       db_error_handler_(db_error_handler),
       existing_snapshots_(std::move(existing_snapshots)),
@@ -344,8 +342,10 @@ CompactionJob::CompactionJob(
       snapshot_checker_(snapshot_checker),
       table_cache_(std::move(table_cache)),
       event_logger_(event_logger),
+      bottommost_level_(false),
       paranoid_file_checks_(paranoid_file_checks),
       measure_io_stats_(measure_io_stats),
+      write_hint_(Env::WLTH_NOT_SET),
       thread_pri_(thread_pri),
       full_history_ts_low_(std::move(full_history_ts_low)),
       blob_callback_(blob_callback) {
@@ -965,7 +965,7 @@ void CompactionJob::ProcessKeyValueCompaction(SubcompactionState* sub_compact) {
   }
 
   MergeHelper merge(
-      env_, cfd->user_comparator(), cfd->ioptions()->merge_operator.get(),
+      env_, cfd->user_comparator(), cfd->ioptions()->merge_operator,
       compaction_filter, db_options_.info_log.get(),
       false /* internal key corruption is expected */,
       existing_snapshots_.empty() ? 0 : existing_snapshots_.back(),
@@ -1550,7 +1550,9 @@ Status CompactionJob::FinishCompactionOutputFile(
   FileDescriptor output_fd;
   uint64_t oldest_blob_file_number = kInvalidBlobFileNumber;
   if (meta != nullptr) {
-    fname = GetTableFileName(meta->fd.GetNumber());
+    fname =
+        TableFileName(sub_compact->compaction->immutable_cf_options()->cf_paths,
+                      meta->fd.GetNumber(), meta->fd.GetPathId());
     output_fd = meta->fd;
     oldest_blob_file_number = meta->oldest_blob_file_number;
   } else {
@@ -1670,7 +1672,9 @@ Status CompactionJob::OpenCompactionOutputFile(
   assert(sub_compact->builder == nullptr);
   // no need to lock because VersionSet::next_file_number_ is atomic
   uint64_t file_number = versions_->NewFileNumber();
-  std::string fname = GetTableFileName(file_number);
+  std::string fname =
+      TableFileName(sub_compact->compaction->immutable_cf_options()->cf_paths,
+                    file_number, sub_compact->compaction->output_path_id());
   // Fire events.
   ColumnFamilyData* cfd = sub_compact->compaction->column_family_data();
 #ifndef ROCKSDB_LITE
@@ -1933,132 +1937,4 @@ void CompactionJob::LogCompaction() {
   }
 }
 
-std::string CompactionJob::GetTableFileName(uint64_t file_number) {
-  return TableFileName(compact_->compaction->immutable_cf_options()->cf_paths,
-                       file_number, compact_->compaction->output_path_id());
-}
-
-std::string CompactionServiceCompactionJob::GetTableFileName(
-    uint64_t file_number) {
-  return MakeTableFileName(output_path_, file_number);
-}
-
-CompactionServiceCompactionJob::CompactionServiceCompactionJob(
-    int job_id, Compaction* compaction, const ImmutableDBOptions& db_options,
-    const FileOptions& file_options, VersionSet* versions,
-    const std::atomic<bool>* shutting_down, LogBuffer* log_buffer,
-    FSDirectory* output_directory, Statistics* stats,
-    InstrumentedMutex* db_mutex, ErrorHandler* db_error_handler,
-    std::vector<SequenceNumber> existing_snapshots,
-    std::shared_ptr<Cache> table_cache, EventLogger* event_logger,
-    const std::string& dbname, const std::shared_ptr<IOTracer>& io_tracer,
-    const std::string& db_id, const std::string& db_session_id,
-    const std::string& output_path,
-    const CompactionServiceInput& compaction_service_input,
-    CompactionServiceResult* compaction_service_result)
-    : CompactionJob(
-          job_id, compaction, db_options, file_options, versions, shutting_down,
-          0, log_buffer, nullptr, output_directory, nullptr, stats, db_mutex,
-          db_error_handler, existing_snapshots, kMaxSequenceNumber, nullptr,
-          table_cache, event_logger,
-          compaction->mutable_cf_options()->paranoid_file_checks,
-          compaction->mutable_cf_options()->report_bg_io_stats, dbname,
-          &(compaction_service_result->stats), Env::Priority::USER, io_tracer,
-          nullptr, db_id, db_session_id,
-          compaction->column_family_data()->GetFullHistoryTsLow()),
-      output_path_(output_path),
-      compaction_input_(compaction_service_input),
-      compaction_result_(compaction_service_result) {}
-
-Status CompactionServiceCompactionJob::Run() {
-  AutoThreadOperationStageUpdater stage_updater(
-      ThreadStatus::STAGE_COMPACTION_RUN);
-
-  auto* c = compact_->compaction;
-  assert(c->column_family_data() != nullptr);
-  assert(c->column_family_data()->current()->storage_info()->NumLevelFiles(
-             compact_->compaction->level()) > 0);
-
-  write_hint_ =
-      c->column_family_data()->CalculateSSTWriteHint(c->output_level());
-  bottommost_level_ = c->bottommost_level();
-
-  compact_->sub_compact_states.emplace_back(c, compaction_input_.begin,
-                                            compaction_input_.end,
-                                            compaction_input_.approx_size);
-
-  log_buffer_->FlushBufferToLog();
-  LogCompaction();
-  const uint64_t start_micros = db_options_.clock->NowMicros();
-  // Pick the only sub-compaction we should have
-  assert(compact_->sub_compact_states.size() == 1);
-  SubcompactionState* sub_compact = compact_->sub_compact_states.data();
-
-  ProcessKeyValueCompaction(sub_compact);
-
-  compaction_stats_.micros = db_options_.clock->NowMicros() - start_micros;
-  compaction_stats_.cpu_micros = sub_compact->compaction_job_stats.cpu_micros;
-
-  RecordTimeToHistogram(stats_, COMPACTION_TIME, compaction_stats_.micros);
-  RecordTimeToHistogram(stats_, COMPACTION_CPU_TIME,
-                        compaction_stats_.cpu_micros);
-
-  Status status = sub_compact->status;
-  IOStatus io_s = sub_compact->io_status;
-
-  if (io_status_.ok()) {
-    io_status_ = io_s;
-  }
-
-  if (status.ok()) {
-    constexpr IODebugContext* dbg = nullptr;
-
-    if (output_directory_) {
-      io_s = output_directory_->Fsync(IOOptions(), dbg);
-    }
-  }
-  if (io_status_.ok()) {
-    io_status_ = io_s;
-  }
-  if (status.ok()) {
-    status = io_s;
-  }
-  if (status.ok()) {
-    // TODO: Add verify_table() and VerifyCompactionFileConsistency()
-  }
-
-  // Finish up all book-keeping to unify the subcompaction results
-  AggregateStatistics();
-  UpdateCompactionStats();
-
-  compaction_result_->bytes_written = IOSTATS(bytes_written);
-  compaction_result_->bytes_read = IOSTATS(bytes_read);
-  RecordCompactionIOStats();
-
-  LogFlush(db_options_.info_log);
-  compact_->status = status;
-  compact_->status.PermitUncheckedError();
-
-  // Build compaction result
-  compaction_result_->output_level = compact_->compaction->output_level();
-  compaction_result_->output_path = output_path_;
-  for (const auto& output_file : sub_compact->outputs) {
-    auto& meta = output_file.meta;
-    compaction_result_->output_files.emplace_back(
-        MakeTableFileName(meta.fd.GetNumber()), meta.fd.smallest_seqno,
-        meta.fd.largest_seqno, meta.smallest.Encode().ToString(),
-        meta.largest.Encode().ToString(), meta.oldest_ancester_time,
-        meta.file_creation_time, output_file.validator.GetHash(),
-        meta.marked_for_compaction);
-  }
-  compaction_result_->num_output_records = sub_compact->num_output_records;
-  compaction_result_->total_bytes = sub_compact->total_bytes;
-
-  return status;
-}
-
-void CompactionServiceCompactionJob::CleanupCompaction() {
-  CompactionJob::CleanupCompaction();
-}
-
 }  // namespace ROCKSDB_NAMESPACE

db/compaction/compaction_job.h

@@ -84,7 +84,7 @@ class CompactionJob {
       std::string full_history_ts_low = "",
       BlobFileCompletionCallback* blob_callback = nullptr);
 
-  virtual ~CompactionJob();
+  ~CompactionJob();
 
   // no copy/move
   CompactionJob(CompactionJob&& job) = delete;
@@ -107,35 +107,11 @@ class CompactionJob {
   // Return the IO status
   IOStatus io_status() const { return io_status_; }
 
- protected:
+ private:
   struct SubcompactionState;
-  // CompactionJob state
-  struct CompactionState;
 
   void AggregateStatistics();
-  void UpdateCompactionStats();
-  void LogCompaction();
-  void RecordCompactionIOStats();
-  void CleanupCompaction();
 
-  // Call compaction filter. Then iterate through input and compact the
-  // kv-pairs
-  void ProcessKeyValueCompaction(SubcompactionState* sub_compact);
-
-  CompactionState* compact_;
-  InternalStats::CompactionStats compaction_stats_;
-  const ImmutableDBOptions& db_options_;
-  LogBuffer* log_buffer_;
-  FSDirectory* output_directory_;
-  Statistics* stats_;
-  // Is this compaction creating a file in the bottom most level?
-  bool bottommost_level_;
-
-  Env::WriteLifeTimeHint write_hint_;
-
-  IOStatus io_status_;
-
- private:
   // Generates a histogram representing potential divisions of key ranges from
   // the input. It adds the starting and/or ending keys of certain input files
   // to the working set and then finds the approximate size of data in between
@@ -146,6 +122,9 @@ class CompactionJob {
   // update the thread status for starting a compaction.
   void ReportStartedCompaction(Compaction* compaction);
   void AllocateCompactionOutputFileNumbers();
+  // Call compaction filter. Then iterate through input and compact the
+  // kv-pairs
+  void ProcessKeyValueCompaction(SubcompactionState* sub_compact);
 
   Status FinishCompactionOutputFile(
       const Status& input_status, SubcompactionState* sub_compact,
@@ -153,23 +132,33 @@ class CompactionJob {
       CompactionIterationStats* range_del_out_stats,
       const Slice* next_table_min_key = nullptr);
   Status InstallCompactionResults(const MutableCFOptions& mutable_cf_options);
+  void RecordCompactionIOStats();
   Status OpenCompactionOutputFile(SubcompactionState* sub_compact);
+  void CleanupCompaction();
   void UpdateCompactionJobStats(
     const InternalStats::CompactionStats& stats) const;
   void RecordDroppedKeys(const CompactionIterationStats& c_iter_stats,
                          CompactionJobStats* compaction_job_stats = nullptr);
 
+  void UpdateCompactionStats();
   void UpdateCompactionInputStatsHelper(
       int* num_files, uint64_t* bytes_read, int input_level);
 
+  void LogCompaction();
+
   int job_id_;
 
+  // CompactionJob state
+  struct CompactionState;
+  CompactionState* compact_;
   CompactionJobStats* compaction_job_stats_;
+  InternalStats::CompactionStats compaction_stats_;
 
   // DBImpl state
   const std::string& dbname_;
   const std::string db_id_;
   const std::string db_session_id_;
+  const ImmutableDBOptions& db_options_;
   const FileOptions file_options_;
 
   Env* env_;
@@ -181,8 +170,11 @@ class CompactionJob {
   const std::atomic<bool>* shutting_down_;
   const std::atomic<int>* manual_compaction_paused_;
   const SequenceNumber preserve_deletes_seqnum_;
+  LogBuffer* log_buffer_;
   FSDirectory* db_directory_;
+  FSDirectory* output_directory_;
   FSDirectory* blob_output_directory_;
+  Statistics* stats_;
   InstrumentedMutex* db_mutex_;
   ErrorHandler* db_error_handler_;
   // If there were two snapshots with seq numbers s1 and
@@ -202,128 +194,19 @@ class CompactionJob {
 
   EventLogger* event_logger_;
 
+  // Is this compaction creating a file in the bottom most level?
+  bool bottommost_level_;
   bool paranoid_file_checks_;
   bool measure_io_stats_;
   // Stores the Slices that designate the boundaries for each subcompaction
   std::vector<Slice> boundaries_;
   // Stores the approx size of keys covered in the range of each subcompaction
   std::vector<uint64_t> sizes_;
+  Env::WriteLifeTimeHint write_hint_;
   Env::Priority thread_pri_;
+  IOStatus io_status_;
   std::string full_history_ts_low_;
   BlobFileCompletionCallback* blob_callback_;
-
-  // Get table file name in where it's outputting to, which should also be in
-  // `output_directory_`.
-  virtual std::string GetTableFileName(uint64_t file_number);
-};
-
-// CompactionServiceInput is used the pass compaction information between two
-// db instances. It contains the information needed to do a compaction. It
-// doesn't contain the LSM tree information, which is passed though MANIFEST
-// file.
-struct CompactionServiceInput {
-  ColumnFamilyDescriptor column_family;
-
-  DBOptions db_options;
-
-  std::vector<SequenceNumber> snapshots;
-
-  // SST files for compaction, it should already be expended to include all the
-  // files needed for this compaction, for both input level files and output
-  // level files.
-  std::vector<std::string> input_files;
-  int output_level;
-
-  // information for subcompaction
-  Slice* begin = nullptr;
-  Slice* end = nullptr;
-  uint64_t approx_size = 0;
-};
-
-// CompactionServiceOutputFile is the metadata for the output SST file
-struct CompactionServiceOutputFile {
-  std::string file_name;
-  SequenceNumber smallest_seqno;
-  SequenceNumber largest_seqno;
-  std::string smallest_internal_key;
-  std::string largest_internal_key;
-  uint64_t oldest_ancester_time;
-  uint64_t file_creation_time;
-  uint64_t paranoid_hash;
-  bool marked_for_compaction;
-
-  CompactionServiceOutputFile() = default;
-  CompactionServiceOutputFile(
-      const std::string& name, SequenceNumber smallest, SequenceNumber largest,
-      std::string _smallest_internal_key, std::string _largest_internal_key,
-      uint64_t _oldest_ancester_time, uint64_t _file_creation_time,
-      uint64_t _paranoid_hash, bool _marked_for_compaction)
-      : file_name(name),
-        smallest_seqno(smallest),
-        largest_seqno(largest),
-        smallest_internal_key(std::move(_smallest_internal_key)),
-        largest_internal_key(std::move(_largest_internal_key)),
-        oldest_ancester_time(_oldest_ancester_time),
-        file_creation_time(_file_creation_time),
-        paranoid_hash(_paranoid_hash),
-        marked_for_compaction(_marked_for_compaction) {}
-};
-
-// CompactionServiceResult contains the compaction result from a different db
-// instance, with these information, the primary db instance with write
-// permission is able to install the result to the DB.
-struct CompactionServiceResult {
-  std::vector<CompactionServiceOutputFile> output_files;
-  int output_level;
-
-  // location of the output files
-  std::string output_path;
-
-  // some statistics about the compaction
-  uint64_t num_output_records;
-  uint64_t total_bytes;
-  uint64_t bytes_read;
-  uint64_t bytes_written;
-  CompactionJobStats stats;
-};
-
-// CompactionServiceCompactionJob is an read-only compaction job, it takes
-// input information from `compaction_service_input` and put result information
-// in `compaction_service_result`, the SST files are generated to `output_path`.
-class CompactionServiceCompactionJob : private CompactionJob {
- public:
-  CompactionServiceCompactionJob(
-      int job_id, Compaction* compaction, const ImmutableDBOptions& db_options,
-      const FileOptions& file_options, VersionSet* versions,
-      const std::atomic<bool>* shutting_down, LogBuffer* log_buffer,
-      FSDirectory* output_directory, Statistics* stats,
-      InstrumentedMutex* db_mutex, ErrorHandler* db_error_handler,
-      std::vector<SequenceNumber> existing_snapshots,
-      std::shared_ptr<Cache> table_cache, EventLogger* event_logger,
-      const std::string& dbname, const std::shared_ptr<IOTracer>& io_tracer,
-      const std::string& db_id, const std::string& db_session_id,
-      const std::string& output_path,
-      const CompactionServiceInput& compaction_service_input,
-      CompactionServiceResult* compaction_service_result);
-
-  // Run the compaction in current thread and return the result
-  Status Run();
-
-  void CleanupCompaction();
-
-  IOStatus io_status() const { return CompactionJob::io_status(); }
-
- private:
-  // Get table file name in output_path
-  std::string GetTableFileName(uint64_t file_number) override;
-  // Specific the compaction output path, otherwise it uses default DB path
-  const std::string output_path_;
-
-  // Compaction job input
-  const CompactionServiceInput& compaction_input_;
-
-  // Compaction job result
-  CompactionServiceResult* compaction_result_;
 };
 
 }  // namespace ROCKSDB_NAMESPACE

db/db_basic_test.cc

@@ -2820,7 +2820,6 @@ class DBBasicTestMultiGet : public DBTestBase {
 
     const char* Name() const override { return "MyBlockCache"; }
 
-    using Cache::Insert;
     Status Insert(const Slice& key, void* value, size_t charge,
                   void (*deleter)(const Slice& key, void* value),
                   Handle** handle = nullptr,
@@ -2829,7 +2828,6 @@ class DBBasicTestMultiGet : public DBTestBase {
       return target_->Insert(key, value, charge, deleter, handle, priority);
     }
 
-    using Cache::Lookup;
     Handle* Lookup(const Slice& key, Statistics* stats = nullptr) override {
       num_lookups_++;
       Handle* handle = target_->Lookup(key, stats);

db/db_block_cache_test.cc

@@ -446,7 +446,6 @@ class MockCache : public LRUCache {
                  false /*strict_capacity_limit*/, 0.0 /*high_pri_pool_ratio*/) {
   }
 
-  using ShardedCache::Insert;
   Status Insert(const Slice& key, void* value, size_t charge,
                 void (*deleter)(const Slice& key, void* value), Handle** handle,
                 Priority priority) override {
@@ -534,7 +533,6 @@ class LookupLiarCache : public CacheWrapper {
   explicit LookupLiarCache(std::shared_ptr<Cache> target)
       : CacheWrapper(std::move(target)) {}
 
-  using Cache::Lookup;
   Handle* Lookup(const Slice& key, Statistics* stats) override {
     if (nth_lookup_not_found_ == 1) {
       nth_lookup_not_found_ = 0;

db/db_filesnapshot.cc

@@ -98,7 +98,14 @@ Status DBImpl::GetLiveFiles(std::vector<std::string>& ret,
 
   ret.emplace_back(CurrentFileName(""));
   ret.emplace_back(DescriptorFileName("", versions_->manifest_file_number()));
-  ret.emplace_back(OptionsFileName("", versions_->options_file_number()));
+  // The OPTIONS file number is zero in read-write mode when OPTIONS file
+  // writing failed and the DB was configured with
+  // `fail_if_options_file_error == false`. In read-only mode the OPTIONS file
+  // number is zero when no OPTIONS file exist at all. In those cases we do not
+  // record any OPTIONS file in the live file list.
+  if (versions_->options_file_number() != 0) {
+    ret.emplace_back(OptionsFileName("", versions_->options_file_number()));
+  }
 
   // find length of manifest file while holding the mutex lock
   *manifest_file_size = versions_->manifest_file_size();

db/db_impl/db_impl.cc

@@ -160,17 +160,14 @@ DBImpl::DBImpl(const DBOptions& options, const std::string& dbname,
       mutex_(stats_, immutable_db_options_.clock, DB_MUTEX_WAIT_MICROS,
              immutable_db_options_.use_adaptive_mutex),
       default_cf_handle_(nullptr),
-      error_handler_(this, immutable_db_options_, &mutex_),
-      event_logger_(immutable_db_options_.info_log.get()),
       max_total_in_memory_state_(0),
       file_options_(BuildDBOptions(immutable_db_options_, mutable_db_options_)),
       file_options_for_compaction_(fs_->OptimizeForCompactionTableWrite(
           file_options_, immutable_db_options_)),
       seq_per_batch_(seq_per_batch),
       batch_per_txn_(batch_per_txn),
-      next_job_id_(1),
-      shutting_down_(false),
       db_lock_(nullptr),
+      shutting_down_(false),
       manual_compaction_paused_(false),
       bg_cv_(&mutex_),
       logfile_number_(0),
@@ -197,6 +194,7 @@ DBImpl::DBImpl(const DBOptions& options, const std::string& dbname,
       pending_purge_obsolete_files_(0),
       delete_obsolete_files_last_run_(immutable_db_options_.clock->NowMicros()),
       last_stats_dump_time_microsec_(0),
+      next_job_id_(1),
       has_unpersisted_data_(false),
       unable_to_release_oldest_log_(false),
       num_running_ingest_file_(0),
@@ -204,6 +202,7 @@ DBImpl::DBImpl(const DBOptions& options, const std::string& dbname,
       wal_manager_(immutable_db_options_, file_options_, io_tracer_,
                    seq_per_batch),
 #endif  // ROCKSDB_LITE
+      event_logger_(immutable_db_options_.info_log.get()),
       bg_work_paused_(0),
       bg_compaction_paused_(0),
       refitting_level_(false),
@@ -232,6 +231,7 @@ DBImpl::DBImpl(const DBOptions& options, const std::string& dbname,
       own_sfm_(options.sst_file_manager == nullptr),
       preserve_deletes_(options.preserve_deletes),
       closed_(false),
+      error_handler_(this, immutable_db_options_, &mutex_),
       atomic_flush_install_cv_(&mutex_),
       blob_callback_(immutable_db_options_.sst_file_manager.get(), &mutex_,
                      &error_handler_) {
@@ -270,10 +270,6 @@ DBImpl::DBImpl(const DBOptions& options, const std::string& dbname,
   // we won't drop any deletion markers until SetPreserveDeletesSequenceNumber()
   // is called by client and this seqnum is advanced.
   preserve_deletes_seqnum_.store(0);
-
-  if (write_buffer_manager_) {
-    wbm_stall_.reset(new WBMStallInterface());
-  }
 }
 
 Status DBImpl::Resume() {
@@ -664,10 +660,6 @@ Status DBImpl::CloseHelper() {
     }
   }
 
-  if (write_buffer_manager_ && wbm_stall_) {
-    write_buffer_manager_->RemoveDBFromQueue(wbm_stall_.get());
-  }
-
   if (ret.IsAborted()) {
     // Reserve IsAborted() error for those where users didn't release
     // certain resource and they can release them and come back and
@@ -697,8 +689,8 @@ void DBImpl::MaybeIgnoreError(Status* s) const {
 }
 
 const Status DBImpl::CreateArchivalDirectory() {
-  if (immutable_db_options_.WAL_ttl_seconds > 0 ||
-      immutable_db_options_.WAL_size_limit_MB > 0) {
+  if (immutable_db_options_.wal_ttl_seconds > 0 ||
+      immutable_db_options_.wal_size_limit_mb > 0) {
     std::string archivalPath = ArchivalDirectory(immutable_db_options_.wal_dir);
     return env_->CreateDirIfMissing(archivalPath);
   }

db/db_impl/db_impl.h

@@ -1048,56 +1048,6 @@ class DBImpl : public DB {
   // flush LOG out of application buffer
   void FlushInfoLog();
 
-  // Interface to block and signal the DB in case of stalling writes by
-  // WriteBufferManager. Each DBImpl object contains ptr to WBMStallInterface.
-  // When DB needs to be blocked or signalled by WriteBufferManager,
-  // state_ is changed accordingly.
-  class WBMStallInterface : public StallInterface {
-   public:
-    enum State {
-      BLOCKED = 0,
-      RUNNING,
-    };
-
-    WBMStallInterface() : state_cv_(&state_mutex_) {
-      MutexLock lock(&state_mutex_);
-      state_ = State::RUNNING;
-    }
-
-    void SetState(State state) {
-      MutexLock lock(&state_mutex_);
-      state_ = state;
-    }
-
-    // Change the state_ to State::BLOCKED and wait until its state is
-    // changed by WriteBufferManager. When stall is cleared, Signal() is
-    // called to change the state and unblock the DB.
-    void Block() override {
-      MutexLock lock(&state_mutex_);
-      while (state_ == State::BLOCKED) {
-        TEST_SYNC_POINT("WBMStallInterface::BlockDB");
-        state_cv_.Wait();
-      }
-    }
-
-    // Called from WriteBufferManager. This function changes the state_
-    // to State::RUNNING indicating the stall is cleared and DB can proceed.
-    void Signal() override {
-      MutexLock lock(&state_mutex_);
-      state_ = State::RUNNING;
-      state_cv_.Signal();
-    }
-
-   private:
-    // Conditional variable and mutex to block and
-    // signal the DB during stalling process.
-    port::Mutex state_mutex_;
-    port::CondVar state_cv_;
-    // state represting whether DB is running or blocked because of stall by
-    // WriteBufferManager.
-    State state_;
-  };
-
  protected:
   const std::string dbname_;
   std::string db_id_;
@@ -1130,14 +1080,6 @@ class DBImpl : public DB {
   ColumnFamilyHandleImpl* default_cf_handle_;
   InternalStats* default_cf_internal_stats_;
 
-  // table_cache_ provides its own synchronization
-  std::shared_ptr<Cache> table_cache_;
-
-  ErrorHandler error_handler_;
-
-  // Unified interface for logging events
-  EventLogger event_logger_;
-
   // only used for dynamically adjusting max_total_wal_size. it is a sum of
   // [write_buffer_size * max_write_buffer_number] over all column families
   uint64_t max_total_in_memory_state_;
@@ -1168,12 +1110,6 @@ class DBImpl : public DB {
   // Default: true
   const bool batch_per_txn_;
 
-  // Each flush or compaction gets its own job id. this counter makes sure
-  // they're unique
-  std::atomic<int> next_job_id_;
-
-  std::atomic<bool> shutting_down_;
-
   // Except in DB::Open(), WriteOptionsFile can only be called when:
   // Persist options to options file.
   // If need_mutex_lock = false, the method will lock DB mutex.
@@ -1590,10 +1526,6 @@ class DBImpl : public DB {
   //            `num_bytes` going through.
   Status DelayWrite(uint64_t num_bytes, const WriteOptions& write_options);
 
-  // Begin stalling of writes when memory usage increases beyond a certain
-  // threshold.
-  void WriteBufferManagerStallWrites();
-
   Status ThrottleLowPriWritesIfNeeded(const WriteOptions& write_options,
                                       WriteBatch* my_batch);
 
@@ -1954,6 +1886,9 @@ class DBImpl : public DB {
 
   Status IncreaseFullHistoryTsLow(ColumnFamilyData* cfd, std::string ts_low);
 
+  // table_cache_ provides its own synchronization
+  std::shared_ptr<Cache> table_cache_;
+
   // Lock over the persistent DB state.  Non-nullptr iff successfully acquired.
   FileLock* db_lock_;
 
@@ -1967,6 +1902,8 @@ class DBImpl : public DB {
   // mutex_, the order should be first mutex_ and then log_write_mutex_.
   InstrumentedMutex log_write_mutex_;
 
+  std::atomic<bool> shutting_down_;
+
   // If zero, manual compactions are allowed to proceed. If non-zero, manual
   // compactions may still be running, but will quickly fail with
   // `Status::Incomplete`. The value indicates how many threads have paused
@@ -2175,6 +2112,10 @@ class DBImpl : public DB {
   // Number of threads intending to write to memtable
   std::atomic<size_t> pending_memtable_writes_ = {};
 
+  // Each flush or compaction gets its own job id. this counter makes sure
+  // they're unique
+  std::atomic<int> next_job_id_;
+
   // A flag indicating whether the current rocksdb database has any
   // data that is not yet persisted into either WAL or SST file.
   // Used when disableWAL is true.
@@ -2203,6 +2144,9 @@ class DBImpl : public DB {
   WalManager wal_manager_;
 #endif  // ROCKSDB_LITE
 
+  // Unified interface for logging events
+  EventLogger event_logger_;
+
   // A value of > 0 temporarily disables scheduling of background work
   int bg_work_paused_;
 
@@ -2270,6 +2214,8 @@ class DBImpl : public DB {
   // Flag to check whether Close() has been called on this DB
   bool closed_;
 
+  ErrorHandler error_handler_;
+
   // Conditional variable to coordinate installation of atomic flush results.
   // With atomic flush, each bg thread installs the result of flushing multiple
   // column families, and different threads can flush different column
@@ -2284,9 +2230,6 @@ class DBImpl : public DB {
   bool wal_in_db_path_;
 
   BlobFileCompletionCallback blob_callback_;
-
-  // Pointer to WriteBufferManager stalling interface.
-  std::unique_ptr<StallInterface> wbm_stall_;
 };
 
 extern Options SanitizeOptions(const std::string& db, const Options& src,

db/db_impl/db_impl_compaction_flush.cc

@@ -803,10 +803,6 @@ Status DBImpl::CompactRange(const CompactRangeOptions& options,
                             ColumnFamilyHandle* column_family,
                             const Slice* begin_without_ts,
                             const Slice* end_without_ts) {
-  if (manual_compaction_paused_.load(std::memory_order_acquire) > 0) {
-    return Status::Incomplete(Status::SubCode::kManualCompactionPaused);
-  }
-
   const Comparator* const ucmp = column_family->GetComparator();
   assert(ucmp);
   size_t ts_sz = ucmp->timestamp_size();

db/db_impl/db_impl_files.cc

@@ -558,8 +558,8 @@ void DBImpl::PurgeObsoleteFiles(JobContext& state, bool schedule_only) {
     }
 
 #ifndef ROCKSDB_LITE
-    if (type == kWalFile && (immutable_db_options_.WAL_ttl_seconds > 0 ||
-                             immutable_db_options_.WAL_size_limit_MB > 0)) {
+    if (type == kWalFile && (immutable_db_options_.wal_ttl_seconds > 0 ||
+                             immutable_db_options_.wal_size_limit_mb > 0)) {
       wal_manager_.ArchiveWALFile(fname, number);
       continue;
     }

db/db_impl/db_impl_secondary.cc

@@ -17,10 +17,8 @@ namespace ROCKSDB_NAMESPACE {
 
 #ifndef ROCKSDB_LITE
 DBImplSecondary::DBImplSecondary(const DBOptions& db_options,
-                                 const std::string& dbname,
-                                 std::string secondary_path)
-    : DBImpl(db_options, dbname, false, true, true),
-      secondary_path_(std::move(secondary_path)) {
+                                 const std::string& dbname)
+    : DBImpl(db_options, dbname) {
   ROCKS_LOG_INFO(immutable_db_options_.info_log,
                  "Opening the db in secondary mode");
   LogFlush(immutable_db_options_.info_log);
@@ -619,7 +617,7 @@ Status DB::OpenAsSecondary(
   }
 
   handles->clear();
-  DBImplSecondary* impl = new DBImplSecondary(tmp_opts, dbname, secondary_path);
+  DBImplSecondary* impl = new DBImplSecondary(tmp_opts, dbname);
   impl->versions_.reset(new ReactiveVersionSet(
       dbname, &impl->immutable_db_options_, impl->file_options_,
       impl->table_cache_.get(), impl->write_buffer_manager_,
@@ -665,86 +663,6 @@ Status DB::OpenAsSecondary(
   }
   return s;
 }
-
-Status DBImplSecondary::CompactWithoutInstallation(
-    ColumnFamilyHandle* cfh, const CompactionServiceInput& input,
-    CompactionServiceResult* result) {
-  InstrumentedMutexLock l(&mutex_);
-  auto cfd = static_cast_with_check<ColumnFamilyHandleImpl>(cfh)->cfd();
-  if (!cfd) {
-    return Status::InvalidArgument("Cannot find column family" +
-                                   cfh->GetName());
-  }
-
-  std::unordered_set<uint64_t> input_set;
-  for (const auto& file_name : input.input_files) {
-    input_set.insert(TableFileNameToNumber(file_name));
-  }
-
-  auto* version = cfd->current();
-
-  ColumnFamilyMetaData cf_meta;
-  version->GetColumnFamilyMetaData(&cf_meta);
-
-  const MutableCFOptions* mutable_cf_options = cfd->GetLatestMutableCFOptions();
-  ColumnFamilyOptions cf_options = cfd->GetLatestCFOptions();
-  VersionStorageInfo* vstorage = version->storage_info();
-
-  // Use comp_options to reuse some CompactFiles functions
-  CompactionOptions comp_options;
-  comp_options.compression = kDisableCompressionOption;
-  comp_options.output_file_size_limit = MaxFileSizeForLevel(
-      *mutable_cf_options, input.output_level, cf_options.compaction_style,
-      vstorage->base_level(), cf_options.level_compaction_dynamic_level_bytes);
-
-  std::vector<CompactionInputFiles> input_files;
-  Status s = cfd->compaction_picker()->GetCompactionInputsFromFileNumbers(
-      &input_files, &input_set, vstorage, comp_options);
-  if (!s.ok()) {
-    return s;
-  }
-
-  std::unique_ptr<Compaction> c;
-  assert(cfd->compaction_picker());
-  c.reset(cfd->compaction_picker()->CompactFiles(
-      comp_options, input_files, input.output_level, vstorage,
-      *mutable_cf_options, mutable_db_options_, 0));
-  assert(c != nullptr);
-
-  c->SetInputVersion(version);
-
-  // Create output directory if it's not existed yet
-  std::unique_ptr<FSDirectory> output_dir;
-  s = CreateAndNewDirectory(fs_.get(), secondary_path_, &output_dir);
-  if (!s.ok()) {
-    return s;
-  }
-
-  LogBuffer log_buffer(InfoLogLevel::INFO_LEVEL,
-                       immutable_db_options_.info_log.get());
-
-  const int job_id = next_job_id_.fetch_add(1);
-
-  CompactionServiceCompactionJob compaction_job(
-      job_id, c.get(), immutable_db_options_, file_options_for_compaction_,
-      versions_.get(), &shutting_down_, &log_buffer, output_dir.get(), stats_,
-      &mutex_, &error_handler_, input.snapshots, table_cache_, &event_logger_,
-      dbname_, io_tracer_, db_id_, db_session_id_, secondary_path_, input,
-      result);
-
-  mutex_.Unlock();
-  s = compaction_job.Run();
-  mutex_.Lock();
-
-  // clean up
-  compaction_job.io_status().PermitUncheckedError();
-  compaction_job.CleanupCompaction();
-  c->ReleaseCompactionFiles(s);
-  c.reset();
-
-  return s;
-}
-
 #else   // !ROCKSDB_LITE
 
 Status DB::OpenAsSecondary(const Options& /*options*/,

db/db_impl/db_impl_secondary.h

@@ -71,8 +71,7 @@ class LogReaderContainer {
 // effort attempts to catch up with the primary.
 class DBImplSecondary : public DBImpl {
  public:
-  DBImplSecondary(const DBOptions& options, const std::string& dbname,
-                  std::string secondary_path);
+  DBImplSecondary(const DBOptions& options, const std::string& dbname);
   ~DBImplSecondary() override;
 
   // Recover by replaying MANIFEST and WAL. Also initialize manifest_reader_
@@ -223,14 +222,6 @@ class DBImplSecondary : public DBImpl {
   // not flag the missing file as inconsistency.
   Status CheckConsistency() override;
 
-#ifndef NDEBUG
-  Status TEST_CompactWithoutInstallation(ColumnFamilyHandle* cfh,
-                                         const CompactionServiceInput& input,
-                                         CompactionServiceResult* result) {
-    return CompactWithoutInstallation(cfh, input, result);
-  }
-#endif  // NDEBUG
-
  protected:
   // ColumnFamilyCollector is a write batch handler which does nothing
   // except recording unique column family IDs
@@ -325,13 +316,6 @@ class DBImplSecondary : public DBImpl {
                          std::unordered_set<ColumnFamilyData*>* cfds_changed,
                          JobContext* job_context);
 
-  // Run compaction without installation, the output files will be placed in the
-  // secondary DB path. The LSM tree won't be changed, the secondary DB is still
-  // in read-only mode.
-  Status CompactWithoutInstallation(ColumnFamilyHandle* cfh,
-                                    const CompactionServiceInput& input,
-                                    CompactionServiceResult* result);
-
   std::unique_ptr<log::FragmentBufferedReader> manifest_reader_;
   std::unique_ptr<log::Reader::Reporter> manifest_reporter_;
   std::unique_ptr<Status> manifest_reader_status_;
@@ -342,8 +326,6 @@ class DBImplSecondary : public DBImpl {
 
   // Current WAL number replayed for each column family.
   std::unordered_map<ColumnFamilyData*, uint64_t> cfd_to_current_log_;
-
-  const std::string secondary_path_;
 };
 
 }  // namespace ROCKSDB_NAMESPACE

db/db_impl/db_impl_write.cc

@@ -964,20 +964,6 @@ Status DBImpl::PreprocessWrite(const WriteOptions& write_options,
     PERF_TIMER_START(write_pre_and_post_process_time);
   }
 
-  // If memory usage exceeded beyond a certain threshold,
-  // write_buffer_manager_->ShouldStall() returns true to all threads writing to
-  // all DBs and writers will be stalled.
-  // It does soft checking because WriteBufferManager::buffer_limit_ has already
-  // exceeded at this point so no new write (including current one) will go
-  // through until memory usage is decreased.
-  if (UNLIKELY(status.ok() && write_buffer_manager_->ShouldStall())) {
-    if (write_options.no_slowdown) {
-      status = Status::Incomplete("Write stall");
-    } else {
-      WriteBufferManagerStallWrites();
-    }
-  }
-
   if (status.ok() && *need_log_sync) {
     // Wait until the parallel syncs are finished. Any sync process has to sync
     // the front log too so it is enough to check the status of front()
@@ -1550,29 +1536,6 @@ Status DBImpl::DelayWrite(uint64_t num_bytes,
   return s;
 }
 
-// REQUIRES: mutex_ is held
-// REQUIRES: this thread is currently at the front of the writer queue
-void DBImpl::WriteBufferManagerStallWrites() {
-  mutex_.AssertHeld();
-  // First block future writer threads who want to add themselves to the queue
-  // of WriteThread.
-  write_thread_.BeginWriteStall();
-  mutex_.Unlock();
-
-  // Change the state to State::Blocked.
-  static_cast<WBMStallInterface*>(wbm_stall_.get())
-      ->SetState(WBMStallInterface::State::BLOCKED);
-  // Then WriteBufferManager will add DB instance to its queue
-  // and block this thread by calling WBMStallInterface::Block().
-  write_buffer_manager_->BeginWriteStall(wbm_stall_.get());
-  wbm_stall_->Block();
-
-  mutex_.Lock();
-  // Stall has ended. Signal writer threads so that they can add
-  // themselves to the WriteThread queue for writes.
-  write_thread_.EndWriteStall();
-}
-
 Status DBImpl::ThrottleLowPriWritesIfNeeded(const WriteOptions& write_options,
                                             WriteBatch* my_batch) {
   assert(write_options.low_pri);

db/db_iter.cc

@@ -45,10 +45,10 @@ DBIter::DBIter(Env* _env, const ReadOptions& read_options,
                ColumnFamilyData* cfd, bool expose_blob_index)
     : prefix_extractor_(mutable_cf_options.prefix_extractor.get()),
       env_(_env),
-      clock_(cf_options.clock),
+      clock_(_env->GetSystemClock().get()),
       logger_(cf_options.info_log),
       user_comparator_(cmp),
-      merge_operator_(cf_options.merge_operator.get()),
+      merge_operator_(cf_options.merge_operator),
       iter_(iter),
       version_(version),
       read_callback_(read_callback),

db/db_secondary_test.cc

@@ -147,206 +147,6 @@ TEST_F(DBSecondaryTest, ReopenAsSecondary) {
   ASSERT_EQ(2, count);
 }
 
-TEST_F(DBSecondaryTest, SimpleInternalCompaction) {
-  Options options;
-  options.env = env_;
-  Reopen(options);
-  for (int i = 0; i < 3; ++i) {
-    ASSERT_OK(Put("foo", "foo_value" + std::to_string(i)));
-    ASSERT_OK(Put("bar", "bar_value" + std::to_string(i)));
-    ASSERT_OK(Flush());
-  }
-  CompactionServiceInput input;
-
-  ColumnFamilyMetaData meta;
-  db_->GetColumnFamilyMetaData(&meta);
-  for (auto& file : meta.levels[0].files) {
-    ASSERT_EQ(0, meta.levels[0].level);
-    input.input_files.push_back(file.name);
-  }
-  ASSERT_EQ(input.input_files.size(), 3);
-
-  input.output_level = 1;
-  Close();
-
-  options.max_open_files = -1;
-  OpenSecondary(options);
-  auto cfh = db_secondary_->DefaultColumnFamily();
-
-  CompactionServiceResult result;
-  ASSERT_OK(db_secondary_full()->TEST_CompactWithoutInstallation(cfh, input,
-                                                                 &result));
-
-  ASSERT_EQ(result.output_files.size(), 1);
-  InternalKey smallest, largest;
-  smallest.DecodeFrom(result.output_files[0].smallest_internal_key);
-  largest.DecodeFrom(result.output_files[0].largest_internal_key);
-  ASSERT_EQ(smallest.user_key().ToString(), "bar");
-  ASSERT_EQ(largest.user_key().ToString(), "foo");
-  ASSERT_EQ(result.output_level, 1);
-  ASSERT_EQ(result.output_path, this->secondary_path_);
-  ASSERT_EQ(result.num_output_records, 2);
-  ASSERT_GT(result.bytes_written, 0);
-}
-
-TEST_F(DBSecondaryTest, InternalCompactionMultiLevels) {
-  Options options;
-  options.env = env_;
-  options.disable_auto_compactions = true;
-  Reopen(options);
-  const int kRangeL2 = 10;
-  const int kRangeL1 = 30;
-  for (int i = 0; i < 10; i++) {
-    ASSERT_OK(Put(Key(i * kRangeL2), "value" + ToString(i)));
-    ASSERT_OK(Put(Key((i + 1) * kRangeL2 - 1), "value" + ToString(i)));
-    ASSERT_OK(Flush());
-  }
-  MoveFilesToLevel(2);
-  for (int i = 0; i < 5; i++) {
-    ASSERT_OK(Put(Key(i * kRangeL1), "value" + ToString(i)));
-    ASSERT_OK(Put(Key((i + 1) * kRangeL1 - 1), "value" + ToString(i)));
-    ASSERT_OK(Flush());
-  }
-  MoveFilesToLevel(1);
-  for (int i = 0; i < 4; i++) {
-    ASSERT_OK(Put(Key(i * 30), "value" + ToString(i)));
-    ASSERT_OK(Put(Key(i * 30 + 50), "value" + ToString(i)));
-    ASSERT_OK(Flush());
-  }
-
-  ColumnFamilyMetaData meta;
-  db_->GetColumnFamilyMetaData(&meta);
-
-  // pick 2 files on level 0 for compaction, which has 3 overlap files on L1
-  CompactionServiceInput input1;
-  input1.input_files.push_back(meta.levels[0].files[2].name);
-  input1.input_files.push_back(meta.levels[0].files[3].name);
-  input1.input_files.push_back(meta.levels[1].files[0].name);
-  input1.input_files.push_back(meta.levels[1].files[1].name);
-  input1.input_files.push_back(meta.levels[1].files[2].name);
-
-  input1.output_level = 1;
-
-  options.max_open_files = -1;
-  Close();
-
-  OpenSecondary(options);
-  auto cfh = db_secondary_->DefaultColumnFamily();
-  CompactionServiceResult result;
-  ASSERT_OK(db_secondary_full()->TEST_CompactWithoutInstallation(cfh, input1,
-                                                                 &result));
-
-  // pick 2 files on level 1 for compaction, which has 6 overlap files on L2
-  CompactionServiceInput input2;
-  input2.input_files.push_back(meta.levels[1].files[1].name);
-  input2.input_files.push_back(meta.levels[1].files[2].name);
-  for (int i = 3; i < 9; i++) {
-    input2.input_files.push_back(meta.levels[2].files[i].name);
-  }
-
-  input2.output_level = 2;
-  ASSERT_OK(db_secondary_full()->TEST_CompactWithoutInstallation(cfh, input2,
-                                                                 &result));
-
-  CloseSecondary();
-
-  // delete all l2 files, without update manifest
-  for (auto& file : meta.levels[2].files) {
-    ASSERT_OK(env_->DeleteFile(dbname_ + file.name));
-  }
-  OpenSecondary(options);
-  cfh = db_secondary_->DefaultColumnFamily();
-  Status s = db_secondary_full()->TEST_CompactWithoutInstallation(cfh, input2,
-                                                                  &result);
-  ASSERT_TRUE(s.IsInvalidArgument());
-
-  // TODO: L0 -> L1 compaction should success, currently version is not built
-  // if files is missing.
-  //  ASSERT_OK(db_secondary_full()->TEST_CompactWithoutInstallation(cfh,
-  //  input1, &result));
-}
-
-TEST_F(DBSecondaryTest, InternalCompactionCompactedFiles) {
-  Options options;
-  options.env = env_;
-  options.level0_file_num_compaction_trigger = 4;
-  Reopen(options);
-  for (int i = 0; i < 3; ++i) {
-    ASSERT_OK(Put("foo", "foo_value" + std::to_string(i)));
-    ASSERT_OK(Put("bar", "bar_value" + std::to_string(i)));
-    ASSERT_OK(Flush());
-  }
-  CompactionServiceInput input;
-
-  ColumnFamilyMetaData meta;
-  db_->GetColumnFamilyMetaData(&meta);
-  for (auto& file : meta.levels[0].files) {
-    ASSERT_EQ(0, meta.levels[0].level);
-    input.input_files.push_back(file.name);
-  }
-  ASSERT_EQ(input.input_files.size(), 3);
-
-  input.output_level = 1;
-
-  // trigger compaction to delete the files for secondary instance compaction
-  ASSERT_OK(Put("foo", "foo_value" + std::to_string(3)));
-  ASSERT_OK(Put("bar", "bar_value" + std::to_string(3)));
-  ASSERT_OK(Flush());
-  ASSERT_OK(dbfull()->TEST_WaitForCompact());
-
-  Close();
-
-  options.max_open_files = -1;
-  OpenSecondary(options);
-  auto cfh = db_secondary_->DefaultColumnFamily();
-
-  CompactionServiceResult result;
-  Status s =
-      db_secondary_full()->TEST_CompactWithoutInstallation(cfh, input, &result);
-  ASSERT_TRUE(s.IsInvalidArgument());
-}
-
-TEST_F(DBSecondaryTest, InternalCompactionMissingFiles) {
-  Options options;
-  options.env = env_;
-  options.level0_file_num_compaction_trigger = 4;
-  Reopen(options);
-  for (int i = 0; i < 3; ++i) {
-    ASSERT_OK(Put("foo", "foo_value" + std::to_string(i)));
-    ASSERT_OK(Put("bar", "bar_value" + std::to_string(i)));
-    ASSERT_OK(Flush());
-  }
-  CompactionServiceInput input;
-
-  ColumnFamilyMetaData meta;
-  db_->GetColumnFamilyMetaData(&meta);
-  for (auto& file : meta.levels[0].files) {
-    ASSERT_EQ(0, meta.levels[0].level);
-    input.input_files.push_back(file.name);
-  }
-  ASSERT_EQ(input.input_files.size(), 3);
-
-  input.output_level = 1;
-
-  Close();
-
-  ASSERT_OK(env_->DeleteFile(dbname_ + input.input_files[0]));
-
-  options.max_open_files = -1;
-  OpenSecondary(options);
-  auto cfh = db_secondary_->DefaultColumnFamily();
-
-  CompactionServiceResult result;
-  Status s =
-      db_secondary_full()->TEST_CompactWithoutInstallation(cfh, input, &result);
-  ASSERT_TRUE(s.IsInvalidArgument());
-
-  input.input_files.erase(input.input_files.begin());
-
-  ASSERT_OK(db_secondary_full()->TEST_CompactWithoutInstallation(cfh, input,
-                                                                 &result));
-}
-
 TEST_F(DBSecondaryTest, OpenAsSecondary) {
   Options options;
   options.env = env_;

db/db_test_util.h

@@ -378,20 +378,14 @@ class SpecialEnv : public EnvWrapper {
         return Append(data);
       }
       Status Truncate(uint64_t size) override { return base_->Truncate(size); }
-      void PrepareWrite(size_t offset, size_t len) override {
-        base_->PrepareWrite(offset, len);
-      }
-      void SetPreallocationBlockSize(size_t size) override {
-        base_->SetPreallocationBlockSize(size);
-      }
       Status Close() override {
 // SyncPoint is not supported in Released Windows Mode.
 #if !(defined NDEBUG) || !defined(OS_WIN)
         // Check preallocation size
-        size_t block_size, last_allocated_block;
-        base_->GetPreallocationStatus(&block_size, &last_allocated_block);
+        // preallocation size is never passed to base file.
+        size_t preallocation_size = preallocation_block_size();
         TEST_SYNC_POINT_CALLBACK("DBTestWalFile.GetPreallocationStatus",
-                                 &block_size);
+                                 &preallocation_size);
 #endif  // !(defined NDEBUG) || !defined(OS_WIN)
 
         return base_->Close();
@@ -826,7 +820,6 @@ class CacheWrapper : public Cache {
 
   const char* Name() const override { return target_->Name(); }
 
-  using Cache::Insert;
   Status Insert(const Slice& key, void* value, size_t charge,
                 void (*deleter)(const Slice& key, void* value),
                 Handle** handle = nullptr,
@@ -834,14 +827,12 @@ class CacheWrapper : public Cache {
     return target_->Insert(key, value, charge, deleter, handle, priority);
   }
 
-  using Cache::Lookup;
   Handle* Lookup(const Slice& key, Statistics* stats = nullptr) override {
     return target_->Lookup(key, stats);
   }
 
   bool Ref(Handle* handle) override { return target_->Ref(handle); }
 
-  using Cache::Release;
   bool Release(Handle* handle, bool force_erase = false) override {
     return target_->Release(handle, force_erase);
   }

db/db_write_buffer_manager_test.cc

@@ -1,801 +0,0 @@
-//  Copyright (c) 2011-present, Facebook, Inc.  All rights reserved.
-//  This source code is licensed under both the GPLv2 (found in the
-//  COPYING file in the root directory) and Apache 2.0 License
-//  (found in the LICENSE.Apache file in the root directory).
-//
-// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file. See the AUTHORS file for names of contributors.
-
-#include "db/db_test_util.h"
-#include "db/write_thread.h"
-#include "port/stack_trace.h"
-
-namespace ROCKSDB_NAMESPACE {
-
-class DBWriteBufferManagerTest : public DBTestBase,
-                                 public testing::WithParamInterface<bool> {
- public:
-  DBWriteBufferManagerTest()
-      : DBTestBase("/db_write_buffer_manager_test", /*env_do_fsync=*/false) {}
-  bool cost_cache_;
-};
-
-TEST_P(DBWriteBufferManagerTest, SharedBufferAcrossCFs1) {
-  Options options = CurrentOptions();
-  options.arena_block_size = 4096;
-  options.write_buffer_size = 500000;  // this is never hit
-  std::shared_ptr<Cache> cache = NewLRUCache(4 * 1024 * 1024, 2);
-  ASSERT_LT(cache->GetUsage(), 256 * 1024);
-  cost_cache_ = GetParam();
-
-  if (cost_cache_) {
-    options.write_buffer_manager.reset(
-        new WriteBufferManager(100000, cache, true));
-  } else {
-    options.write_buffer_manager.reset(
-        new WriteBufferManager(100000, nullptr, true));
-  }
-
-  WriteOptions wo;
-  wo.disableWAL = true;
-
-  CreateAndReopenWithCF({"cf1", "cf2", "cf3"}, options);
-  ASSERT_OK(Put(3, Key(1), DummyString(1), wo));
-  Flush(3);
-  ASSERT_OK(Put(3, Key(1), DummyString(1), wo));
-  ASSERT_OK(Put(0, Key(1), DummyString(1), wo));
-  Flush(0);
-
-  // Write to "Default", "cf2" and "cf3".
-  ASSERT_OK(Put(3, Key(1), DummyString(30000), wo));
-  ASSERT_OK(Put(0, Key(1), DummyString(40000), wo));
-  ASSERT_OK(Put(2, Key(1), DummyString(1), wo));
-
-  ASSERT_OK(Put(3, Key(2), DummyString(40000), wo));
-  // WriteBufferManager::buffer_size_ has exceeded after the previous write is
-  // completed.
-
-  // This make sures write will go through and if stall was in effect, it will
-  // end.
-  ASSERT_OK(Put(0, Key(2), DummyString(1), wo));
-}
-
-// Test Single DB with multiple writer threads get blocked when
-// WriteBufferManager execeeds buffer_size_ and flush is waiting to be
-// finished.
-TEST_P(DBWriteBufferManagerTest, SharedWriteBufferAcrossCFs2) {
-  Options options = CurrentOptions();
-  options.arena_block_size = 4096;
-  options.write_buffer_size = 500000;  // this is never hit
-  std::shared_ptr<Cache> cache = NewLRUCache(4 * 1024 * 1024, 2);
-  ASSERT_LT(cache->GetUsage(), 256 * 1024);
-  cost_cache_ = GetParam();
-
-  if (cost_cache_) {
-    options.write_buffer_manager.reset(
-        new WriteBufferManager(100000, cache, true));
-  } else {
-    options.write_buffer_manager.reset(
-        new WriteBufferManager(100000, nullptr, true));
-  }
-  WriteOptions wo;
-  wo.disableWAL = true;
-
-  CreateAndReopenWithCF({"cf1", "cf2", "cf3"}, options);
-  ASSERT_OK(Put(3, Key(1), DummyString(1), wo));
-  Flush(3);
-  ASSERT_OK(Put(3, Key(1), DummyString(1), wo));
-  ASSERT_OK(Put(0, Key(1), DummyString(1), wo));
-  Flush(0);
-
-  // Write to "Default", "cf2" and "cf3". No flush will be triggered.
-  ASSERT_OK(Put(3, Key(1), DummyString(30000), wo));
-  ASSERT_OK(Put(0, Key(1), DummyString(40000), wo));
-  ASSERT_OK(Put(2, Key(1), DummyString(1), wo));
-
-  ASSERT_OK(Put(3, Key(2), DummyString(40000), wo));
-  // WriteBufferManager::buffer_size_ has exceeded after the previous write is
-  // completed.
-
-  std::unordered_set<WriteThread::Writer*> w_set;
-  std::vector<port::Thread> threads;
-  int wait_count_db = 0;
-  int num_writers = 4;
-  InstrumentedMutex mutex;
-  InstrumentedCondVar cv(&mutex);
-  std::atomic<int> thread_num(0);
-
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency(
-      {{"DBWriteBufferManagerTest::SharedWriteBufferAcrossCFs:0",
-        "DBImpl::BackgroundCallFlush:start"}});
-
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
-      "WBMStallInterface::BlockDB", [&](void*) {
-        InstrumentedMutexLock lock(&mutex);
-        wait_count_db++;
-        cv.SignalAll();
-      });
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
-      "WriteThread::WriteStall::Wait", [&](void* arg) {
-        InstrumentedMutexLock lock(&mutex);
-        WriteThread::Writer* w = reinterpret_cast<WriteThread::Writer*>(arg);
-        w_set.insert(w);
-        // Allow the flush to continue if all writer threads are blocked.
-        if (w_set.size() == (unsigned long)num_writers) {
-          TEST_SYNC_POINT(
-              "DBWriteBufferManagerTest::SharedWriteBufferAcrossCFs:0");
-        }
-      });
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
-
-  bool s = true;
-
-  std::function<void(int)> writer = [&](int cf) {
-    int a = thread_num.fetch_add(1);
-    std::string key = "foo" + std::to_string(a);
-    Status tmp = Put(cf, Slice(key), DummyString(1), wo);
-    InstrumentedMutexLock lock(&mutex);
-    s = s && tmp.ok();
-  };
-
-  // Flow:
-  // main_writer thread will write but will be blocked (as Flush will on hold,
-  // buffer_size_ has exceeded, thus will create stall in effect).
-  //  |
-  //  |
-  //  multiple writer threads will be created to write across multiple columns
-  //  and they will be blocked.
-  //  |
-  //  |
-  //  Last writer thread will write and when its blocked it will signal Flush to
-  //  continue to clear the stall.
-
-  threads.emplace_back(writer, 1);
-  // Wait untill first thread (main_writer) writing to DB is blocked and then
-  // create the multiple writers which will be blocked from getting added to the
-  // queue because stall is in effect.
-  {
-    InstrumentedMutexLock lock(&mutex);
-    while (wait_count_db != 1) {
-      cv.Wait();
-    }
-  }
-  for (int i = 0; i < num_writers; i++) {
-    threads.emplace_back(writer, i % 4);
-  }
-  for (auto& t : threads) {
-    t.join();
-  }
-
-  ASSERT_TRUE(s);
-
-  // Number of DBs blocked.
-  ASSERT_EQ(wait_count_db, 1);
-  // Number of Writer threads blocked.
-  ASSERT_EQ(w_set.size(), num_writers);
-
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks();
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
-}
-
-// Test multiple DBs get blocked when WriteBufferManager limit exceeds and flush
-// is waiting to be finished but DBs tries to write meanwhile.
-TEST_P(DBWriteBufferManagerTest, SharedWriteBufferLimitAcrossDB) {
-  std::vector<std::string> dbnames;
-  std::vector<DB*> dbs;
-  int num_dbs = 3;
-
-  for (int i = 0; i < num_dbs; i++) {
-    dbs.push_back(nullptr);
-    dbnames.push_back(
-        test::PerThreadDBPath("db_shared_wb_db" + std::to_string(i)));
-  }
-
-  Options options = CurrentOptions();
-  options.arena_block_size = 4096;
-  options.write_buffer_size = 500000;  // this is never hit
-  std::shared_ptr<Cache> cache = NewLRUCache(4 * 1024 * 1024, 2);
-  ASSERT_LT(cache->GetUsage(), 256 * 1024);
-  cost_cache_ = GetParam();
-
-  if (cost_cache_) {
-    options.write_buffer_manager.reset(
-        new WriteBufferManager(100000, cache, true));
-  } else {
-    options.write_buffer_manager.reset(
-        new WriteBufferManager(100000, nullptr, true));
-  }
-  CreateAndReopenWithCF({"cf1", "cf2"}, options);
-
-  for (int i = 0; i < num_dbs; i++) {
-    ASSERT_OK(DestroyDB(dbnames[i], options));
-    ASSERT_OK(DB::Open(options, dbnames[i], &(dbs[i])));
-  }
-  WriteOptions wo;
-  wo.disableWAL = true;
-
-  for (int i = 0; i < num_dbs; i++) {
-    ASSERT_OK(dbs[i]->Put(wo, Key(1), DummyString(20000)));
-  }
-  // Insert to db_.
-  ASSERT_OK(Put(0, Key(1), DummyString(30000), wo));
-
-  // WriteBufferManager Limit exceeded.
-  std::vector<port::Thread> threads;
-  int wait_count_db = 0;
-  InstrumentedMutex mutex;
-  InstrumentedCondVar cv(&mutex);
-
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency(
-      {{"DBWriteBufferManagerTest::SharedWriteBufferAcrossCFs:0",
-        "DBImpl::BackgroundCallFlush:start"}});
-
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
-      "WBMStallInterface::BlockDB", [&](void*) {
-        {
-          InstrumentedMutexLock lock(&mutex);
-          wait_count_db++;
-          cv.Signal();
-          // Since this is the last DB, signal Flush to continue.
-          if (wait_count_db == num_dbs + 1) {
-            TEST_SYNC_POINT(
-                "DBWriteBufferManagerTest::SharedWriteBufferAcrossCFs:0");
-          }
-        }
-      });
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
-
-  bool s = true;
-
-  // Write to DB.
-  std::function<void(DB*)> write_db = [&](DB* db) {
-    Status tmp = db->Put(wo, Key(3), DummyString(1));
-    InstrumentedMutexLock lock(&mutex);
-    s = s && tmp.ok();
-  };
-
-  // Flow:
-  // db_ will write and will be blocked (as Flush will on hold and will create
-  // stall in effect).
-  //  |
-  //  multiple dbs writers will be created to write to that db and they will be
-  //  blocked.
-  //  |
-  //  |
-  //  Last writer will write and when its blocked it will signal Flush to
-  //  continue to clear the stall.
-
-  threads.emplace_back(write_db, db_);
-  // Wait untill first DB is blocked and then create the multiple writers for
-  // different DBs which will be blocked from getting added to the queue because
-  // stall is in effect.
-  {
-    InstrumentedMutexLock lock(&mutex);
-    while (wait_count_db != 1) {
-      cv.Wait();
-    }
-  }
-  for (int i = 0; i < num_dbs; i++) {
-    threads.emplace_back(write_db, dbs[i]);
-  }
-  for (auto& t : threads) {
-    t.join();
-  }
-
-  ASSERT_TRUE(s);
-  ASSERT_EQ(num_dbs + 1, wait_count_db);
-  // Clean up DBs.
-  for (int i = 0; i < num_dbs; i++) {
-    ASSERT_OK(dbs[i]->Close());
-    ASSERT_OK(DestroyDB(dbnames[i], options));
-    delete dbs[i];
-  }
-
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks();
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
-}
-
-// Test multiple threads writing across multiple DBs and multiple columns get
-// blocked when stall by WriteBufferManager is in effect.
-TEST_P(DBWriteBufferManagerTest, SharedWriteBufferLimitAcrossDB1) {
-  std::vector<std::string> dbnames;
-  std::vector<DB*> dbs;
-  int num_dbs = 3;
-
-  for (int i = 0; i < num_dbs; i++) {
-    dbs.push_back(nullptr);
-    dbnames.push_back(
-        test::PerThreadDBPath("db_shared_wb_db" + std::to_string(i)));
-  }
-
-  Options options = CurrentOptions();
-  options.arena_block_size = 4096;
-  options.write_buffer_size = 500000;  // this is never hit
-  std::shared_ptr<Cache> cache = NewLRUCache(4 * 1024 * 1024, 2);
-  ASSERT_LT(cache->GetUsage(), 256 * 1024);
-  cost_cache_ = GetParam();
-
-  if (cost_cache_) {
-    options.write_buffer_manager.reset(
-        new WriteBufferManager(100000, cache, true));
-  } else {
-    options.write_buffer_manager.reset(
-        new WriteBufferManager(100000, nullptr, true));
-  }
-  CreateAndReopenWithCF({"cf1", "cf2"}, options);
-
-  for (int i = 0; i < num_dbs; i++) {
-    ASSERT_OK(DestroyDB(dbnames[i], options));
-    ASSERT_OK(DB::Open(options, dbnames[i], &(dbs[i])));
-  }
-  WriteOptions wo;
-  wo.disableWAL = true;
-
-  for (int i = 0; i < num_dbs; i++) {
-    ASSERT_OK(dbs[i]->Put(wo, Key(1), DummyString(20000)));
-  }
-  // Insert to db_.
-  ASSERT_OK(Put(0, Key(1), DummyString(30000), wo));
-
-  // WriteBufferManager::buffer_size_ has exceeded after the previous write to
-  // dbs[0] is completed.
-  std::vector<port::Thread> threads;
-  int wait_count_db = 0;
-  InstrumentedMutex mutex;
-  InstrumentedCondVar cv(&mutex);
-  std::unordered_set<WriteThread::Writer*> w_set;
-  std::vector<port::Thread> writer_threads;
-  std::atomic<int> thread_num(0);
-
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency(
-      {{"DBWriteBufferManagerTest::SharedWriteBufferAcrossCFs:0",
-        "DBImpl::BackgroundCallFlush:start"}});
-
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
-      "WBMStallInterface::BlockDB", [&](void*) {
-        {
-          InstrumentedMutexLock lock(&mutex);
-          wait_count_db++;
-          thread_num.fetch_add(1);
-          cv.Signal();
-          // Allow the flush to continue if all writer threads are blocked.
-          if (thread_num.load(std::memory_order_relaxed) == 2 * num_dbs + 1) {
-            TEST_SYNC_POINT(
-                "DBWriteBufferManagerTest::SharedWriteBufferAcrossCFs:0");
-          }
-        }
-      });
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
-      "WriteThread::WriteStall::Wait", [&](void* arg) {
-        WriteThread::Writer* w = reinterpret_cast<WriteThread::Writer*>(arg);
-        {
-          InstrumentedMutexLock lock(&mutex);
-          w_set.insert(w);
-          thread_num.fetch_add(1);
-          // Allow the flush continue if all writer threads are blocked.
-          if (thread_num.load(std::memory_order_relaxed) == 2 * num_dbs + 1) {
-            TEST_SYNC_POINT(
-                "DBWriteBufferManagerTest::SharedWriteBufferAcrossCFs:0");
-          }
-        }
-      });
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
-
-  bool s1 = true, s2 = true;
-  // Write to multiple columns of db_.
-  std::function<void(int)> write_cf = [&](int cf) {
-    Status tmp = Put(cf, Key(3), DummyString(1), wo);
-    InstrumentedMutexLock lock(&mutex);
-    s1 = s1 && tmp.ok();
-  };
-  // Write to multiple DBs.
-  std::function<void(DB*)> write_db = [&](DB* db) {
-    Status tmp = db->Put(wo, Key(3), DummyString(1));
-    InstrumentedMutexLock lock(&mutex);
-    s2 = s2 && tmp.ok();
-  };
-
-  // Flow:
-  // thread will write to db_ will be blocked (as Flush will on hold,
-  // buffer_size_ has exceeded and will create stall in effect).
-  //  |
-  //  |
-  //  multiple writers threads writing to different DBs and to db_ across
-  //  multiple columns will be created and they will be blocked due to stall.
-  //  |
-  //  |
-  //  Last writer thread will write and when its blocked it will signal Flush to
-  //  continue to clear the stall.
-  threads.emplace_back(write_db, db_);
-  // Wait untill first thread is blocked and then create the multiple writer
-  // threads.
-  {
-    InstrumentedMutexLock lock(&mutex);
-    while (wait_count_db != 1) {
-      cv.Wait();
-    }
-  }
-
-  for (int i = 0; i < num_dbs; i++) {
-    // Write to multiple columns of db_.
-    writer_threads.emplace_back(write_cf, i % 3);
-    // Write to different dbs.
-    threads.emplace_back(write_db, dbs[i]);
-  }
-  for (auto& t : threads) {
-    t.join();
-  }
-  for (auto& t : writer_threads) {
-    t.join();
-  }
-
-  ASSERT_TRUE(s1);
-  ASSERT_TRUE(s2);
-
-  // Number of DBs blocked.
-  ASSERT_EQ(num_dbs + 1, wait_count_db);
-  // Number of Writer threads blocked.
-  ASSERT_EQ(w_set.size(), num_dbs);
-  // Clean up DBs.
-  for (int i = 0; i < num_dbs; i++) {
-    ASSERT_OK(dbs[i]->Close());
-    ASSERT_OK(DestroyDB(dbnames[i], options));
-    delete dbs[i];
-  }
-
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks();
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
-}
-
-// Test multiple threads writing across multiple columns of db_ by passing
-// different values to WriteOption.no_slown_down.
-TEST_P(DBWriteBufferManagerTest, MixedSlowDownOptionsSingleDB) {
-  Options options = CurrentOptions();
-  options.arena_block_size = 4096;
-  options.write_buffer_size = 500000;  // this is never hit
-  std::shared_ptr<Cache> cache = NewLRUCache(4 * 1024 * 1024, 2);
-  ASSERT_LT(cache->GetUsage(), 256 * 1024);
-  cost_cache_ = GetParam();
-
-  if (cost_cache_) {
-    options.write_buffer_manager.reset(
-        new WriteBufferManager(100000, cache, true));
-  } else {
-    options.write_buffer_manager.reset(
-        new WriteBufferManager(100000, nullptr, true));
-  }
-  WriteOptions wo;
-  wo.disableWAL = true;
-
-  CreateAndReopenWithCF({"cf1", "cf2", "cf3"}, options);
-
-  ASSERT_OK(Put(3, Key(1), DummyString(1), wo));
-  Flush(3);
-  ASSERT_OK(Put(3, Key(1), DummyString(1), wo));
-  ASSERT_OK(Put(0, Key(1), DummyString(1), wo));
-  Flush(0);
-
-  // Write to "Default", "cf2" and "cf3". No flush will be triggered.
-  ASSERT_OK(Put(3, Key(1), DummyString(30000), wo));
-  ASSERT_OK(Put(0, Key(1), DummyString(40000), wo));
-  ASSERT_OK(Put(2, Key(1), DummyString(1), wo));
-  ASSERT_OK(Put(3, Key(2), DummyString(40000), wo));
-
-  // WriteBufferManager::buffer_size_ has exceeded after the previous write to
-  // db_ is completed.
-
-  std::unordered_set<WriteThread::Writer*> w_slowdown_set;
-  std::vector<port::Thread> threads;
-  int wait_count_db = 0;
-  int num_writers = 4;
-  InstrumentedMutex mutex;
-  InstrumentedCondVar cv(&mutex);
-  std::atomic<int> thread_num(0);
-  std::atomic<int> w_no_slowdown(0);
-
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency(
-      {{"DBWriteBufferManagerTest::SharedWriteBufferAcrossCFs:0",
-        "DBImpl::BackgroundCallFlush:start"}});
-
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
-      "WBMStallInterface::BlockDB", [&](void*) {
-        {
-          InstrumentedMutexLock lock(&mutex);
-          wait_count_db++;
-          cv.SignalAll();
-        }
-      });
-
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
-      "WriteThread::WriteStall::Wait", [&](void* arg) {
-        {
-          InstrumentedMutexLock lock(&mutex);
-          WriteThread::Writer* w = reinterpret_cast<WriteThread::Writer*>(arg);
-          w_slowdown_set.insert(w);
-          // Allow the flush continue if all writer threads are blocked.
-          if (w_slowdown_set.size() + (unsigned long)w_no_slowdown.load(
-                                          std::memory_order_relaxed) ==
-              (unsigned long)num_writers) {
-            TEST_SYNC_POINT(
-                "DBWriteBufferManagerTest::SharedWriteBufferAcrossCFs:0");
-          }
-        }
-      });
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
-
-  bool s1 = true, s2 = true;
-
-  std::function<void(int)> write_slow_down = [&](int cf) {
-    int a = thread_num.fetch_add(1);
-    std::string key = "foo" + std::to_string(a);
-    WriteOptions write_op;
-    write_op.no_slowdown = false;
-    Status tmp = Put(cf, Slice(key), DummyString(1), write_op);
-    InstrumentedMutexLock lock(&mutex);
-    s1 = s1 && tmp.ok();
-  };
-
-  std::function<void(int)> write_no_slow_down = [&](int cf) {
-    int a = thread_num.fetch_add(1);
-    std::string key = "foo" + std::to_string(a);
-    WriteOptions write_op;
-    write_op.no_slowdown = true;
-    Status tmp = Put(cf, Slice(key), DummyString(1), write_op);
-    {
-      InstrumentedMutexLock lock(&mutex);
-      s2 = s2 && !tmp.ok();
-      w_no_slowdown.fetch_add(1);
-      // Allow the flush continue if all writer threads are blocked.
-      if (w_slowdown_set.size() +
-              (unsigned long)w_no_slowdown.load(std::memory_order_relaxed) ==
-          (unsigned long)num_writers) {
-        TEST_SYNC_POINT(
-            "DBWriteBufferManagerTest::SharedWriteBufferAcrossCFs:0");
-      }
-    }
-  };
-
-  // Flow:
-  // main_writer thread will write but will be blocked (as Flush will on hold,
-  // buffer_size_ has exceeded, thus will create stall in effect).
-  //  |
-  //  |
-  //  multiple writer threads will be created to write across multiple columns
-  //  with different values of WriteOptions.no_slowdown. Some of them will
-  //  be blocked and some of them will return with Incomplete status.
-  //  |
-  //  |
-  //  Last writer thread will write and when its blocked/return it will signal
-  //  Flush to continue to clear the stall.
-  threads.emplace_back(write_slow_down, 1);
-  // Wait untill first thread (main_writer) writing to DB is blocked and then
-  // create the multiple writers which will be blocked from getting added to the
-  // queue because stall is in effect.
-  {
-    InstrumentedMutexLock lock(&mutex);
-    while (wait_count_db != 1) {
-      cv.Wait();
-    }
-  }
-
-  for (int i = 0; i < num_writers; i += 2) {
-    threads.emplace_back(write_no_slow_down, (i) % 4);
-    threads.emplace_back(write_slow_down, (i + 1) % 4);
-  }
-  for (auto& t : threads) {
-    t.join();
-  }
-
-  ASSERT_TRUE(s1);
-  ASSERT_TRUE(s2);
-  // Number of DBs blocked.
-  ASSERT_EQ(wait_count_db, 1);
-  // Number of Writer threads blocked.
-  ASSERT_EQ(w_slowdown_set.size(), num_writers / 2);
-  // Number of Writer threads with WriteOptions.no_slowdown = true.
-  ASSERT_EQ(w_no_slowdown.load(std::memory_order_relaxed), num_writers / 2);
-
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks();
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
-}
-
-// Test multiple threads writing across multiple columns of db_ and different
-// dbs by passing different values to WriteOption.no_slown_down.
-TEST_P(DBWriteBufferManagerTest, MixedSlowDownOptionsMultipleDB) {
-  std::vector<std::string> dbnames;
-  std::vector<DB*> dbs;
-  int num_dbs = 4;
-
-  for (int i = 0; i < num_dbs; i++) {
-    dbs.push_back(nullptr);
-    dbnames.push_back(
-        test::PerThreadDBPath("db_shared_wb_db" + std::to_string(i)));
-  }
-
-  Options options = CurrentOptions();
-  options.arena_block_size = 4096;
-  options.write_buffer_size = 500000;  // this is never hit
-  std::shared_ptr<Cache> cache = NewLRUCache(4 * 1024 * 1024, 2);
-  ASSERT_LT(cache->GetUsage(), 256 * 1024);
-  cost_cache_ = GetParam();
-
-  if (cost_cache_) {
-    options.write_buffer_manager.reset(
-        new WriteBufferManager(100000, cache, true));
-  } else {
-    options.write_buffer_manager.reset(
-        new WriteBufferManager(100000, nullptr, true));
-  }
-  CreateAndReopenWithCF({"cf1", "cf2"}, options);
-
-  for (int i = 0; i < num_dbs; i++) {
-    ASSERT_OK(DestroyDB(dbnames[i], options));
-    ASSERT_OK(DB::Open(options, dbnames[i], &(dbs[i])));
-  }
-  WriteOptions wo;
-  wo.disableWAL = true;
-
-  for (int i = 0; i < num_dbs; i++) {
-    ASSERT_OK(dbs[i]->Put(wo, Key(1), DummyString(20000)));
-  }
-  // Insert to db_.
-  ASSERT_OK(Put(0, Key(1), DummyString(30000), wo));
-
-  // WriteBufferManager::buffer_size_ has exceeded after the previous write to
-  // dbs[0] is completed.
-  std::vector<port::Thread> threads;
-  int wait_count_db = 0;
-  InstrumentedMutex mutex;
-  InstrumentedCondVar cv(&mutex);
-  std::unordered_set<WriteThread::Writer*> w_slowdown_set;
-  std::vector<port::Thread> writer_threads;
-  std::atomic<int> thread_num(0);
-  std::atomic<int> w_no_slowdown(0);
-
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency(
-      {{"DBWriteBufferManagerTest::SharedWriteBufferAcrossCFs:0",
-        "DBImpl::BackgroundCallFlush:start"}});
-
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
-      "WBMStallInterface::BlockDB", [&](void*) {
-        InstrumentedMutexLock lock(&mutex);
-        wait_count_db++;
-        cv.Signal();
-        // Allow the flush continue if all writer threads are blocked.
-        if (w_slowdown_set.size() +
-                (unsigned long)(w_no_slowdown.load(std::memory_order_relaxed) +
-                                wait_count_db) ==
-            (unsigned long)(2 * num_dbs + 1)) {
-          TEST_SYNC_POINT(
-              "DBWriteBufferManagerTest::SharedWriteBufferAcrossCFs:0");
-        }
-      });
-
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
-      "WriteThread::WriteStall::Wait", [&](void* arg) {
-        WriteThread::Writer* w = reinterpret_cast<WriteThread::Writer*>(arg);
-        InstrumentedMutexLock lock(&mutex);
-        w_slowdown_set.insert(w);
-        // Allow the flush continue if all writer threads are blocked.
-        if (w_slowdown_set.size() +
-                (unsigned long)(w_no_slowdown.load(std::memory_order_relaxed) +
-                                wait_count_db) ==
-            (unsigned long)(2 * num_dbs + 1)) {
-          TEST_SYNC_POINT(
-              "DBWriteBufferManagerTest::SharedWriteBufferAcrossCFs:0");
-        }
-      });
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
-
-  bool s1 = true, s2 = true;
-  std::function<void(DB*)> write_slow_down = [&](DB* db) {
-    int a = thread_num.fetch_add(1);
-    std::string key = "foo" + std::to_string(a);
-    WriteOptions write_op;
-    write_op.no_slowdown = false;
-    Status tmp = db->Put(write_op, Slice(key), DummyString(1));
-    InstrumentedMutexLock lock(&mutex);
-    s1 = s1 && tmp.ok();
-  };
-
-  std::function<void(DB*)> write_no_slow_down = [&](DB* db) {
-    int a = thread_num.fetch_add(1);
-    std::string key = "foo" + std::to_string(a);
-    WriteOptions write_op;
-    write_op.no_slowdown = true;
-    Status tmp = db->Put(write_op, Slice(key), DummyString(1));
-    {
-      InstrumentedMutexLock lock(&mutex);
-      s2 = s2 && !tmp.ok();
-      w_no_slowdown.fetch_add(1);
-      if (w_slowdown_set.size() +
-              (unsigned long)(w_no_slowdown.load(std::memory_order_relaxed) +
-                              wait_count_db) ==
-          (unsigned long)(2 * num_dbs + 1)) {
-        TEST_SYNC_POINT(
-            "DBWriteBufferManagerTest::SharedWriteBufferAcrossCFs:0");
-      }
-    }
-  };
-
-  // Flow:
-  // first thread will write but will be blocked (as Flush will on hold,
-  // buffer_size_ has exceeded, thus will create stall in effect).
-  //  |
-  //  |
-  //  multiple writer threads will be created to write across multiple columns
-  //  of db_ and different DBs with different values of
-  //  WriteOptions.no_slowdown. Some of them will be blocked and some of them
-  //  will return with Incomplete status.
-  //  |
-  //  |
-  //  Last writer thread will write and when its blocked/return it will signal
-  //  Flush to continue to clear the stall.
-  threads.emplace_back(write_slow_down, db_);
-  // Wait untill first thread writing to DB is blocked and then
-  // create the multiple writers.
-  {
-    InstrumentedMutexLock lock(&mutex);
-    while (wait_count_db != 1) {
-      cv.Wait();
-    }
-  }
-
-  for (int i = 0; i < num_dbs; i += 2) {
-    // Write to multiple columns of db_.
-    writer_threads.emplace_back(write_slow_down, db_);
-    writer_threads.emplace_back(write_no_slow_down, db_);
-    // Write to different DBs.
-    threads.emplace_back(write_slow_down, dbs[i]);
-    threads.emplace_back(write_no_slow_down, dbs[i + 1]);
-  }
-
-  for (auto& t : threads) {
-    t.join();
-  }
-
-  for (auto& t : writer_threads) {
-    t.join();
-  }
-
-  ASSERT_TRUE(s1);
-  ASSERT_TRUE(s2);
-  // Number of DBs blocked.
-  ASSERT_EQ((num_dbs / 2) + 1, wait_count_db);
-  // Number of writer threads writing to db_ blocked from getting added to the
-  // queue.
-  ASSERT_EQ(w_slowdown_set.size(), num_dbs / 2);
-  // Number of threads with WriteOptions.no_slowdown = true.
-  ASSERT_EQ(w_no_slowdown.load(std::memory_order_relaxed), num_dbs);
-
-  // Clean up DBs.
-  for (int i = 0; i < num_dbs; i++) {
-    ASSERT_OK(dbs[i]->Close());
-    ASSERT_OK(DestroyDB(dbnames[i], options));
-    delete dbs[i];
-  }
-
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks();
-  ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
-}
-
-INSTANTIATE_TEST_CASE_P(DBWriteBufferManagerTest, DBWriteBufferManagerTest,
-                        testing::Bool());
-
-}  // namespace ROCKSDB_NAMESPACE
-
-#ifdef ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS
-extern "C" {
-void RegisterCustomObjects(int argc, char** argv);
-}
-#else
-void RegisterCustomObjects(int /*argc*/, char** /*argv*/) {}
-#endif  // !ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS
-
-int main(int argc, char** argv) {
-  ROCKSDB_NAMESPACE::port::InstallStackTraceHandler();
-  ::testing::InitGoogleTest(&argc, argv);
-  RegisterCustomObjects(argc, argv);
-  return RUN_ALL_TESTS();
-}

db/external_sst_file_basic_test.cc

@@ -1136,6 +1136,41 @@ TEST_F(ExternalSSTFileBasicTest, SyncFailure) {
   }
 }
 
+TEST_F(ExternalSSTFileBasicTest, ReopenNotSupported) {
+  Options options;
+  options.create_if_missing = true;
+  options.env = env_;
+
+  SyncPoint::GetInstance()->SetCallBack(
+      "ExternalSstFileIngestionJob::Prepare:Reopen", [&](void* arg) {
+        Status* s = static_cast<Status*>(arg);
+        *s = Status::NotSupported();
+      });
+  SyncPoint::GetInstance()->EnableProcessing();
+
+  DestroyAndReopen(options);
+
+  Options sst_file_writer_options;
+  sst_file_writer_options.env = env_;
+  std::unique_ptr<SstFileWriter> sst_file_writer(
+      new SstFileWriter(EnvOptions(), sst_file_writer_options));
+  std::string file_name =
+      sst_files_dir_ + "reopen_not_supported_test_" + ".sst";
+  ASSERT_OK(sst_file_writer->Open(file_name));
+  ASSERT_OK(sst_file_writer->Put("bar", "v2"));
+  ASSERT_OK(sst_file_writer->Finish());
+
+  IngestExternalFileOptions ingest_opt;
+  ingest_opt.move_files = true;
+  const Snapshot* snapshot = db_->GetSnapshot();
+  ASSERT_OK(db_->IngestExternalFile({file_name}, ingest_opt));
+  db_->ReleaseSnapshot(snapshot);
+
+  SyncPoint::GetInstance()->DisableProcessing();
+  SyncPoint::GetInstance()->ClearAllCallBacks();
+  Destroy(options);
+}
+
 TEST_F(ExternalSSTFileBasicTest, VerifyChecksumReadahead) {
   Options options;
   options.create_if_missing = true;

db/external_sst_file_ingestion_job.cc

@@ -109,17 +109,26 @@ Status ExternalSstFileIngestionJob::Prepare(
         // directory before ingest the file. For integrity of RocksDB we need
         // to sync the file.
         std::unique_ptr<FSWritableFile> file_to_sync;
-        status = fs_->ReopenWritableFile(path_inside_db, env_options_,
-                                         &file_to_sync, nullptr);
-        if (status.ok()) {
-          TEST_SYNC_POINT(
-              "ExternalSstFileIngestionJob::BeforeSyncIngestedFile");
-          status = SyncIngestedFile(file_to_sync.get());
-          TEST_SYNC_POINT("ExternalSstFileIngestionJob::AfterSyncIngestedFile");
-          if (!status.ok()) {
-            ROCKS_LOG_WARN(db_options_.info_log,
-                           "Failed to sync ingested file %s: %s",
-                           path_inside_db.c_str(), status.ToString().c_str());
+        Status s = fs_->ReopenWritableFile(path_inside_db, env_options_,
+                                           &file_to_sync, nullptr);
+        TEST_SYNC_POINT_CALLBACK("ExternalSstFileIngestionJob::Prepare:Reopen",
+                                 &s);
+        // Some file systems (especially remote/distributed) don't support
+        // reopening a file for writing and don't require reopening and
+        // syncing the file. Ignore the NotSupported error in that case.
+        if (!s.IsNotSupported()) {
+          status = s;
+          if (status.ok()) {
+            TEST_SYNC_POINT(
+                "ExternalSstFileIngestionJob::BeforeSyncIngestedFile");
+            status = SyncIngestedFile(file_to_sync.get());
+            TEST_SYNC_POINT(
+                "ExternalSstFileIngestionJob::AfterSyncIngestedFile");
+            if (!status.ok()) {
+              ROCKS_LOG_WARN(db_options_.info_log,
+                             "Failed to sync ingested file %s: %s",
+                             path_inside_db.c_str(), status.ToString().c_str());
+            }
           }
         }
       } else if (status.IsNotSupported() &&

db/internal_stats.cc

@@ -961,7 +961,7 @@ bool InternalStats::HandleEstimateOldestKeyTime(uint64_t* value, DBImpl* /*db*/,
 
 bool InternalStats::HandleBlockCacheStat(Cache** block_cache) {
   assert(block_cache != nullptr);
-  auto* table_factory = cfd_->ioptions()->table_factory.get();
+  auto* table_factory = cfd_->ioptions()->table_factory;
   assert(table_factory != nullptr);
   *block_cache =
       table_factory->GetOptions<Cache>(TableFactory::kBlockCacheOpts());

db/memtable.cc

@@ -59,7 +59,7 @@ ImmutableMemTableOptions::ImmutableMemTableOptions(
       inplace_callback(ioptions.inplace_callback),
       max_successive_merges(mutable_cf_options.max_successive_merges),
       statistics(ioptions.statistics),
-      merge_operator(ioptions.merge_operator.get()),
+      merge_operator(ioptions.merge_operator),
       info_log(ioptions.info_log),
       allow_data_in_errors(ioptions.allow_data_in_errors) {}
 
@@ -106,7 +106,7 @@ MemTable::MemTable(const InternalKeyComparator& cmp,
       flush_state_(FLUSH_NOT_REQUESTED),
       clock_(ioptions.clock),
       insert_with_hint_prefix_extractor_(
-          ioptions.memtable_insert_with_hint_prefix_extractor.get()),
+          ioptions.memtable_insert_with_hint_prefix_extractor),
       oldest_key_time_(std::numeric_limits<uint64_t>::max()),
       atomic_flush_seqno_(kMaxSequenceNumber),
       approximate_memory_usage_(0) {

db/output_validator.h

@@ -33,13 +33,11 @@ class OutputValidator {
     return GetHash() == other_validator.GetHash();
   }
 
+ private:
   // Not (yet) intended to be persisted, so subject to change
   // without notice between releases.
   uint64_t GetHash() const { return paranoid_hash_; }
 
-  void SetHash(uint64_t hash) { paranoid_hash_ = hash; }
-
- private:
   const InternalKeyComparator& icmp_;
   std::string prev_key_;
   uint64_t paranoid_hash_ = 0;

db/table_cache.cc

@@ -130,7 +130,7 @@ Status TableCache::GetTableReader(
         new RandomAccessFileReader(
             std::move(file), fname, ioptions_.clock, io_tracer_,
             record_read_stats ? ioptions_.statistics : nullptr, SST_READ_MICROS,
-            file_read_hist, ioptions_.rate_limiter.get(), ioptions_.listeners));
+            file_read_hist, ioptions_.rate_limiter, ioptions_.listeners));
     s = ioptions_.table_factory->NewTableReader(
         ro,
         TableReaderOptions(ioptions_, prefix_extractor, file_options,

db/version_builder.cc

@@ -517,28 +517,6 @@ class VersionBuilder::Rep {
     return meta->oldest_blob_file_number;
   }
 
-  uint64_t GetMinOldestBlobFileNumber() const {
-    uint64_t min_oldest_blob_file_num = std::numeric_limits<uint64_t>::max();
-    for (int level = 0; level < num_levels_; ++level) {
-      const auto& base_files = base_vstorage_->LevelFiles(level);
-      for (const auto* fmeta : base_files) {
-        assert(fmeta);
-        min_oldest_blob_file_num =
-            std::min(min_oldest_blob_file_num, fmeta->oldest_blob_file_number);
-      }
-      const auto& added_files = levels_[level].added_files;
-      for (const auto& elem : added_files) {
-        assert(elem.second);
-        min_oldest_blob_file_num = std::min(
-            min_oldest_blob_file_num, elem.second->oldest_blob_file_number);
-      }
-    }
-    if (min_oldest_blob_file_num == std::numeric_limits<uint64_t>::max()) {
-      min_oldest_blob_file_num = kInvalidBlobFileNumber;
-    }
-    return min_oldest_blob_file_num;
-  }
-
   Status ApplyFileDeletion(int level, uint64_t file_number) {
     assert(level != VersionStorageInfo::FileLocation::Invalid().GetLevel());
 
@@ -856,7 +834,7 @@ class VersionBuilder::Rep {
     }
   }
 
-  // Save the current state in *vstorage.
+  // Save the current state in *v.
   Status SaveTo(VersionStorageInfo* vstorage) {
     Status s = CheckConsistency(base_vstorage_);
     if (!s.ok()) {
@@ -1074,10 +1052,6 @@ Status VersionBuilder::LoadTableHandlers(
       is_initial_load, prefix_extractor, max_file_size_for_l0_meta_pin);
 }
 
-uint64_t VersionBuilder::GetMinOldestBlobFileNumber() const {
-  return rep_->GetMinOldestBlobFileNumber();
-}
-
 BaseReferencedVersionBuilder::BaseReferencedVersionBuilder(
     ColumnFamilyData* cfd)
     : version_builder_(new VersionBuilder(

db/version_builder.h

@@ -44,7 +44,6 @@ class VersionBuilder {
                            bool is_initial_load,
                            const SliceTransform* prefix_extractor,
                            size_t max_file_size_for_l0_meta_pin);
-  uint64_t GetMinOldestBlobFileNumber() const;
 
  private:
   class Rep;

db/version_edit_handler.cc

@@ -11,8 +11,6 @@
 
 #include <cinttypes>
 
-#include "db/blob/blob_file_cache.h"
-#include "db/blob/blob_file_reader.h"
 #include "monitoring/persistent_stats_history.h"
 
 namespace ROCKSDB_NAMESPACE {
@@ -131,14 +129,14 @@ Status FileChecksumRetriever::ApplyVersionEdit(VersionEdit& edit,
 VersionEditHandler::VersionEditHandler(
     bool read_only, std::vector<ColumnFamilyDescriptor> column_families,
     VersionSet* version_set, bool track_missing_files,
-    bool no_error_if_files_missing, const std::shared_ptr<IOTracer>& io_tracer,
-    bool skip_load_table_files)
+    bool no_error_if_table_files_missing,
+    const std::shared_ptr<IOTracer>& io_tracer, bool skip_load_table_files)
     : VersionEditHandlerBase(),
       read_only_(read_only),
       column_families_(std::move(column_families)),
       version_set_(version_set),
       track_missing_files_(track_missing_files),
-      no_error_if_files_missing_(no_error_if_files_missing),
+      no_error_if_table_files_missing_(no_error_if_table_files_missing),
       io_tracer_(io_tracer),
       skip_load_table_files_(skip_load_table_files),
       initialized_(false) {
@@ -303,14 +301,6 @@ bool VersionEditHandler::HasMissingFiles() const {
       break;
     }
   }
-  if (!ret) {
-    for (const auto& elem : cf_to_missing_blob_files_high_) {
-      if (elem.second != kInvalidBlobFileNumber) {
-        ret = true;
-        break;
-      }
-    }
-  }
   return ret;
 }
 
@@ -447,8 +437,6 @@ ColumnFamilyData* VersionEditHandler::CreateCfAndInit(
   if (track_missing_files_) {
     cf_to_missing_files_.emplace(edit.column_family_,
                                  std::unordered_set<uint64_t>());
-    cf_to_missing_blob_files_high_.emplace(edit.column_family_,
-                                           kInvalidBlobFileNumber);
   }
   return cfd;
 }
@@ -462,12 +450,6 @@ ColumnFamilyData* VersionEditHandler::DestroyCfAndCleanup(
     auto missing_files_iter = cf_to_missing_files_.find(edit.column_family_);
     assert(missing_files_iter != cf_to_missing_files_.end());
     cf_to_missing_files_.erase(missing_files_iter);
-
-    auto missing_blob_files_high_iter =
-        cf_to_missing_blob_files_high_.find(edit.column_family_);
-    assert(missing_blob_files_high_iter !=
-           cf_to_missing_blob_files_high_.end());
-    cf_to_missing_blob_files_high_.erase(missing_blob_files_high_iter);
   }
   ColumnFamilyData* ret =
       version_set_->GetColumnFamilySet()->GetColumnFamily(edit.column_family_);
@@ -523,7 +505,8 @@ Status VersionEditHandler::LoadTables(ColumnFamilyData* cfd,
       prefetch_index_and_filter_in_cache, is_initial_load,
       cfd->GetLatestMutableCFOptions()->prefix_extractor.get(),
       MaxFileSizeForL0MetaPin(*cfd->GetLatestMutableCFOptions()));
-  if ((s.IsPathNotFound() || s.IsCorruption()) && no_error_if_files_missing_) {
+  if ((s.IsPathNotFound() || s.IsCorruption()) &&
+      no_error_if_table_files_missing_) {
     s = Status::OK();
   }
   if (!s.ok() && !version_set_->db_options_->paranoid_checks) {
@@ -553,13 +536,9 @@ Status VersionEditHandler::ExtractInfoFromVersionEdit(ColumnFamilyData* cfd,
     }
     if (edit.has_comparator_ &&
         edit.comparator_ != cfd->user_comparator()->Name()) {
-      if (!cf_to_cmp_names_) {
-        s = Status::InvalidArgument(
-            cfd->user_comparator()->Name(),
-            "does not match existing comparator " + edit.comparator_);
-      } else {
-        cf_to_cmp_names_->emplace(cfd->GetID(), edit.comparator_);
-      }
+      s = Status::InvalidArgument(
+          cfd->user_comparator()->Name(),
+          "does not match existing comparator " + edit.comparator_);
     }
     if (edit.HasFullHistoryTsLow()) {
       const std::string& new_ts = edit.GetFullHistoryTsLow();
@@ -597,7 +576,7 @@ VersionEditHandlerPointInTime::VersionEditHandlerPointInTime(
     VersionSet* version_set, const std::shared_ptr<IOTracer>& io_tracer)
     : VersionEditHandler(read_only, column_families, version_set,
                          /*track_missing_files=*/true,
-                         /*no_error_if_files_missing=*/true, io_tracer) {}
+                         /*no_error_if_table_files_missing=*/true, io_tracer) {}
 
 VersionEditHandlerPointInTime::~VersionEditHandlerPointInTime() {
   for (const auto& elem : versions_) {
@@ -647,29 +626,7 @@ Status VersionEditHandlerPointInTime::MaybeCreateVersion(
   auto missing_files_iter = cf_to_missing_files_.find(cfd->GetID());
   assert(missing_files_iter != cf_to_missing_files_.end());
   std::unordered_set<uint64_t>& missing_files = missing_files_iter->second;
-
-  auto missing_blob_files_high_iter =
-      cf_to_missing_blob_files_high_.find(cfd->GetID());
-  assert(missing_blob_files_high_iter != cf_to_missing_blob_files_high_.end());
-  const uint64_t prev_missing_blob_file_high =
-      missing_blob_files_high_iter->second;
-
-  VersionBuilder* builder = nullptr;
-
-  if (prev_missing_blob_file_high != kInvalidBlobFileNumber) {
-    auto builder_iter = builders_.find(cfd->GetID());
-    assert(builder_iter != builders_.end());
-    builder = builder_iter->second->version_builder();
-    assert(builder != nullptr);
-  }
-
-  // At this point, we have not yet applied the new version edits read from the
-  // MANIFEST. We check whether we have any missing table and blob files.
-  const bool prev_has_missing_files =
-      !missing_files.empty() ||
-      (prev_missing_blob_file_high != kInvalidBlobFileNumber &&
-       prev_missing_blob_file_high >= builder->GetMinOldestBlobFileNumber());
-
+  const bool prev_has_missing_files = !missing_files.empty();
   for (const auto& file : edit.GetDeletedFiles()) {
     uint64_t file_num = file.second;
     auto fiter = missing_files.find(file_num);
@@ -677,8 +634,6 @@ Status VersionEditHandlerPointInTime::MaybeCreateVersion(
       missing_files.erase(fiter);
     }
   }
-
-  assert(!cfd->ioptions()->cf_paths.empty());
   Status s;
   for (const auto& elem : edit.GetNewFiles()) {
     const FileMetaData& meta = elem.second;
@@ -694,60 +649,17 @@ Status VersionEditHandlerPointInTime::MaybeCreateVersion(
       break;
     }
   }
-
-  uint64_t missing_blob_file_num = prev_missing_blob_file_high;
-  for (const auto& elem : edit.GetBlobFileAdditions()) {
-    uint64_t file_num = elem.GetBlobFileNumber();
-    s = VerifyBlobFile(cfd, file_num, elem);
-    if (s.IsPathNotFound() || s.IsNotFound() || s.IsCorruption()) {
-      missing_blob_file_num = std::max(missing_blob_file_num, file_num);
-      s = Status::OK();
-    } else if (!s.ok()) {
-      break;
-    }
-  }
-
-  bool has_missing_blob_files = false;
-  if (missing_blob_file_num != kInvalidBlobFileNumber &&
-      missing_blob_file_num >= prev_missing_blob_file_high) {
-    missing_blob_files_high_iter->second = missing_blob_file_num;
-    has_missing_blob_files = true;
-  } else if (missing_blob_file_num < prev_missing_blob_file_high) {
-    assert(false);
-  }
-
-  // We still have not applied the new version edit, but have tried to add new
-  // table and blob files after verifying their presence and consistency.
-  // Therefore, we know whether we will see new missing table and blob files
-  // later after actually applying the version edit. We perform the check here
-  // and record the result.
-  const bool has_missing_files =
-      !missing_files.empty() || has_missing_blob_files;
-
   bool missing_info = !version_edit_params_.has_log_number_ ||
                       !version_edit_params_.has_next_file_number_ ||
                       !version_edit_params_.has_last_sequence_;
 
-  // Create version before apply edit. The version will represent the state
-  // before applying the version edit.
-  // A new version will created if:
-  // 1) no error has occurred so far, and
-  // 2) log_number_, next_file_number_ and last_sequence_ are known, and
-  // 3) any of the following:
-  //   a) no missing file before, but will have missing file(s) after applying
-  //      this version edit.
-  //   b) no missing file after applying the version edit, and the caller
-  //      explicitly request that a new version be created.
+  // Create version before apply edit
   if (s.ok() && !missing_info &&
-      ((has_missing_files && !prev_has_missing_files) ||
-       (!has_missing_files && force_create_version))) {
-    if (!builder) {
-      auto builder_iter = builders_.find(cfd->GetID());
-      assert(builder_iter != builders_.end());
-      builder = builder_iter->second->version_builder();
-      assert(builder);
-    }
-
+      ((!missing_files.empty() && !prev_has_missing_files) ||
+       (missing_files.empty() && force_create_version))) {
+    auto builder_iter = builders_.find(cfd->GetID());
+    assert(builder_iter != builders_.end());
+    auto* builder = builder_iter->second->version_builder();
     auto* version = new Version(cfd, version_set_, version_set_->file_options_,
                                 *cfd->GetLatestMutableCFOptions(), io_tracer_,
                                 version_set_->current_version_number_++);
@@ -775,22 +687,6 @@ Status VersionEditHandlerPointInTime::VerifyFile(const std::string& fpath,
   return version_set_->VerifyFileMetadata(fpath, fmeta);
 }
 
-Status VersionEditHandlerPointInTime::VerifyBlobFile(
-    ColumnFamilyData* cfd, uint64_t blob_file_num,
-    const BlobFileAddition& blob_addition) {
-  BlobFileCache* blob_file_cache = cfd->blob_file_cache();
-  assert(blob_file_cache);
-  CacheHandleGuard<BlobFileReader> blob_file_reader;
-  Status s =
-      blob_file_cache->GetBlobFileReader(blob_file_num, &blob_file_reader);
-  if (!s.ok()) {
-    return s;
-  }
-  // TODO: verify checksum
-  (void)blob_addition;
-  return s;
-}
-
 Status ManifestTailer::Initialize() {
   if (Mode::kRecovery == mode_) {
     return VersionEditHandler::Initialize();
@@ -893,21 +789,13 @@ void DumpManifestHandler::CheckIterationResult(const log::Reader& reader,
     fprintf(stdout, "%s\n", s->ToString().c_str());
     return;
   }
-  assert(cf_to_cmp_names_);
   for (auto* cfd : *(version_set_->column_family_set_)) {
     fprintf(stdout,
             "--------------- Column family \"%s\"  (ID %" PRIu32
             ") --------------\n",
             cfd->GetName().c_str(), cfd->GetID());
     fprintf(stdout, "log number: %" PRIu64 "\n", cfd->GetLogNumber());
-    auto it = cf_to_cmp_names_->find(cfd->GetID());
-    if (it != cf_to_cmp_names_->end()) {
-      fprintf(stdout,
-              "comparator: <%s>, but the comparator object is not available.\n",
-              it->second.c_str());
-    } else {
-      fprintf(stdout, "comparator: %s\n", cfd->user_comparator()->Name());
-    }
+    fprintf(stdout, "comparator: %s\n", cfd->user_comparator()->Name());
     assert(cfd->current());
     fprintf(stdout, "%s \n", cfd->current()->DebugString(hex_).c_str());
   }

db/version_edit_handler.h

@@ -97,7 +97,7 @@ using VersionBuilderUPtr = std::unique_ptr<BaseReferencedVersionBuilder>;
 // 1. Create an object of VersionEditHandler or its subclasses.
 //    VersionEditHandler handler(read_only, column_families, version_set,
 //                               track_missing_files,
-//                               no_error_if_files_missing);
+//                               no_error_if_table_files_missing);
 // 2. Status s = handler.Iterate(reader, &db_id);
 // 3. Check s and handle possible errors.
 //
@@ -109,10 +109,10 @@ class VersionEditHandler : public VersionEditHandlerBase {
       bool read_only,
       const std::vector<ColumnFamilyDescriptor>& column_families,
       VersionSet* version_set, bool track_missing_files,
-      bool no_error_if_files_missing,
+      bool no_error_if_table_files_missing,
       const std::shared_ptr<IOTracer>& io_tracer)
       : VersionEditHandler(read_only, column_families, version_set,
-                           track_missing_files, no_error_if_files_missing,
+                           track_missing_files, no_error_if_table_files_missing,
                            io_tracer, /*skip_load_table_files=*/false) {}
 
   ~VersionEditHandler() override {}
@@ -133,7 +133,7 @@ class VersionEditHandler : public VersionEditHandlerBase {
   explicit VersionEditHandler(
       bool read_only, std::vector<ColumnFamilyDescriptor> column_families,
       VersionSet* version_set, bool track_missing_files,
-      bool no_error_if_files_missing,
+      bool no_error_if_table_files_missing,
       const std::shared_ptr<IOTracer>& io_tracer, bool skip_load_table_files);
 
   Status ApplyVersionEdit(VersionEdit& edit, ColumnFamilyData** cfd) override;
@@ -183,12 +183,10 @@ class VersionEditHandler : public VersionEditHandlerBase {
   const bool track_missing_files_;
   std::unordered_map<uint32_t, std::unordered_set<uint64_t>>
       cf_to_missing_files_;
-  std::unordered_map<uint32_t, uint64_t> cf_to_missing_blob_files_high_;
-  bool no_error_if_files_missing_;
+  bool no_error_if_table_files_missing_;
   std::shared_ptr<IOTracer> io_tracer_;
   bool skip_load_table_files_;
   bool initialized_;
-  std::unique_ptr<std::unordered_map<uint32_t, std::string>> cf_to_cmp_names_;
 
  private:
   Status ExtractInfoFromVersionEdit(ColumnFamilyData* cfd,
@@ -215,8 +213,6 @@ class VersionEditHandlerPointInTime : public VersionEditHandler {
                             bool force_create_version) override;
   virtual Status VerifyFile(const std::string& fpath,
                             const FileMetaData& fmeta);
-  virtual Status VerifyBlobFile(ColumnFamilyData* cfd, uint64_t blob_file_num,
-                                const BlobFileAddition& blob_addition);
 
   std::unordered_map<uint32_t, Version*> versions_;
 };
@@ -271,14 +267,12 @@ class DumpManifestHandler : public VersionEditHandler {
       : VersionEditHandler(
             /*read_only=*/true, column_families, version_set,
             /*track_missing_files=*/false,
-            /*no_error_if_files_missing=*/false, io_tracer,
+            /*no_error_if_table_files_missing=*/false, io_tracer,
             /*skip_load_table_files=*/true),
         verbose_(verbose),
         hex_(hex),
         json_(json),
-        count_(0) {
-    cf_to_cmp_names_.reset(new std::unordered_map<uint32_t, std::string>());
-  }
+        count_(0) {}
 
   ~DumpManifestHandler() override {}
 

db/version_set.cc

@@ -1768,8 +1768,8 @@ Version::Version(ColumnFamilyData* column_family_data, VersionSet* vset,
                                        : cfd_->ioptions()->statistics),
       table_cache_((cfd_ == nullptr) ? nullptr : cfd_->table_cache()),
       blob_file_cache_(cfd_ ? cfd_->blob_file_cache() : nullptr),
-      merge_operator_(
-          (cfd_ == nullptr) ? nullptr : cfd_->ioptions()->merge_operator.get()),
+      merge_operator_((cfd_ == nullptr) ? nullptr
+                                        : cfd_->ioptions()->merge_operator),
       storage_info_(
           (cfd_ == nullptr) ? nullptr : &cfd_->internal_comparator(),
           (cfd_ == nullptr) ? nullptr : cfd_->user_comparator(),
@@ -4527,6 +4527,60 @@ Status VersionSet::LogAndApplyHelper(ColumnFamilyData* cfd,
   return builder ? builder->Apply(edit) : Status::OK();
 }
 
+Status VersionSet::ExtractInfoFromVersionEdit(
+    ColumnFamilyData* cfd, const VersionEdit& from_edit,
+    VersionEditParams* version_edit_params) {
+  if (cfd != nullptr) {
+    if (from_edit.has_db_id_) {
+      version_edit_params->SetDBId(from_edit.db_id_);
+    }
+    if (from_edit.has_log_number_) {
+      if (cfd->GetLogNumber() > from_edit.log_number_) {
+        ROCKS_LOG_WARN(
+            db_options_->info_log,
+            "MANIFEST corruption detected, but ignored - Log numbers in "
+            "records NOT monotonically increasing");
+      } else {
+        cfd->SetLogNumber(from_edit.log_number_);
+        version_edit_params->SetLogNumber(from_edit.log_number_);
+      }
+    }
+    if (from_edit.has_comparator_ &&
+        from_edit.comparator_ != cfd->user_comparator()->Name()) {
+      return Status::InvalidArgument(
+          cfd->user_comparator()->Name(),
+          "does not match existing comparator " + from_edit.comparator_);
+    }
+    if (from_edit.HasFullHistoryTsLow()) {
+      const std::string& new_ts = from_edit.GetFullHistoryTsLow();
+      cfd->SetFullHistoryTsLow(new_ts);
+    }
+  }
+
+  if (from_edit.has_prev_log_number_) {
+    version_edit_params->SetPrevLogNumber(from_edit.prev_log_number_);
+  }
+
+  if (from_edit.has_next_file_number_) {
+    version_edit_params->SetNextFile(from_edit.next_file_number_);
+  }
+
+  if (from_edit.has_max_column_family_) {
+    version_edit_params->SetMaxColumnFamily(from_edit.max_column_family_);
+  }
+
+  if (from_edit.has_min_log_number_to_keep_) {
+    version_edit_params->min_log_number_to_keep_ =
+        std::max(version_edit_params->min_log_number_to_keep_,
+                 from_edit.min_log_number_to_keep_);
+  }
+
+  if (from_edit.has_last_sequence_) {
+    version_edit_params->SetLastSequence(from_edit.last_sequence_);
+  }
+  return Status::OK();
+}
+
 Status VersionSet::GetCurrentManifestPath(const std::string& dbname,
                                           FileSystem* fs,
                                           std::string* manifest_path,
@@ -4593,10 +4647,10 @@ Status VersionSet::Recover(
     reporter.status = &log_read_status;
     log::Reader reader(nullptr, std::move(manifest_file_reader), &reporter,
                        true /* checksum */, 0 /* log_number */);
-    VersionEditHandler handler(read_only, column_families,
-                               const_cast<VersionSet*>(this),
-                               /*track_missing_files=*/false,
-                               /*no_error_if_files_missing=*/false, io_tracer_);
+    VersionEditHandler handler(
+        read_only, column_families, const_cast<VersionSet*>(this),
+        /*track_missing_files=*/false,
+        /*no_error_if_table_files_missing=*/false, io_tracer_);
     handler.Iterate(reader, &log_read_status);
     s = handler.status();
     if (s.ok()) {

db/version_set.h

@@ -1331,6 +1331,10 @@ class VersionSet {
   ColumnFamilyData* CreateColumnFamily(const ColumnFamilyOptions& cf_options,
                                        const VersionEdit* edit);
 
+  Status ExtractInfoFromVersionEdit(ColumnFamilyData* cfd,
+                                    const VersionEdit& from_edit,
+                                    VersionEditParams* version_edit_params);
+
   Status VerifyFileMetadata(const std::string& fpath,
                             const FileMetaData& meta) const;
 

db/wal_manager.cc

@@ -134,8 +134,8 @@ Status WalManager::GetUpdatesSince(
 //    b. get sorted non-empty archived logs
 //    c. delete what should be deleted
 void WalManager::PurgeObsoleteWALFiles() {
-  bool const ttl_enabled = db_options_.WAL_ttl_seconds > 0;
-  bool const size_limit_enabled = db_options_.WAL_size_limit_MB > 0;
+  bool const ttl_enabled = db_options_.wal_ttl_seconds > 0;
+  bool const size_limit_enabled = db_options_.wal_size_limit_mb > 0;
   if (!ttl_enabled && !size_limit_enabled) {
     return;
   }
@@ -150,7 +150,7 @@ void WalManager::PurgeObsoleteWALFiles() {
   }
   uint64_t const now_seconds = static_cast<uint64_t>(current_time);
   uint64_t const time_to_check = (ttl_enabled && !size_limit_enabled)
-                                     ? db_options_.WAL_ttl_seconds / 2
+                                     ? db_options_.wal_ttl_seconds / 2
                                      : kDefaultIntervalToDeleteObsoleteWAL;
 
   if (purge_wal_files_last_run_ + time_to_check > now_seconds) {
@@ -185,7 +185,7 @@ void WalManager::PurgeObsoleteWALFiles() {
                          s.ToString().c_str());
           continue;
         }
-        if (now_seconds - file_m_time > db_options_.WAL_ttl_seconds) {
+        if (now_seconds - file_m_time > db_options_.wal_ttl_seconds) {
           s = DeleteDBFile(&db_options_, file_path, archival_dir, false,
                            /*force_fg=*/!wal_in_db_path_);
           if (!s.ok()) {
@@ -234,8 +234,8 @@ void WalManager::PurgeObsoleteWALFiles() {
     return;
   }
 
-  size_t const files_keep_num = static_cast<size_t>(
-      db_options_.WAL_size_limit_MB * 1024 * 1024 / log_file_size);
+  size_t const files_keep_num =
+      static_cast<size_t>(db_options_.wal_size_limit_mb * 1024 * 1024 / log_file_size);
   if (log_files_num <= files_keep_num) {
     return;
   }

db/wal_manager_test.cc

@@ -217,8 +217,8 @@ int CountRecords(TransactionLogIterator* iter) {
 }  // namespace
 
 TEST_F(WalManagerTest, WALArchivalSizeLimit) {
-  db_options_.WAL_ttl_seconds = 0;
-  db_options_.WAL_size_limit_MB = 1000;
+  db_options_.wal_ttl_seconds = 0;
+  db_options_.wal_size_limit_mb = 1000;
   Init();
 
   // TEST : Create WalManager with huge size limit and no ttl.
@@ -226,7 +226,7 @@ TEST_F(WalManagerTest, WALArchivalSizeLimit) {
   // Count the archived log files that survived.
   // Assert that all of them did.
   // Change size limit. Re-open WalManager.
-  // Assert that archive is not greater than WAL_size_limit_MB after
+  // Assert that archive is not greater than wal_size_limit_mb after
   // PurgeObsoleteWALFiles()
   // Set ttl and time_to_check_ to small values. Re-open db.
   // Assert that there are no archived logs left.
@@ -238,14 +238,14 @@ TEST_F(WalManagerTest, WALArchivalSizeLimit) {
       ListSpecificFiles(env_.get(), archive_dir, kWalFile);
   ASSERT_EQ(log_files.size(), 20U);
 
-  db_options_.WAL_size_limit_MB = 8;
+  db_options_.wal_size_limit_mb = 8;
   Reopen();
   wal_manager_->PurgeObsoleteWALFiles();
 
   uint64_t archive_size = GetLogDirSize(archive_dir, env_.get());
-  ASSERT_TRUE(archive_size <= db_options_.WAL_size_limit_MB * 1024 * 1024);
+  ASSERT_TRUE(archive_size <= db_options_.wal_size_limit_mb * 1024 * 1024);
 
-  db_options_.WAL_ttl_seconds = 1;
+  db_options_.wal_ttl_seconds = 1;
   env_->FakeSleepForMicroseconds(2 * 1000 * 1000);
   Reopen();
   wal_manager_->PurgeObsoleteWALFiles();
@@ -255,7 +255,7 @@ TEST_F(WalManagerTest, WALArchivalSizeLimit) {
 }
 
 TEST_F(WalManagerTest, WALArchivalTtl) {
-  db_options_.WAL_ttl_seconds = 1000;
+  db_options_.wal_ttl_seconds = 1000;
   Init();
 
   // TEST : Create WalManager with a ttl and no size limit.
@@ -271,7 +271,7 @@ TEST_F(WalManagerTest, WALArchivalTtl) {
       ListSpecificFiles(env_.get(), archive_dir, kWalFile);
   ASSERT_GT(log_files.size(), 0U);
 
-  db_options_.WAL_ttl_seconds = 1;
+  db_options_.wal_ttl_seconds = 1;
   env_->FakeSleepForMicroseconds(3 * 1000 * 1000);
   Reopen();
   wal_manager_->PurgeObsoleteWALFiles();

db/write_thread.cc

@@ -241,7 +241,6 @@ bool WriteThread::LinkOne(Writer* w, std::atomic<Writer*>* newest_writer) {
         MutexLock lock(&stall_mu_);
         writers = newest_writer->load(std::memory_order_relaxed);
         if (writers == &write_stall_dummy_) {
-          TEST_SYNC_POINT_CALLBACK("WriteThread::WriteStall::Wait", w);
           stall_cv_.Wait();
           // Load newest_writers_ again since it may have changed
           writers = newest_writer->load(std::memory_order_relaxed);

db_stress_tool/db_stress_common.h

@@ -258,6 +258,7 @@ DECLARE_bool(best_efforts_recovery);
 DECLARE_bool(skip_verifydb);
 DECLARE_bool(enable_compaction_filter);
 DECLARE_bool(paranoid_file_checks);
+DECLARE_bool(fail_if_options_file_error);
 DECLARE_uint64(batch_protection_bytes_per_key);
 
 DECLARE_uint64(user_timestamp_size);

db_stress_tool/db_stress_env_wrapper.h

@@ -28,7 +28,9 @@ class DbStressEnvWrapper : public EnvWrapper {
         f.find(".restore") != std::string::npos) {
       return target()->DeleteFile(f);
     }
-    return Status::OK();
+    // Rename the file instead of deletion to keep the history, and
+    // at the same time it is not visible to RocksDB.
+    return target()->RenameFile(f, f + "_renamed_");
   }
 
   // If true, all manifest files will not be delted in DeleteFile().

db_stress_tool/db_stress_gflags.cc

@@ -792,6 +792,10 @@ DEFINE_bool(paranoid_file_checks, true,
             "After writing every SST file, reopen it and read all the keys "
             "and validate checksums");
 
+DEFINE_bool(fail_if_options_file_error, false,
+            "Fail operations that fail to detect or properly persist options "
+            "file.");
+
 DEFINE_uint64(batch_protection_bytes_per_key, 0,
               "If nonzero, enables integrity protection in `WriteBatch` at the "
               "specified number of bytes per key. Currently the only supported "
@@ -808,4 +812,8 @@ DEFINE_uint64(user_timestamp_size, 0,
               "Number of bytes for a user-defined timestamp. Currently, only "
               "8-byte is supported");
 
+DEFINE_int32(open_metadata_write_fault_one_in, 0,
+             "On non-zero, enables fault injection on file metadata write "
+             "during DB reopen.");
+
 #endif  // GFLAGS

db_stress_tool/db_stress_shared_state.h

@@ -30,6 +30,7 @@ DECLARE_int32(compaction_thread_pool_adjust_interval);
 DECLARE_int32(continuous_verification_interval);
 DECLARE_int32(read_fault_one_in);
 DECLARE_int32(write_fault_one_in);
+DECLARE_int32(open_metadata_write_fault_one_in);
 
 namespace ROCKSDB_NAMESPACE {
 class StressTest;

db_stress_tool/db_stress_test_base.cc

@@ -28,9 +28,9 @@ StressTest::StressTest()
           FLAGS_bloom_bits >= 0
               ? FLAGS_use_ribbon_filter
                     ? NewExperimentalRibbonFilterPolicy(FLAGS_bloom_bits)
-                    : FLAGS_use_block_based_filter
-                          ? NewBloomFilterPolicy(FLAGS_bloom_bits, true)
-                          : NewBloomFilterPolicy(FLAGS_bloom_bits, false)
+                : FLAGS_use_block_based_filter
+                    ? NewBloomFilterPolicy(FLAGS_bloom_bits, true)
+                    : NewBloomFilterPolicy(FLAGS_bloom_bits, false)
               : nullptr),
       db_(nullptr),
 #ifndef ROCKSDB_LITE
@@ -2104,9 +2104,14 @@ void StressTest::PrintEnv() const {
           static_cast<int>(FLAGS_level_compaction_dynamic_level_bytes));
   fprintf(stdout, "Read fault one in         : %d\n", FLAGS_read_fault_one_in);
   fprintf(stdout, "Write fault one in        : %d\n", FLAGS_write_fault_one_in);
+  fprintf(stdout, "Open metadata write fault one in:\n");
+  fprintf(stdout, "                            %d\n",
+          FLAGS_open_metadata_write_fault_one_in);
   fprintf(stdout, "Sync fault injection      : %d\n", FLAGS_sync_fault_injection);
   fprintf(stdout, "Best efforts recovery     : %d\n",
           static_cast<int>(FLAGS_best_efforts_recovery));
+  fprintf(stdout, "Fail if OPTIONS file error: %d\n",
+          static_cast<int>(FLAGS_fail_if_options_file_error));
   fprintf(stdout, "User timestamp size bytes : %d\n",
           static_cast<int>(FLAGS_user_timestamp_size));
 
@@ -2325,6 +2330,7 @@ void StressTest::Open() {
 
   options_.best_efforts_recovery = FLAGS_best_efforts_recovery;
   options_.paranoid_file_checks = FLAGS_paranoid_file_checks;
+  options_.fail_if_options_file_error = FLAGS_fail_if_options_file_error;
 
   if ((options_.enable_blob_files || options_.enable_blob_garbage_collection ||
        FLAGS_allow_setting_blob_options_dynamically) &&
@@ -2409,33 +2415,78 @@ void StressTest::Open() {
         new DbStressListener(FLAGS_db, options_.db_paths, cf_descriptors));
     options_.create_missing_column_families = true;
     if (!FLAGS_use_txn) {
-#ifndef ROCKSDB_LITE
-      // StackableDB-based BlobDB
-      if (FLAGS_use_blob_db) {
-        blob_db::BlobDBOptions blob_db_options;
-        blob_db_options.min_blob_size = FLAGS_blob_db_min_blob_size;
-        blob_db_options.bytes_per_sync = FLAGS_blob_db_bytes_per_sync;
-        blob_db_options.blob_file_size = FLAGS_blob_db_file_size;
-        blob_db_options.enable_garbage_collection = FLAGS_blob_db_enable_gc;
-        blob_db_options.garbage_collection_cutoff = FLAGS_blob_db_gc_cutoff;
-
-        blob_db::BlobDB* blob_db = nullptr;
-        s = blob_db::BlobDB::Open(options_, blob_db_options, FLAGS_db,
-                                  cf_descriptors, &column_families_, &blob_db);
-        if (s.ok()) {
-          db_ = blob_db;
-        }
-      } else
-#endif  // !ROCKSDB_LITE
-      {
-        if (db_preload_finished_.load() && FLAGS_read_only) {
-          s = DB::OpenForReadOnly(DBOptions(options_), FLAGS_db, cf_descriptors,
-                                  &column_families_, &db_);
-        } else {
-          s = DB::Open(DBOptions(options_), FLAGS_db, cf_descriptors,
-                       &column_families_, &db_);
-        }
+#ifndef NDEBUG
+      // Determine whether we need to ingest file metadata write failures
+      // during DB reopen. If it does, enable it.
+      // Only ingest metadata error if it is reopening, as initial open
+      // failure doesn't need to be handled.
+      // TODO cover transaction DB is not covered in this fault test too.
+      bool ingest_meta_error =
+          FLAGS_open_metadata_write_fault_one_in &&
+          fault_fs_guard
+              ->FileExists(FLAGS_db + "/CURRENT", IOOptions(), nullptr)
+              .ok();
+      if (ingest_meta_error) {
+        fault_fs_guard->EnableMetadataWriteErrorInjection();
+        fault_fs_guard->SetRandomMetadataWriteError(
+            FLAGS_open_metadata_write_fault_one_in);
       }
+      while (true) {
+#endif  // NDEBUG
+#ifndef ROCKSDB_LITE
+        // StackableDB-based BlobDB
+        if (FLAGS_use_blob_db) {
+          blob_db::BlobDBOptions blob_db_options;
+          blob_db_options.min_blob_size = FLAGS_blob_db_min_blob_size;
+          blob_db_options.bytes_per_sync = FLAGS_blob_db_bytes_per_sync;
+          blob_db_options.blob_file_size = FLAGS_blob_db_file_size;
+          blob_db_options.enable_garbage_collection = FLAGS_blob_db_enable_gc;
+          blob_db_options.garbage_collection_cutoff = FLAGS_blob_db_gc_cutoff;
+
+          blob_db::BlobDB* blob_db = nullptr;
+          s = blob_db::BlobDB::Open(options_, blob_db_options, FLAGS_db,
+                                    cf_descriptors, &column_families_,
+                                    &blob_db);
+          if (s.ok()) {
+            db_ = blob_db;
+          }
+        } else
+#endif  // !ROCKSDB_LITE
+        {
+          if (db_preload_finished_.load() && FLAGS_read_only) {
+            s = DB::OpenForReadOnly(DBOptions(options_), FLAGS_db,
+                                    cf_descriptors, &column_families_, &db_);
+          } else {
+            s = DB::Open(DBOptions(options_), FLAGS_db, cf_descriptors,
+                         &column_families_, &db_);
+          }
+        }
+
+#ifndef NDEBUG
+        if (ingest_meta_error) {
+          fault_fs_guard->DisableMetadataWriteErrorInjection();
+          if (!s.ok()) {
+            // After failure to opening a DB due to IO error, retry should
+            // successfully open the DB with correct data if no IO error shows
+            // up.
+            ingest_meta_error = false;
+
+            Random rand(static_cast<uint32_t>(FLAGS_seed));
+            if (rand.OneIn(2)) {
+              fault_fs_guard->DeleteFilesCreatedAfterLastDirSync(IOOptions(),
+                                                                 nullptr);
+            }
+            if (rand.OneIn(3)) {
+              fault_fs_guard->DropUnsyncedFileData();
+            } else if (rand.OneIn(2)) {
+              fault_fs_guard->DropRandomUnsyncedFileData(&rand);
+            }
+            continue;
+          }
+        }
+        break;
+      }
+#endif  // NDEBUG
     } else {
 #ifndef ROCKSDB_LITE
       TransactionDBOptions txn_db_options;

db_stress_tool/db_stress_tool.cc

@@ -98,7 +98,7 @@ int db_stress_tool(int argc, char** argv) {
 
 #ifndef NDEBUG
   if (FLAGS_read_fault_one_in || FLAGS_sync_fault_injection ||
-      FLAGS_write_fault_one_in) {
+      FLAGS_write_fault_one_in || FLAGS_open_metadata_write_fault_one_in) {
     FaultInjectionTestFS* fs =
         new FaultInjectionTestFS(raw_env->GetFileSystem());
     fault_fs_guard.reset(fs);

env/env_encryption.cc

@@ -362,17 +362,6 @@ void EncryptedWritableFile::PrepareWrite(size_t offset, size_t len,
   file_->PrepareWrite(offset + prefixLength_, len, options, dbg);
 }
 
-void EncryptedWritableFile::SetPreallocationBlockSize(size_t size) {
-  // the size here doesn't need to include prefixLength_, as it's a
-  // configuration will be use for `PrepareWrite()`.
-  file_->SetPreallocationBlockSize(size);
-}
-
-void EncryptedWritableFile::GetPreallocationStatus(
-    size_t* block_size, size_t* last_allocated_block) {
-  file_->GetPreallocationStatus(block_size, last_allocated_block);
-}
-
 // Pre-allocates space for a file.
 IOStatus EncryptedWritableFile::Allocate(uint64_t offset, uint64_t len,
                                          const IOOptions& options,

include/rocksdb/c.h

@@ -73,9 +73,7 @@ typedef struct rocksdb_backup_engine_t   rocksdb_backup_engine_t;
 typedef struct rocksdb_backup_engine_info_t   rocksdb_backup_engine_info_t;
 typedef struct rocksdb_backupable_db_options_t rocksdb_backupable_db_options_t;
 typedef struct rocksdb_restore_options_t rocksdb_restore_options_t;
-typedef struct rocksdb_memory_allocator_t rocksdb_memory_allocator_t;
-typedef struct rocksdb_lru_cache_options_t rocksdb_lru_cache_options_t;
-typedef struct rocksdb_cache_t rocksdb_cache_t;
+typedef struct rocksdb_cache_t           rocksdb_cache_t;
 typedef struct rocksdb_compactionfilter_t rocksdb_compactionfilter_t;
 typedef struct rocksdb_compactionfiltercontext_t
     rocksdb_compactionfiltercontext_t;
@@ -1740,28 +1738,10 @@ extern ROCKSDB_LIBRARY_API void rocksdb_flushoptions_set_wait(
 extern ROCKSDB_LIBRARY_API unsigned char rocksdb_flushoptions_get_wait(
     rocksdb_flushoptions_t*);
 
-/* Memory allocator */
-
-extern ROCKSDB_LIBRARY_API rocksdb_memory_allocator_t*
-rocksdb_jemalloc_nodump_allocator_create(char** errptr);
-extern ROCKSDB_LIBRARY_API void rocksdb_memory_allocator_destroy(
-    rocksdb_memory_allocator_t*);
-
 /* Cache */
 
-extern ROCKSDB_LIBRARY_API rocksdb_lru_cache_options_t*
-rocksdb_lru_cache_options_create(void);
-extern ROCKSDB_LIBRARY_API void rocksdb_lru_cache_options_destroy(
-    rocksdb_lru_cache_options_t*);
-extern ROCKSDB_LIBRARY_API void rocksdb_lru_cache_options_set_capacity(
-    rocksdb_lru_cache_options_t*, size_t);
-extern ROCKSDB_LIBRARY_API void rocksdb_lru_cache_options_set_memory_allocator(
-    rocksdb_lru_cache_options_t*, rocksdb_memory_allocator_t*);
-
 extern ROCKSDB_LIBRARY_API rocksdb_cache_t* rocksdb_cache_create_lru(
     size_t capacity);
-extern ROCKSDB_LIBRARY_API rocksdb_cache_t* rocksdb_cache_create_lru_opts(
-    rocksdb_lru_cache_options_t*);
 extern ROCKSDB_LIBRARY_API void rocksdb_cache_destroy(rocksdb_cache_t* cache);
 extern ROCKSDB_LIBRARY_API void rocksdb_cache_disown_data(
     rocksdb_cache_t* cache);

include/rocksdb/cache.h

@@ -23,11 +23,8 @@
 #pragma once
 
 #include <stdint.h>
-
-#include <functional>
 #include <memory>
 #include <string>
-
 #include "rocksdb/memory_allocator.h"
 #include "rocksdb/slice.h"
 #include "rocksdb/statistics.h"
@@ -37,7 +34,6 @@ namespace ROCKSDB_NAMESPACE {
 
 class Cache;
 struct ConfigOptions;
-class TieredCache;
 
 extern const bool kDefaultToAdaptiveMutex;
 
@@ -91,9 +87,6 @@ struct LRUCacheOptions {
   CacheMetadataChargePolicy metadata_charge_policy =
       kDefaultCacheMetadataChargePolicy;
 
-  // A TieredCache instance to use a the non-volatile tier
-  std::shared_ptr<TieredCache> tiered_cache;
-
   LRUCacheOptions() {}
   LRUCacheOptions(size_t _capacity, int _num_shard_bits,
                   bool _strict_capacity_limit, double _high_pri_pool_ratio,
@@ -144,57 +137,6 @@ class Cache {
   // likely to get evicted than low priority entries.
   enum class Priority { HIGH, LOW };
 
-  // A set of callbacks to allow objects in the volatile block cache to be
-  // be persisted in a NVM cache tier. Since the volatile cache holds C++
-  // objects and the NVM cache may only hold flat data that doesn't need
-  // relocation, these callbacks need to be provided by the user of the block
-  // cache to do the conversion.
-  // The CacheItemHelperCallback is passed to Insert(). When invoked, it
-  // returns the callback functions for size, saving and deletion of the
-  // object. We do it this way so that the cache implementation only needs to
-  // save one function pointer in its metadata per object, the
-  // CacheItemHelperCallback pointer which is a C-style function pointer.
-  // Saving multiple std::function objects will take up 32 bytes per
-  // function, even if its not bound to an object and does no capture. The
-  // other alternative is to take a pointer to another object that implements
-  // this interface, but that would create issues with managing the object
-  // lifecycle.
-  //
-  // All the callbacks are C-style function pointers in order to simplify
-  // lifecycle management. Objects in the cache can outlive the parent DB,
-  // so anything required for these operations should be contained in the
-  // object itself.
-  //
-  // The SizeCallback takes a void* pointer to the object and returns the size
-  // of the persistable data. It can be used by the NVM cache to allocate
-  // memory if needed.
-  typedef size_t (*SizeCallback)(void* obj);
-
-  // The SaveToCallback takes a void* object pointer and saves the persistable
-  // data into a buffer. The NVM cache may decide to not store it in a
-  // contiguous buffer, in which case this callback will be called multiple
-  // times with increasing offset
-  typedef ROCKSDB_NAMESPACE::Status (*SaveToCallback)(void* obj, size_t offset,
-                                                      size_t size, void* out);
-
-  // DeletionCallback is a function pointer that deletes the cached
-  // object. The signature matches the old deleter function.
-  typedef void (*DeletionCallback)(const Slice&, void*);
-
-  // A callback function that returns the size, save to, and deletion
-  // callbacks. Fill any of size_cb, saveto_cb, del_cb that is non-null
-  typedef void (*CacheItemHelperCallback)(SizeCallback* size_cb,
-                                          SaveToCallback* saveto_cb,
-                                          DeletionCallback* del_cb);
-
-  // The CreateCallback is passed by the block cache user to Lookup(). It
-  // takes in a buffer from the NVM cache and constructs an object using
-  // it. The callback doesn't have ownership of the buffer and should
-  // copy the contents into its own buffer.
-  typedef std::function<ROCKSDB_NAMESPACE::Status(
-      void* buf, size_t size, void** out_obj, size_t* charge)>
-      CreateCallback;
-
   Cache(std::shared_ptr<MemoryAllocator> allocator = nullptr)
       : memory_allocator_(std::move(allocator)) {}
   // No copying allowed
@@ -228,8 +170,8 @@ class Cache {
   // The type of the Cache
   virtual const char* Name() const = 0;
 
-  // Insert a mapping from key->value into the volatile cache only
-  // and assign it // the specified charge against the total cache capacity.
+  // Insert a mapping from key->value into the cache and assign it
+  // the specified charge against the total cache capacity.
   // If strict_capacity_limit is true and cache reaches its full capacity,
   // return Status::Incomplete.
   //
@@ -345,79 +287,6 @@ class Cache {
 
   MemoryAllocator* memory_allocator() const { return memory_allocator_.get(); }
 
-  // Insert a mapping from key->value into the volatile cache and assign it
-  // the specified charge against the total cache capacity.
-  // If strict_capacity_limit is true and cache reaches its full capacity,
-  // return Status::Incomplete.
-  //
-  // If handle is not nullptr, returns a handle that corresponds to the
-  // mapping. The caller must call this->Release(handle) when the returned
-  // mapping is no longer needed. In case of error caller is responsible to
-  // cleanup the value (i.e. calling "deleter").
-  //
-  // If handle is nullptr, it is as if Release is called immediately after
-  // insert. In case of error value will be cleanup.
-  //
-  // Regardless of whether the item was inserted into the volatile cache,
-  // it will attempt to insert it into the NVM cache if one is configured.
-  // The block cache implementation must support the NVM tier, otherwise
-  // the item is only inserted into the volatile tier. It may
-  // defer the insertion to NVM as it sees fit. The NVM
-  // cache may or may not write it to NVM depending on its admission
-  // policy.
-  //
-  // When the inserted entry is no longer needed, the key and
-  // value will be passed to "deleter".
-  virtual Status Insert(const Slice& key, void* value,
-                        CacheItemHelperCallback helper_cb, size_t charge,
-                        Handle** handle = nullptr,
-                        Priority priority = Priority::LOW) {
-    DeletionCallback delete_cb = nullptr;
-    assert(helper_cb != nullptr);
-    (*helper_cb)(nullptr, nullptr, &delete_cb);
-    return Insert(key, value, charge, delete_cb, handle, priority);
-  }
-
-  // Lookup the key in the volatile and NVM tiers (if one is configured).
-  // The create_cb callback function object will be used to contruct the
-  // cached object.
-  // If none of the tiers have the mapping for the key, rturns nullptr.
-  // Else, returns a handle that corresponds to the mapping.
-  //
-  // The handle returned may not be ready. The caller should call isReady()
-  // to check if the item value is ready, and call Wait() or WaitAll() if
-  // its not ready. The caller should then call Value() to check if the
-  // item was successfully retrieved. If unsuccessful (perhaps due to an
-  // IO error), Value() will return nullptr.
-  virtual Handle* Lookup(const Slice& key,
-                         CacheItemHelperCallback /*helper_cb*/,
-                         const CreateCallback& /*create_cb*/,
-                         Priority /*priority*/, bool /*wait*/,
-                         Statistics* stats = nullptr) {
-    return Lookup(key, stats);
-  }
-
-  // Release a mapping returned by a previous Lookup(). The "useful"
-  // parameter specifies whether the data was actually used or not,
-  // which may be used by the cache implementation to decide whether
-  // to consider it as a hit for retention purposes.
-  virtual bool Release(Handle* handle, bool /*useful*/, bool force_erase) {
-    return Release(handle, force_erase);
-  }
-
-  // Determines if the handle returned by Lookup() has a valid value yet.
-  virtual bool isReady(Handle* /*handle*/) { return true; }
-
-  // If the handle returned by Lookup() is not ready yet, wait till it
-  // becomes ready.
-  // Note: A ready handle doesn't necessarily mean it has a valid value. The
-  // user should call Value() and check for nullptr.
-  virtual void Wait(Handle* /*handle*/) {}
-
-  // Wait for a vector of handles to become ready. As with Wait(), the user
-  // should check the Value() of each handle for nullptr
-  virtual void WaitAll(std::vector<Handle*>& /*handles*/) {}
-
  private:
   std::shared_ptr<MemoryAllocator> memory_allocator_;
 };

include/rocksdb/cache_bench_tool.h

@@ -1,14 +0,0 @@
-// Copyright (c) 2013-present, Facebook, Inc.  All rights reserved.
-//  This source code is licensed under both the GPLv2 (found in the
-//  COPYING file in the root directory) and Apache 2.0 License
-//  (found in the LICENSE.Apache file in the root directory).
-#pragma once
-
-#include "rocksdb/rocksdb_namespace.h"
-#include "rocksdb/status.h"
-#include "rocksdb/types.h"
-
-namespace ROCKSDB_NAMESPACE {
-
-int cache_bench_tool(int argc, char** argv);
-}  // namespace ROCKSDB_NAMESPACE

include/rocksdb/configurable.h

@@ -350,35 +350,6 @@ class Configurable {
   //  Given a name (e.g. rocksdb.my.type.opt), returns the short name (opt)
   virtual std::string GetOptionName(const std::string& long_name) const;
 
-  // Registers the input name with the options and associated map.
-  // When classes register their options in this manner, most of the
-  // functionality (excluding unknown options and validate/prepare) is
-  // implemented by the base class.
-  //
-  // This method should be called in the class constructor to register the
-  // option set for this object.  For example, to register the options
-  // associated with the BlockBasedTableFactory, the constructor calls this
-  // method passing in:
-  // - the name of the options ("BlockBasedTableOptions");
-  // - the options object (the BlockBasedTableOptions object for this object;
-  // - the options type map for the BlockBasedTableOptions.
-  // This registration allows the Configurable class to process the option
-  // values associated with the BlockBasedTableOptions without further code in
-  // the derived class.
-  //
-  // @param name    The name of this set of options (@see GetOptionsPtr)
-  // @param opt_ptr Pointer to the options to associate with this name
-  // @param opt_map Options map that controls how this option is configured.
-  template <typename T>
-  void RegisterOptions(
-      T* opt_ptr,
-      const std::unordered_map<std::string, OptionTypeInfo>* opt_map) {
-    RegisterOptions(T::kName(), opt_ptr, opt_map);
-  }
-  void RegisterOptions(
-      const std::string& name, void* opt_ptr,
-      const std::unordered_map<std::string, OptionTypeInfo>* opt_map);
-
  private:
   // Contains the collection of options (name, opt_ptr, opt_map) associated with
   // this object. This collection is typically set in the constructor of the

include/rocksdb/db.h

@@ -1180,13 +1180,7 @@ class DB {
   virtual Status EnableAutoCompaction(
       const std::vector<ColumnFamilyHandle*>& column_family_handles) = 0;
 
-  // After this function call, CompactRange() or CompactFiles() will not
-  // run compactions and fail. The function will wait for all outstanding
-  // manual compactions to finish before returning
   virtual void DisableManualCompaction() = 0;
-  // Re-enable CompactRange() and ComapctFiles() that are disabled by
-  // DisableManualCompaction(). In debug mode, it might hit assertion if
-  // no DisableManualCompaction() was previously called.
   virtual void EnableManualCompaction() = 0;
 
   // Number of levels used for this DB.

include/rocksdb/env_encryption.h

@@ -366,11 +366,6 @@ class EncryptedWritableFile : public FSWritableFile {
   void PrepareWrite(size_t offset, size_t len, const IOOptions& options,
                     IODebugContext* dbg) override;
 
-  void SetPreallocationBlockSize(size_t size) override;
-
-  void GetPreallocationStatus(size_t* block_size,
-                              size_t* last_allocated_block) override;
-
   // Pre-allocates space for a file.
   IOStatus Allocate(uint64_t offset, uint64_t len, const IOOptions& options,
                     IODebugContext* dbg) override;

include/rocksdb/tiered_cache.h

@@ -1,79 +0,0 @@
-// Copyright (c) 2021, Facebook, Inc.  All rights reserved.
-//  This source code is licensed under both the GPLv2 (found in the
-//  COPYING file in the root directory) and Apache 2.0 License
-//  (found in the LICENSE.Apache file in the root directory).
-#pragma once
-
-#include <stdint.h>
-
-#include <memory>
-#include <string>
-
-#include "rocksdb/cache.h"
-#include "rocksdb/slice.h"
-#include "rocksdb/statistics.h"
-#include "rocksdb/status.h"
-
-namespace ROCKSDB_NAMESPACE {
-
-// A handle for lookup result. The handle may not be immediately ready or
-// have a valid value. The caller must call isReady() to determine if its
-// ready, and call Wait() in order to block until it becomes ready.
-// The caller must call value() after it becomes ready to determine if the
-// handle successfullly read the item.
-class TieredCacheHandle {
- public:
-  virtual ~TieredCacheHandle() {}
-
-  // Returns whether the handle is ready or not
-  virtual bool isReady() = 0;
-
-  // Block until handle becomes ready
-  virtual void Wait() = 0;
-
-  // Return the value. If nullptr, it means the lookup was unsuccessful
-  virtual void* Value() = 0;
-
-  // Return the size of value
-  virtual size_t Size() = 0;
-};
-
-// TieredCache
-//
-// Cache interface for caching blocks on a stackable tiers (which can include
-// non-volatile mediums)
-class TieredCache {
- public:
-  virtual ~TieredCache() {}
-
-  virtual std::string Name() = 0;
-
-  static const char* Type() { return "TieredCache"; }
-
-  // Insert the given value into this tier. The value is not written
-  // directly. Rather, the SaveToCallback provided by helper_cb will be
-  // used to extract the persistable data in value, which will be written
-  // to this tier. The implementation may or may not write it to cache
-  // depending on the admission control policy, even if the return status is
-  // success.
-  virtual Status Insert(const Slice& key, void* value,
-                        Cache::CacheItemHelperCallback helper_cb) = 0;
-
-  // Lookup the data for the given key in this tier. The create_cb
-  // will be used to create the object. The handle returned may not be
-  // ready yet, unless wait=true, in which case Lookup() will block until
-  // the handle is ready
-  virtual std::unique_ptr<TieredCacheHandle> Lookup(
-      const Slice& key, const Cache::CreateCallback& create_cb, bool wait) = 0;
-
-  // At the discretion of the implementation, erase the data associated
-  // with key
-  virtual void Erase(const Slice& key) = 0;
-
-  // Wait for a collection of handles to become ready
-  virtual void WaitAll(std::vector<TieredCacheHandle*> handles) = 0;
-
-  virtual std::string GetPrintableOptions() const = 0;
-};
-
-}  // namespace ROCKSDB_NAMESPACE

include/rocksdb/version.h

@@ -11,7 +11,7 @@
 
 #define ROCKSDB_MAJOR 6
 #define ROCKSDB_MINOR 20
-#define ROCKSDB_PATCH 0
+#define ROCKSDB_PATCH 4
 
 // Do not use these. We made the mistake of declaring macros starting with
 // double underscore. Now we have to live with our choice. We'll deprecate these

include/rocksdb/write_buffer_manager.h

@@ -13,86 +13,43 @@
 #pragma once
 
 #include <atomic>
-#include <condition_variable>
 #include <cstddef>
-#include <list>
-#include <mutex>
-
 #include "rocksdb/cache.h"
 
 namespace ROCKSDB_NAMESPACE {
 
-// Interface to block and signal DB instances.
-// Each DB instance contains ptr to StallInterface.
-class StallInterface {
- public:
-  virtual ~StallInterface() {}
-
-  virtual void Block() = 0;
-
-  virtual void Signal() = 0;
-};
-
 class WriteBufferManager {
  public:
-  // Parameters:
-  // _buffer_size: _buffer_size = 0 indicates no limit. Memory won't be capped.
+  // _buffer_size = 0 indicates no limit. Memory won't be capped.
   // memory_usage() won't be valid and ShouldFlush() will always return true.
-  //
-  // cache_: if `cache` is provided, we'll put dummy entries in the cache and
-  // cost the memory allocated to the cache. It can be used even if _buffer_size
-  // = 0.
-  //
-  // allow_stall: if set true, it will enable stalling of writes when
-  // memory_usage() exceeds buffer_size. It will wait for flush to complete and
-  // memory usage to drop down.
+  // if `cache` is provided, we'll put dummy entries in the cache and cost
+  // the memory allocated to the cache. It can be used even if _buffer_size = 0.
   explicit WriteBufferManager(size_t _buffer_size,
-                              std::shared_ptr<Cache> cache = {},
-                              bool allow_stall = false);
+                              std::shared_ptr<Cache> cache = {});
   // No copying allowed
   WriteBufferManager(const WriteBufferManager&) = delete;
   WriteBufferManager& operator=(const WriteBufferManager&) = delete;
 
   ~WriteBufferManager();
 
-  // Returns true if buffer_limit is passed to limit the total memory usage and
-  // is greater than 0.
   bool enabled() const { return buffer_size() > 0; }
 
-  // Returns true if pointer to cache is passed.
   bool cost_to_cache() const { return cache_rep_ != nullptr; }
 
-  // Returns the total memory used by memtables.
   // Only valid if enabled()
   size_t memory_usage() const {
     return memory_used_.load(std::memory_order_relaxed);
   }
-
-  // Returns the total memory used by active memtables.
   size_t mutable_memtable_memory_usage() const {
     return memory_active_.load(std::memory_order_relaxed);
   }
-
   size_t dummy_entries_in_cache_usage() const {
     return dummy_size_.load(std::memory_order_relaxed);
   }
-
-  // Returns the buffer_size.
   size_t buffer_size() const {
     return buffer_size_.load(std::memory_order_relaxed);
   }
 
-  void SetBufferSize(size_t new_size) {
-    buffer_size_.store(new_size, std::memory_order_relaxed);
-    mutable_limit_.store(new_size * 7 / 8, std::memory_order_relaxed);
-    // Check if stall is active and can be ended.
-    if (allow_stall_) {
-      EndWriteStall();
-    }
-  }
-
-  // Below functions should be called by RocksDB internally.
-
   // Should only be called from write thread
   bool ShouldFlush() const {
     if (enabled()) {
@@ -112,50 +69,35 @@ class WriteBufferManager {
     return false;
   }
 
-  // Returns true if total memory usage exceeded buffer_size.
-  // We stall the writes untill memory_usage drops below buffer_size. When the
-  // function returns true, all writer threads (including one checking this
-  // condition) across all DBs will be stalled. Stall is allowed only if user
-  // pass allow_stall = true during WriteBufferManager instance creation.
-  //
-  // Should only be called by RocksDB internally .
-  bool ShouldStall() {
-    if (allow_stall_ && enabled()) {
-      if (IsStallActive()) {
-        return true;
-      }
-      if (IsStallThresholdExceeded()) {
-        stall_active_.store(true, std::memory_order_relaxed);
-        return true;
-      }
+  void ReserveMem(size_t mem) {
+    if (cache_rep_ != nullptr) {
+      ReserveMemWithCache(mem);
+    } else if (enabled()) {
+      memory_used_.fetch_add(mem, std::memory_order_relaxed);
+    }
+    if (enabled()) {
+      memory_active_.fetch_add(mem, std::memory_order_relaxed);
     }
-    return false;
   }
-
-  // Returns true if stall is active.
-  bool IsStallActive() const {
-    return stall_active_.load(std::memory_order_relaxed);
-  }
-
-  // Returns true if stalling condition is met.
-  bool IsStallThresholdExceeded() { return memory_usage() >= buffer_size_; }
-
-  void ReserveMem(size_t mem);
-
   // We are in the process of freeing `mem` bytes, so it is not considered
   // when checking the soft limit.
-  void ScheduleFreeMem(size_t mem);
+  void ScheduleFreeMem(size_t mem) {
+    if (enabled()) {
+      memory_active_.fetch_sub(mem, std::memory_order_relaxed);
+    }
+  }
+  void FreeMem(size_t mem) {
+    if (cache_rep_ != nullptr) {
+      FreeMemWithCache(mem);
+    } else if (enabled()) {
+      memory_used_.fetch_sub(mem, std::memory_order_relaxed);
+    }
+  }
 
-  void FreeMem(size_t mem);
-
-  // Add the DB instance to the queue and block the DB.
-  // Should only be called by RocksDB internally.
-  void BeginWriteStall(StallInterface* wbm_stall);
-
-  // Remove DB instances from queue and signal them to continue.
-  void EndWriteStall();
-
-  void RemoveDBFromQueue(StallInterface* wbm_stall);
+  void SetBufferSize(size_t new_size) {
+    buffer_size_.store(new_size, std::memory_order_relaxed);
+    mutable_limit_.store(new_size * 7 / 8, std::memory_order_relaxed);
+  }
 
  private:
   std::atomic<size_t> buffer_size_;
@@ -166,11 +108,6 @@ class WriteBufferManager {
   std::atomic<size_t> dummy_size_;
   struct CacheRep;
   std::unique_ptr<CacheRep> cache_rep_;
-  std::list<StallInterface*> queue_;
-  // Protects the queue_
-  std::mutex mu_;
-  bool allow_stall_;
-  std::atomic<bool> stall_active_;
 
   void ReserveMemWithCache(size_t mem);
   void FreeMemWithCache(size_t mem);

java/src/main/java/org/rocksdb/RocksDB.java

@@ -2546,9 +2546,7 @@ public class RocksDB extends RocksObject {
 
   /**
    * If the key definitely does not exist in the database, then this method
-   * returns false, otherwise it returns true if the key might exist.
-   * That is to say that this method is probabilistic and may return false
-   * positives, but never a true negative.
+   * returns null, else it returns an instance of KeyMayExistResult
    *
    * If the caller wants to obtain value when the key
    * is found in memory, then {@code valueHolder} must be set.
@@ -2572,9 +2570,7 @@ public class RocksDB extends RocksObject {
 
   /**
    * If the key definitely does not exist in the database, then this method
-   * returns false, otherwise it returns true if the key might exist.
-   * That is to say that this method is probabilistic and may return false
-   * positives, but never a true negative.
+   * returns null, else it returns an instance of KeyMayExistResult
    *
    * If the caller wants to obtain value when the key
    * is found in memory, then {@code valueHolder} must be set.
@@ -2603,9 +2599,7 @@ public class RocksDB extends RocksObject {
 
   /**
    * If the key definitely does not exist in the database, then this method
-   * returns false, otherwise it returns true if the key might exist.
-   * That is to say that this method is probabilistic and may return false
-   * positives, but never a true negative.
+   * returns null, else it returns an instance of KeyMayExistResult
    *
    * If the caller wants to obtain value when the key
    * is found in memory, then {@code valueHolder} must be set.
@@ -2632,9 +2626,7 @@ public class RocksDB extends RocksObject {
 
   /**
    * If the key definitely does not exist in the database, then this method
-   * returns false, otherwise it returns true if the key might exist.
-   * That is to say that this method is probabilistic and may return false
-   * positives, but never a true negative.
+   * returns null, else it returns an instance of KeyMayExistResult
    *
    * If the caller wants to obtain value when the key
    * is found in memory, then {@code valueHolder} must be set.
@@ -2666,9 +2658,7 @@ public class RocksDB extends RocksObject {
 
   /**
    * If the key definitely does not exist in the database, then this method
-   * returns false, otherwise it returns true if the key might exist.
-   * That is to say that this method is probabilistic and may return false
-   * positives, but never a true negative.
+   * returns null, else it returns an instance of KeyMayExistResult
    *
    * If the caller wants to obtain value when the key
    * is found in memory, then {@code valueHolder} must be set.
@@ -2695,9 +2685,7 @@ public class RocksDB extends RocksObject {
 
   /**
    * If the key definitely does not exist in the database, then this method
-   * returns false, otherwise it returns true if the key might exist.
-   * That is to say that this method is probabilistic and may return false
-   * positives, but never a true negative.
+   * returns null, else it returns an instance of KeyMayExistResult
    *
    * If the caller wants to obtain value when the key
    * is found in memory, then {@code valueHolder} must be set.
@@ -2729,9 +2717,7 @@ public class RocksDB extends RocksObject {
 
   /**
    * If the key definitely does not exist in the database, then this method
-   * returns false, otherwise it returns true if the key might exist.
-   * That is to say that this method is probabilistic and may return false
-   * positives, but never a true negative.
+   * returns null, else it returns an instance of KeyMayExistResult
    *
    * If the caller wants to obtain value when the key
    * is found in memory, then {@code valueHolder} must be set.
@@ -2760,9 +2746,7 @@ public class RocksDB extends RocksObject {
 
   /**
    * If the key definitely does not exist in the database, then this method
-   * returns false, otherwise it returns true if the key might exist.
-   * That is to say that this method is probabilistic and may return false
-   * positives, but never a true negative.
+   * returns null, else it returns an instance of KeyMayExistResult
    *
    * If the caller wants to obtain value when the key
    * is found in memory, then {@code valueHolder} must be set.

memtable/write_buffer_manager.cc

@@ -8,8 +8,7 @@
 // found in the LICENSE file. See the AUTHORS file for names of contributors.
 
 #include "rocksdb/write_buffer_manager.h"
-
-#include "db/db_impl/db_impl.h"
+#include <mutex>
 #include "util/coding.h"
 
 namespace ROCKSDB_NAMESPACE {
@@ -50,16 +49,13 @@ struct WriteBufferManager::CacheRep {};
 #endif  // ROCKSDB_LITE
 
 WriteBufferManager::WriteBufferManager(size_t _buffer_size,
-                                       std::shared_ptr<Cache> cache,
-                                       bool allow_stall)
+                                       std::shared_ptr<Cache> cache)
     : buffer_size_(_buffer_size),
       mutable_limit_(buffer_size_ * 7 / 8),
       memory_used_(0),
       memory_active_(0),
       dummy_size_(0),
-      cache_rep_(nullptr),
-      allow_stall_(allow_stall),
-      stall_active_(false) {
+      cache_rep_(nullptr) {
 #ifndef ROCKSDB_LITE
   if (cache) {
     // Construct the cache key using the pointer to this.
@@ -82,17 +78,6 @@ WriteBufferManager::~WriteBufferManager() {
 #endif  // ROCKSDB_LITE
 }
 
-void WriteBufferManager::ReserveMem(size_t mem) {
-  if (cache_rep_ != nullptr) {
-    ReserveMemWithCache(mem);
-  } else if (enabled()) {
-    memory_used_.fetch_add(mem, std::memory_order_relaxed);
-  }
-  if (enabled()) {
-    memory_active_.fetch_add(mem, std::memory_order_relaxed);
-  }
-}
-
 // Should only be called from write thread
 void WriteBufferManager::ReserveMemWithCache(size_t mem) {
 #ifndef ROCKSDB_LITE
@@ -127,24 +112,6 @@ void WriteBufferManager::ReserveMemWithCache(size_t mem) {
 #endif  // ROCKSDB_LITE
 }
 
-void WriteBufferManager::ScheduleFreeMem(size_t mem) {
-  if (enabled()) {
-    memory_active_.fetch_sub(mem, std::memory_order_relaxed);
-  }
-}
-
-void WriteBufferManager::FreeMem(size_t mem) {
-  if (cache_rep_ != nullptr) {
-    FreeMemWithCache(mem);
-  } else if (enabled()) {
-    memory_used_.fetch_sub(mem, std::memory_order_relaxed);
-  }
-  // Check if stall is active and can be ended.
-  if (allow_stall_) {
-    EndWriteStall();
-  }
-}
-
 void WriteBufferManager::FreeMemWithCache(size_t mem) {
 #ifndef ROCKSDB_LITE
   assert(cache_rep_ != nullptr);
@@ -178,50 +145,4 @@ void WriteBufferManager::FreeMemWithCache(size_t mem) {
   (void)mem;
 #endif  // ROCKSDB_LITE
 }
-
-void WriteBufferManager::BeginWriteStall(StallInterface* wbm_stall) {
-  assert(wbm_stall != nullptr);
-  if (wbm_stall) {
-    std::unique_lock<std::mutex> lock(mu_);
-    queue_.push_back(wbm_stall);
-  }
-  // In case thread enqueue itself and memory got freed in parallel, end the
-  // stall.
-  if (!ShouldStall()) {
-    EndWriteStall();
-  }
-}
-
-// Called when memory is freed in FreeMem.
-void WriteBufferManager::EndWriteStall() {
-  if (enabled() && !IsStallThresholdExceeded()) {
-    {
-      std::unique_lock<std::mutex> lock(mu_);
-      stall_active_.store(false, std::memory_order_relaxed);
-      if (queue_.empty()) {
-        return;
-      }
-    }
-
-    // Get the instances from the list and call WBMStallInterface::Signal to
-    // change the state to running and unblock the DB instances.
-    // Check ShouldStall() incase stall got active by other DBs.
-    while (!ShouldStall() && !queue_.empty()) {
-      std::unique_lock<std::mutex> lock(mu_);
-      StallInterface* wbm_stall = queue_.front();
-      queue_.pop_front();
-      wbm_stall->Signal();
-    }
-  }
-}
-
-void WriteBufferManager::RemoveDBFromQueue(StallInterface* wbm_stall) {
-  assert(wbm_stall != nullptr);
-  if (enabled() && allow_stall_) {
-    std::unique_lock<std::mutex> lock(mu_);
-    queue_.remove(wbm_stall);
-    wbm_stall->Signal();
-  }
-}
-
 }  // namespace ROCKSDB_NAMESPACE

options/cf_options.cc

@@ -38,9 +38,13 @@ namespace ROCKSDB_NAMESPACE {
 // http://en.cppreference.com/w/cpp/concept/StandardLayoutType
 // https://gist.github.com/graphitemaster/494f21190bb2c63c5516
 #ifndef ROCKSDB_LITE
-static ImmutableCFOptions dummy_cf_options;
+static ColumnFamilyOptions dummy_cf_options;
 template <typename T1>
-int offset_of(T1 ImmutableCFOptions::*member) {
+int offset_of(T1 ColumnFamilyOptions::*member) {
+  return int(size_t(&(dummy_cf_options.*member)) - size_t(&dummy_cf_options));
+}
+template <typename T1>
+int offset_of(T1 AdvancedColumnFamilyOptions::*member) {
   return int(size_t(&(dummy_cf_options.*member)) - size_t(&dummy_cf_options));
 }
 
@@ -488,58 +492,57 @@ static std::unordered_map<std::string, OptionTypeInfo>
          {0, OptionType::kBoolean, OptionVerificationType::kDeprecated,
           OptionTypeFlags::kNone}},
         {"inplace_update_support",
-         {offset_of(&ImmutableCFOptions::inplace_update_support),
+         {offset_of(&ColumnFamilyOptions::inplace_update_support),
           OptionType::kBoolean, OptionVerificationType::kNormal,
           OptionTypeFlags::kNone}},
         {"level_compaction_dynamic_level_bytes",
-         {offset_of(&ImmutableCFOptions::level_compaction_dynamic_level_bytes),
+         {offset_of(&ColumnFamilyOptions::level_compaction_dynamic_level_bytes),
           OptionType::kBoolean, OptionVerificationType::kNormal,
           OptionTypeFlags::kNone}},
         {"optimize_filters_for_hits",
-         {offset_of(&ImmutableCFOptions::optimize_filters_for_hits),
+         {offset_of(&ColumnFamilyOptions::optimize_filters_for_hits),
           OptionType::kBoolean, OptionVerificationType::kNormal,
           OptionTypeFlags::kNone}},
         {"force_consistency_checks",
-         {offset_of(&ImmutableCFOptions::force_consistency_checks),
+         {offset_of(&ColumnFamilyOptions::force_consistency_checks),
           OptionType::kBoolean, OptionVerificationType::kNormal,
           OptionTypeFlags::kNone}},
         {"purge_redundant_kvs_while_flush",
-         {offset_of(&ImmutableCFOptions::purge_redundant_kvs_while_flush),
+         {offset_of(&ColumnFamilyOptions::purge_redundant_kvs_while_flush),
           OptionType::kBoolean, OptionVerificationType::kDeprecated,
           OptionTypeFlags::kNone}},
         {"max_mem_compaction_level",
          {0, OptionType::kInt, OptionVerificationType::kDeprecated,
           OptionTypeFlags::kNone}},
         {"max_write_buffer_number_to_maintain",
-         {offset_of(&ImmutableCFOptions::max_write_buffer_number_to_maintain),
+         {offset_of(&ColumnFamilyOptions::max_write_buffer_number_to_maintain),
           OptionType::kInt, OptionVerificationType::kNormal,
           OptionTypeFlags::kNone, 0}},
         {"max_write_buffer_size_to_maintain",
-         {offset_of(&ImmutableCFOptions::max_write_buffer_size_to_maintain),
+         {offset_of(&ColumnFamilyOptions::max_write_buffer_size_to_maintain),
           OptionType::kInt64T, OptionVerificationType::kNormal,
           OptionTypeFlags::kNone}},
         {"min_write_buffer_number_to_merge",
-         {offset_of(&ImmutableCFOptions::min_write_buffer_number_to_merge),
+         {offset_of(&ColumnFamilyOptions::min_write_buffer_number_to_merge),
           OptionType::kInt, OptionVerificationType::kNormal,
           OptionTypeFlags::kNone, 0}},
         {"num_levels",
-         {offset_of(&ImmutableCFOptions::num_levels), OptionType::kInt,
+         {offset_of(&ColumnFamilyOptions::num_levels), OptionType::kInt,
           OptionVerificationType::kNormal, OptionTypeFlags::kNone}},
         {"bloom_locality",
-         {offset_of(&ImmutableCFOptions::bloom_locality), OptionType::kUInt32T,
+         {offset_of(&ColumnFamilyOptions::bloom_locality), OptionType::kUInt32T,
           OptionVerificationType::kNormal, OptionTypeFlags::kNone}},
         {"rate_limit_delay_max_milliseconds",
          {0, OptionType::kUInt, OptionVerificationType::kDeprecated,
           OptionTypeFlags::kNone}},
         {"compression_per_level",
          OptionTypeInfo::Vector<CompressionType>(
-             offset_of(&ImmutableCFOptions::compression_per_level),
+             offset_of(&ColumnFamilyOptions::compression_per_level),
              OptionVerificationType::kNormal, OptionTypeFlags::kNone,
              {0, OptionType::kCompressionType})},
         {"comparator",
-         {offset_of(&ImmutableCFOptions::user_comparator),
-          OptionType::kComparator, OptionVerificationType::kByName,
-          OptionTypeFlags::kCompareLoose,
+         {offset_of(&ColumnFamilyOptions::comparator), OptionType::kComparator,
+          OptionVerificationType::kByName, OptionTypeFlags::kCompareLoose,
           // Parses the string and sets the corresponding comparator
           [](const ConfigOptions& /*opts*/, const std::string& /*name*/,
              const std::string& value, char* addr) {
@@ -555,15 +558,15 @@ static std::unordered_map<std::string, OptionTypeInfo>
           }}},
         {"memtable_insert_with_hint_prefix_extractor",
          {offset_of(
-              &ImmutableCFOptions::memtable_insert_with_hint_prefix_extractor),
+              &ColumnFamilyOptions::memtable_insert_with_hint_prefix_extractor),
           OptionType::kSliceTransform, OptionVerificationType::kByNameAllowNull,
           OptionTypeFlags::kNone}},
         {"memtable_factory",
-         {offset_of(&ImmutableCFOptions::memtable_factory),
+         {offset_of(&ColumnFamilyOptions::memtable_factory),
           OptionType::kMemTableRepFactory, OptionVerificationType::kByName,
           OptionTypeFlags::kNone}},
         {"memtable",
-         {offset_of(&ImmutableCFOptions::memtable_factory),
+         {offset_of(&ColumnFamilyOptions::memtable_factory),
           OptionType::kMemTableRepFactory, OptionVerificationType::kAlias,
           OptionTypeFlags::kNone,
           // Parses the value string and updates the memtable_factory
@@ -579,13 +582,13 @@ static std::unordered_map<std::string, OptionTypeInfo>
             return s;
           }}},
         {"table_factory", OptionTypeInfo::AsCustomSharedPtr<TableFactory>(
-                              offset_of(&ImmutableCFOptions::table_factory),
+                              offset_of(&ColumnFamilyOptions::table_factory),
                               OptionVerificationType::kByName,
                               (OptionTypeFlags::kCompareLoose |
                                OptionTypeFlags::kStringNameOnly |
                                OptionTypeFlags::kDontPrepare))},
         {"block_based_table_factory",
-         {offset_of(&ImmutableCFOptions::table_factory),
+         {offset_of(&ColumnFamilyOptions::table_factory),
           OptionType::kCustomizable, OptionVerificationType::kAlias,
           OptionTypeFlags::kShared | OptionTypeFlags::kCompareLoose,
           // Parses the input value and creates a BlockBasedTableFactory
@@ -617,7 +620,7 @@ static std::unordered_map<std::string, OptionTypeInfo>
             }
           }}},
         {"plain_table_factory",
-         {offset_of(&ImmutableCFOptions::table_factory),
+         {offset_of(&ColumnFamilyOptions::table_factory),
           OptionType::kCustomizable, OptionVerificationType::kAlias,
           OptionTypeFlags::kShared | OptionTypeFlags::kCompareLoose,
           // Parses the input value and creates a PlainTableFactory
@@ -648,15 +651,15 @@ static std::unordered_map<std::string, OptionTypeInfo>
             }
           }}},
         {"compaction_filter",
-         {offset_of(&ImmutableCFOptions::compaction_filter),
+         {offset_of(&ColumnFamilyOptions::compaction_filter),
           OptionType::kCompactionFilter, OptionVerificationType::kByName,
           OptionTypeFlags::kNone}},
         {"compaction_filter_factory",
-         {offset_of(&ImmutableCFOptions::compaction_filter_factory),
+         {offset_of(&ColumnFamilyOptions::compaction_filter_factory),
           OptionType::kCompactionFilterFactory, OptionVerificationType::kByName,
           OptionTypeFlags::kNone}},
         {"merge_operator",
-         {offset_of(&ImmutableCFOptions::merge_operator),
+         {offset_of(&ColumnFamilyOptions::merge_operator),
           OptionType::kMergeOperator,
           OptionVerificationType::kByNameAllowFromNull,
           OptionTypeFlags::kCompareLoose,
@@ -674,11 +677,11 @@ static std::unordered_map<std::string, OptionTypeInfo>
             return Status::OK();
           }}},
         {"compaction_style",
-         {offset_of(&ImmutableCFOptions::compaction_style),
+         {offset_of(&ColumnFamilyOptions::compaction_style),
           OptionType::kCompactionStyle, OptionVerificationType::kNormal,
           OptionTypeFlags::kNone}},
         {"compaction_pri",
-         {offset_of(&ImmutableCFOptions::compaction_pri),
+         {offset_of(&ColumnFamilyOptions::compaction_pri),
           OptionType::kCompactionPri, OptionVerificationType::kNormal,
           OptionTypeFlags::kNone}},
 };
@@ -687,9 +690,10 @@ const std::string OptionsHelper::kCFOptionsName = "ColumnFamilyOptions";
 
 class ConfigurableMutableCFOptions : public Configurable {
  public:
-  explicit ConfigurableMutableCFOptions(const MutableCFOptions& mcf) {
+  ConfigurableMutableCFOptions(const MutableCFOptions& mcf) {
     mutable_ = mcf;
-    RegisterOptions(&mutable_, &cf_mutable_options_type_info);
+    ConfigurableHelper::RegisterOptions(*this, &mutable_,
+                                        &cf_mutable_options_type_info);
   }
 
  protected:
@@ -701,10 +705,12 @@ class ConfigurableCFOptions : public ConfigurableMutableCFOptions {
   ConfigurableCFOptions(const ColumnFamilyOptions& opts,
                         const std::unordered_map<std::string, std::string>* map)
       : ConfigurableMutableCFOptions(MutableCFOptions(opts)),
-        immutable_(ImmutableDBOptions(), opts),
+        immutable_(opts),
         cf_options_(opts),
         opt_map_(map) {
-    RegisterOptions(&immutable_, &cf_immutable_options_type_info);
+    ConfigurableHelper::RegisterOptions(*this, OptionsHelper::kCFOptionsName,
+                                        &immutable_,
+                                        &cf_immutable_options_type_info);
   }
 
  protected:
@@ -768,7 +774,7 @@ class ConfigurableCFOptions : public ConfigurableMutableCFOptions {
   }
 
  private:
-  ImmutableCFOptions immutable_;
+  ColumnFamilyOptions immutable_;
   ColumnFamilyOptions cf_options_;
   const std::unordered_map<std::string, std::string>* opt_map_;
 };
@@ -786,22 +792,18 @@ std::unique_ptr<Configurable> CFOptionsAsConfigurable(
 }
 #endif  // ROCKSDB_LITE
 
-ImmutableCFOptions::ImmutableCFOptions() : ImmutableCFOptions(Options()) {}
-
 ImmutableCFOptions::ImmutableCFOptions(const Options& options)
     : ImmutableCFOptions(ImmutableDBOptions(options), options) {}
 
 ImmutableCFOptions::ImmutableCFOptions(const ImmutableDBOptions& db_options,
                                        const ColumnFamilyOptions& cf_options)
-    : logger(db_options.info_log),
-      stats(db_options.statistics),
-      compaction_style(cf_options.compaction_style),
+    : compaction_style(cf_options.compaction_style),
       compaction_pri(cf_options.compaction_pri),
       user_comparator(cf_options.comparator),
       internal_comparator(InternalKeyComparator(cf_options.comparator)),
-      merge_operator(cf_options.merge_operator),
+      merge_operator(cf_options.merge_operator.get()),
       compaction_filter(cf_options.compaction_filter),
-      compaction_filter_factory(cf_options.compaction_filter_factory),
+      compaction_filter_factory(cf_options.compaction_filter_factory.get()),
       min_write_buffer_number_to_merge(
           cf_options.min_write_buffer_number_to_merge),
       max_write_buffer_number_to_maintain(
@@ -810,9 +812,9 @@ ImmutableCFOptions::ImmutableCFOptions(const ImmutableDBOptions& db_options,
           cf_options.max_write_buffer_size_to_maintain),
       inplace_update_support(cf_options.inplace_update_support),
       inplace_callback(cf_options.inplace_callback),
-      info_log(logger.get()),
-      statistics(stats.get()),
-      rate_limiter(db_options.rate_limiter),
+      info_log(db_options.info_log.get()),
+      statistics(db_options.statistics.get()),
+      rate_limiter(db_options.rate_limiter.get()),
       info_log_level(db_options.info_log_level),
       env(db_options.env),
       fs(db_options.fs.get()),
@@ -820,8 +822,8 @@ ImmutableCFOptions::ImmutableCFOptions(const ImmutableDBOptions& db_options,
       allow_mmap_reads(db_options.allow_mmap_reads),
       allow_mmap_writes(db_options.allow_mmap_writes),
       db_paths(db_options.db_paths),
-      memtable_factory(cf_options.memtable_factory),
-      table_factory(cf_options.table_factory),
+      memtable_factory(cf_options.memtable_factory.get()),
+      table_factory(cf_options.table_factory.get()),
       table_properties_collector_factories(
           cf_options.table_properties_collector_factories),
       advise_random_on_open(db_options.advise_random_on_open),
@@ -844,10 +846,10 @@ ImmutableCFOptions::ImmutableCFOptions(const ImmutableDBOptions& db_options,
       listeners(db_options.listeners),
       row_cache(db_options.row_cache),
       memtable_insert_with_hint_prefix_extractor(
-          cf_options.memtable_insert_with_hint_prefix_extractor),
+          cf_options.memtable_insert_with_hint_prefix_extractor.get()),
       cf_paths(cf_options.cf_paths),
       compaction_thread_limiter(cf_options.compaction_thread_limiter),
-      file_checksum_gen_factory(db_options.file_checksum_gen_factory),
+      file_checksum_gen_factory(db_options.file_checksum_gen_factory.get()),
       sst_partitioner_factory(cf_options.sst_partitioner_factory),
       allow_data_in_errors(db_options.allow_data_in_errors),
       db_host_id(db_options.db_host_id),

options/cf_options.h

@@ -20,12 +20,7 @@ namespace ROCKSDB_NAMESPACE {
 // of DB. Raw pointers defined in this struct do not have ownership to the data
 // they point to. Options contains std::shared_ptr to these data.
 struct ImmutableCFOptions {
- private:
-  std::shared_ptr<Logger> logger;     // ImmutableDBOptions
-  std::shared_ptr<Statistics> stats;  // ImmutableDBOptions
- public:
   static const char* kName() { return "ImmutableCFOptions"; }
-  explicit ImmutableCFOptions();
   explicit ImmutableCFOptions(const Options& options);
 
   ImmutableCFOptions(const ImmutableDBOptions& db_options,
@@ -36,13 +31,13 @@ struct ImmutableCFOptions {
   CompactionPri compaction_pri;
 
   const Comparator* user_comparator;
-  InternalKeyComparator internal_comparator;  // Only in Immutable
+  InternalKeyComparator internal_comparator;
 
-  std::shared_ptr<MergeOperator> merge_operator;
+  MergeOperator* merge_operator;
 
   const CompactionFilter* compaction_filter;
 
-  std::shared_ptr<CompactionFilterFactory> compaction_filter_factory;
+  CompactionFilterFactory* compaction_filter_factory;
 
   int min_write_buffer_number_to_merge;
 
@@ -57,36 +52,36 @@ struct ImmutableCFOptions {
                                    Slice delta_value,
                                    std::string* merged_value);
 
-  Logger* info_log;  // ImmutableDBOptions
+  Logger* info_log;
 
-  Statistics* statistics;  // ImmutableDBOptions
+  Statistics* statistics;
 
-  std::shared_ptr<RateLimiter> rate_limiter;  // ImmutableDBOptions
+  RateLimiter* rate_limiter;
 
-  InfoLogLevel info_log_level;  // ImmutableDBOptions
+  InfoLogLevel info_log_level;
 
-  Env* env;  // ImmutableDBOptions
+  Env* env;
 
-  FileSystem* fs;  // ImmutableDBOptions
+  FileSystem* fs;
 
-  SystemClock* clock;  // ImmutableDBOptions
+  SystemClock* clock;
 
   // Allow the OS to mmap file for reading sst tables. Default: false
-  bool allow_mmap_reads;  // ImmutableDBOptions
+  bool allow_mmap_reads;
 
   // Allow the OS to mmap file for writing. Default: false
-  bool allow_mmap_writes;  // ImmutableDBOptions
+  bool allow_mmap_writes;
 
-  std::vector<DbPath> db_paths;  // ImmutableDBOptions
+  std::vector<DbPath> db_paths;
 
-  std::shared_ptr<MemTableRepFactory> memtable_factory;
+  MemTableRepFactory* memtable_factory;
 
-  std::shared_ptr<TableFactory> table_factory;
+  TableFactory* table_factory;
 
   Options::TablePropertiesCollectorFactories
       table_properties_collector_factories;
 
-  bool advise_random_on_open;  // ImmutableDBOptions
+  bool advise_random_on_open;
 
   // This options is required by PlainTableReader. May need to move it
   // to PlainTableOptions just like bloom_bits_per_key
@@ -94,15 +89,15 @@ struct ImmutableCFOptions {
 
   bool purge_redundant_kvs_while_flush;
 
-  bool use_fsync;  // ImmutableDBOptions
+  bool use_fsync;
 
   std::vector<CompressionType> compression_per_level;
 
   bool level_compaction_dynamic_level_bytes;
 
-  Options::AccessHint access_hint_on_compaction_start;  // ImmutableDBOptions
+  Options::AccessHint access_hint_on_compaction_start;
 
-  bool new_table_reader_for_compaction_inputs;  // ImmutableDBOptions
+  bool new_table_reader_for_compaction_inputs;
 
   int num_levels;
 
@@ -110,33 +105,31 @@ struct ImmutableCFOptions {
 
   bool force_consistency_checks;
 
-  bool allow_ingest_behind;  // ImmutableDBOptions
+  bool allow_ingest_behind;
 
-  bool preserve_deletes;  // ImmutableDBOptions
+  bool preserve_deletes;
 
   // A vector of EventListeners which callback functions will be called
   // when specific RocksDB event happens.
-  std::vector<std::shared_ptr<EventListener>> listeners;  // ImmutableDBOptions
+  std::vector<std::shared_ptr<EventListener>> listeners;
 
-  std::shared_ptr<Cache> row_cache;  // ImmutableDBOptions
+  std::shared_ptr<Cache> row_cache;
 
-  std::shared_ptr<const SliceTransform>
-      memtable_insert_with_hint_prefix_extractor;
+  const SliceTransform* memtable_insert_with_hint_prefix_extractor;
 
   std::vector<DbPath> cf_paths;
 
   std::shared_ptr<ConcurrentTaskLimiter> compaction_thread_limiter;
 
-  std::shared_ptr<FileChecksumGenFactory>
-      file_checksum_gen_factory;  // ImmutableDBOptions
+  FileChecksumGenFactory* file_checksum_gen_factory;
 
   std::shared_ptr<SstPartitionerFactory> sst_partitioner_factory;
 
-  bool allow_data_in_errors;  // ImmutableDBOptions
+  bool allow_data_in_errors;
 
-  std::string db_host_id;  // ImmutableDBOptions
+  std::string db_host_id;
 
-  FileTypeSet checksum_handoff_file_types;  // ImmutableDBOptions
+  FileTypeSet checksum_handoff_file_types;
 };
 
 struct MutableCFOptions {

options/configurable.cc

@@ -17,10 +17,10 @@
 
 namespace ROCKSDB_NAMESPACE {
 
-void Configurable::RegisterOptions(
-    const std::string& name, void* opt_ptr,
+void ConfigurableHelper::RegisterOptions(
+    Configurable& configurable, const std::string& name, void* opt_ptr,
     const std::unordered_map<std::string, OptionTypeInfo>* type_map) {
-  RegisteredOptions opts;
+  Configurable::RegisteredOptions opts;
   opts.name = name;
 #ifndef ROCKSDB_LITE
   opts.type_map = type_map;
@@ -28,7 +28,7 @@ void Configurable::RegisterOptions(
   (void)type_map;
 #endif  // ROCKSDB_LITE
   opts.opt_ptr = opt_ptr;
-  options_.emplace_back(opts);
+  configurable.options_.emplace_back(opts);
 }
 
 //*************************************************************************

options/configurable_helper.h

@@ -22,6 +22,35 @@ class ConfigurableHelper {
  public:
   constexpr static const char* kIdPropName = "id";
   constexpr static const char* kIdPropSuffix = ".id";
+  // Registers the input name with the options and associated map.
+  // When classes register their options in this manner, most of the
+  // functionality (excluding unknown options and validate/prepare) is
+  // implemented by the base class.
+  //
+  // This method should be called in the class constructor to register the
+  // option set for this object.  For example, to register the options
+  // associated with the BlockBasedTableFactory, the constructor calls this
+  // method passing in:
+  // - the name of the options ("BlockBasedTableOptions");
+  // - the options object (the BlockBasedTableOptions object for this object;
+  // - the options type map for the BlockBasedTableOptions.
+  // This registration allows the Configurable class to process the option
+  // values associated with the BlockBasedTableOptions without further code in
+  // the derived class.
+  //
+  // @param name    The name of this set of options (@see GetOptionsPtr)
+  // @param opt_ptr Pointer to the options to associate with this name
+  // @param opt_map Options map that controls how this option is configured.
+  template <typename T>
+  static void RegisterOptions(
+      Configurable& configurable, T* opt_ptr,
+      const std::unordered_map<std::string, OptionTypeInfo>* opt_map) {
+    RegisterOptions(configurable, T::kName(), opt_ptr, opt_map);
+  }
+  static void RegisterOptions(
+      Configurable& configurable, const std::string& name, void* opt_ptr,
+      const std::unordered_map<std::string, OptionTypeInfo>* opt_map);
+
   // Configures the input Configurable object based on the parameters.
   // On successful completion, the Configurable is updated with the settings
   // from the opt_map.

options/configurable_test.cc

@@ -78,15 +78,18 @@ class SimpleConfigurable : public TestConfigurable<Configurable> {
       : TestConfigurable(name, mode, map) {
     if ((mode & TestConfigMode::kUniqueMode) != 0) {
       unique_.reset(SimpleConfigurable::Create("Unique" + name_));
-      RegisterOptions(name_ + "Unique", &unique_, &unique_option_info);
+      ConfigurableHelper::RegisterOptions(*this, name_ + "Unique", &unique_,
+                                          &unique_option_info);
     }
     if ((mode & TestConfigMode::kSharedMode) != 0) {
       shared_.reset(SimpleConfigurable::Create("Shared" + name_));
-      RegisterOptions(name_ + "Shared", &shared_, &shared_option_info);
+      ConfigurableHelper::RegisterOptions(*this, name_ + "Shared", &shared_,
+                                          &shared_option_info);
     }
     if ((mode & TestConfigMode::kRawPtrMode) != 0) {
       pointer_ = SimpleConfigurable::Create("Pointer" + name_);
-      RegisterOptions(name_ + "Pointer", &pointer_, &pointer_option_info);
+      ConfigurableHelper::RegisterOptions(*this, name_ + "Pointer", &pointer_,
+                                          &pointer_option_info);
     }
   }
 
@@ -247,15 +250,19 @@ class ValidatedConfigurable : public SimpleConfigurable {
       : SimpleConfigurable(name, TestConfigMode::kDefaultMode),
         validated(false),
         prepared(0) {
-    RegisterOptions("Validated", &validated, &validated_option_info);
-    RegisterOptions("Prepared", &prepared, &prepared_option_info);
+    ConfigurableHelper::RegisterOptions(*this, "Validated", &validated,
+                                        &validated_option_info);
+    ConfigurableHelper::RegisterOptions(*this, "Prepared", &prepared,
+                                        &prepared_option_info);
     if ((mode & TestConfigMode::kUniqueMode) != 0) {
       unique_.reset(new ValidatedConfigurable(
           "Unique" + name_, TestConfigMode::kDefaultMode, false));
       if (dont_prepare) {
-        RegisterOptions(name_ + "Unique", &unique_, &dont_prepare_option_info);
+        ConfigurableHelper::RegisterOptions(*this, name_ + "Unique", &unique_,
+                                            &dont_prepare_option_info);
       } else {
-        RegisterOptions(name_ + "Unique", &unique_, &unique_option_info);
+        ConfigurableHelper::RegisterOptions(*this, name_ + "Unique", &unique_,
+                                            &unique_option_info);
       }
     }
   }
@@ -346,8 +353,10 @@ TEST_F(ConfigurableTest, MutableOptionsTest) {
         : SimpleConfigurable("mutable", TestConfigMode::kDefaultMode |
                                             TestConfigMode::kUniqueMode |
                                             TestConfigMode::kSharedMode) {
-      RegisterOptions("struct", &options_, &struct_option_info);
-      RegisterOptions("imm", &options_, &imm_option_info);
+      ConfigurableHelper::RegisterOptions(*this, "struct", &options_,
+                                          &struct_option_info);
+      ConfigurableHelper::RegisterOptions(*this, "imm", &options_,
+                                          &imm_option_info);
     }
   };
   MutableConfigurable mc;

options/configurable_test.h

@@ -112,10 +112,11 @@ class TestConfigurable : public Configurable {
       : name_(name), pointer_(nullptr) {
     prefix_ = "test." + name + ".";
     if ((mode & TestConfigMode::kSimpleMode) != 0) {
-      RegisterOptions(name_, &options_, map);
+      ConfigurableHelper::RegisterOptions(*this, name_, &options_, map);
     }
     if ((mode & TestConfigMode::kEnumMode) != 0) {
-      RegisterOptions(name_ + "Enum", &options_, &enum_option_info);
+      ConfigurableHelper::RegisterOptions(*this, name_ + "Enum", &options_,
+                                          &enum_option_info);
     }
   }
 

options/customizable_helper.h

@@ -9,6 +9,7 @@
 #include <unordered_map>
 
 #include "options/configurable_helper.h"
+#include "options/options_helper.h"
 #include "rocksdb/convenience.h"
 #include "rocksdb/customizable.h"
 #include "rocksdb/status.h"

options/customizable_test.cc

@@ -98,9 +98,8 @@ static std::unordered_map<std::string, OptionTypeInfo> a_option_info = {
 };
 class ACustomizable : public TestCustomizable {
  public:
-  explicit ACustomizable(const std::string& id)
-      : TestCustomizable("A"), id_(id) {
-    RegisterOptions("A", &opts_, &a_option_info);
+  ACustomizable(const std::string& id) : TestCustomizable("A"), id_(id) {
+    ConfigurableHelper::RegisterOptions(*this, "A", &opts_, &a_option_info);
   }
   std::string GetId() const override { return id_; }
   static const char* kClassName() { return "A"; }
@@ -142,8 +141,8 @@ static std::unordered_map<std::string, OptionTypeInfo> b_option_info = {
 class BCustomizable : public TestCustomizable {
  private:
  public:
-  explicit BCustomizable(const std::string& name) : TestCustomizable(name) {
-    RegisterOptions(name, &opts_, &b_option_info);
+  BCustomizable(const std::string& name) : TestCustomizable(name) {
+    ConfigurableHelper::RegisterOptions(*this, name, &opts_, &b_option_info);
   }
   static const char* kClassName() { return "B"; }
 
@@ -247,12 +246,13 @@ class SimpleConfigurable : public Configurable {
 
  public:
   SimpleConfigurable() {
-    RegisterOptions("simple", &simple_, &simple_option_info);
+    ConfigurableHelper::RegisterOptions(*this, "simple", &simple_,
+                                        &simple_option_info);
   }
 
-  explicit SimpleConfigurable(
+  SimpleConfigurable(
       const std::unordered_map<std::string, OptionTypeInfo>* map) {
-    RegisterOptions("simple", &simple_, map);
+    ConfigurableHelper::RegisterOptions(*this, "simple", &simple_, map);
   }
 
   bool IsPrepared() const override {
@@ -509,7 +509,8 @@ class ShallowCustomizable : public Customizable {
  public:
   ShallowCustomizable() {
     inner_ = std::make_shared<ACustomizable>("a");
-    RegisterOptions("inner", &inner_, &inner_option_info);
+    ConfigurableHelper::RegisterOptions(*this, "inner", &inner_,
+                                        &inner_option_info);
   };
   static const char* kClassName() { return "shallow"; }
   const char* Name() const override { return kClassName(); }
@@ -640,8 +641,10 @@ TEST_F(CustomizableTest, MutableOptionsTest) {
 
    public:
     MutableCustomizable() {
-      RegisterOptions("mutable", &mutable_, &mutable_option_info);
-      RegisterOptions("immutable", &immutable_, &immutable_option_info);
+      ConfigurableHelper::RegisterOptions(*this, "mutable", &mutable_,
+                                          &mutable_option_info);
+      ConfigurableHelper::RegisterOptions(*this, "immutable", &immutable_,
+                                          &immutable_option_info);
     }
     const char* Name() const override { return "MutableCustomizable"; }
   };

options/db_options.cc

@@ -272,11 +272,11 @@ static std::unordered_map<std::string, OptionTypeInfo>
          {offsetof(struct ImmutableDBOptions, wal_dir), OptionType::kString,
           OptionVerificationType::kNormal, OptionTypeFlags::kNone}},
         {"WAL_size_limit_MB",
-         {offsetof(struct ImmutableDBOptions, WAL_size_limit_MB),
+         {offsetof(struct ImmutableDBOptions, wal_size_limit_mb),
           OptionType::kUInt64T, OptionVerificationType::kNormal,
           OptionTypeFlags::kNone}},
         {"WAL_ttl_seconds",
-         {offsetof(struct ImmutableDBOptions, WAL_ttl_seconds),
+         {offsetof(struct ImmutableDBOptions, wal_ttl_seconds),
           OptionType::kUInt64T, OptionVerificationType::kNormal,
           OptionTypeFlags::kNone}},
         {"max_manifest_file_size",
@@ -435,9 +435,10 @@ const std::string OptionsHelper::kDBOptionsName = "DBOptions";
 
 class MutableDBConfigurable : public Configurable {
  public:
-  explicit MutableDBConfigurable(const MutableDBOptions& mdb) {
+  MutableDBConfigurable(const MutableDBOptions& mdb) {
     mutable_ = mdb;
-    RegisterOptions(&mutable_, &db_mutable_options_type_info);
+    ConfigurableHelper::RegisterOptions(*this, &mutable_,
+                                        &db_mutable_options_type_info);
   }
 
  protected:
@@ -446,7 +447,7 @@ class MutableDBConfigurable : public Configurable {
 
 class DBOptionsConfigurable : public MutableDBConfigurable {
  public:
-  explicit DBOptionsConfigurable(const DBOptions& opts)
+  DBOptionsConfigurable(const DBOptions& opts)
       : MutableDBConfigurable(MutableDBOptions(opts)), db_options_(opts) {
     // The ImmutableDBOptions currently requires the env to be non-null.  Make
     // sure it is
@@ -457,7 +458,8 @@ class DBOptionsConfigurable : public MutableDBConfigurable {
       copy.env = Env::Default();
       immutable_ = ImmutableDBOptions(copy);
     }
-    RegisterOptions(&immutable_, &db_immutable_options_type_info);
+    ConfigurableHelper::RegisterOptions(*this, &immutable_,
+                                        &db_immutable_options_type_info);
   }
 
  protected:
@@ -507,6 +509,7 @@ ImmutableDBOptions::ImmutableDBOptions(const DBOptions& options)
       track_and_verify_wals_in_manifest(
           options.track_and_verify_wals_in_manifest),
       env(options.env),
+      fs(options.env->GetFileSystem()),
       rate_limiter(options.rate_limiter),
       sst_file_manager(options.sst_file_manager),
       info_log(options.info_log),
@@ -523,8 +526,8 @@ ImmutableDBOptions::ImmutableDBOptions(const DBOptions& options)
       recycle_log_file_num(options.recycle_log_file_num),
       max_manifest_file_size(options.max_manifest_file_size),
       table_cache_numshardbits(options.table_cache_numshardbits),
-      WAL_ttl_seconds(options.WAL_ttl_seconds),
-      WAL_size_limit_MB(options.WAL_size_limit_MB),
+      wal_ttl_seconds(options.WAL_ttl_seconds),
+      wal_size_limit_mb(options.WAL_size_limit_MB),
       max_write_batch_group_size_bytes(
           options.max_write_batch_group_size_bytes),
       manifest_preallocation_size(options.manifest_preallocation_size),
@@ -580,7 +583,6 @@ ImmutableDBOptions::ImmutableDBOptions(const DBOptions& options)
       allow_data_in_errors(options.allow_data_in_errors),
       db_host_id(options.db_host_id),
       checksum_handoff_file_types(options.checksum_handoff_file_types) {
-  fs = env->GetFileSystem();
   if (env != nullptr) {
     clock = env->GetSystemClock().get();
   } else {
@@ -648,10 +650,10 @@ void ImmutableDBOptions::Dump(Logger* log) const {
                    table_cache_numshardbits);
   ROCKS_LOG_HEADER(log,
                    "                        Options.WAL_ttl_seconds: %" PRIu64,
-                   WAL_ttl_seconds);
+                   wal_ttl_seconds);
   ROCKS_LOG_HEADER(log,
                    "                      Options.WAL_size_limit_MB: %" PRIu64,
-                   WAL_size_limit_MB);
+                   wal_size_limit_mb);
   ROCKS_LOG_HEADER(log,
                    "                       "
                    "Options.max_write_batch_group_size_bytes: %" PRIu64,

options/db_options.h

@@ -26,6 +26,8 @@ struct ImmutableDBOptions {
   bool paranoid_checks;
   bool track_and_verify_wals_in_manifest;
   Env* env;
+  std::shared_ptr<FileSystem> fs;
+  SystemClock* clock;
   std::shared_ptr<RateLimiter> rate_limiter;
   std::shared_ptr<SstFileManager> sst_file_manager;
   std::shared_ptr<Logger> info_log;
@@ -42,8 +44,8 @@ struct ImmutableDBOptions {
   size_t recycle_log_file_num;
   uint64_t max_manifest_file_size;
   int table_cache_numshardbits;
-  uint64_t WAL_ttl_seconds;
-  uint64_t WAL_size_limit_MB;
+  uint64_t wal_ttl_seconds;
+  uint64_t wal_size_limit_mb;
   uint64_t max_write_batch_group_size_bytes;
   size_t manifest_preallocation_size;
   bool allow_mmap_reads;
@@ -94,9 +96,6 @@ struct ImmutableDBOptions {
   bool allow_data_in_errors;
   std::string db_host_id;
   FileTypeSet checksum_handoff_file_types;
-  // Convenience/Helper objects that are not part of the base DBOptions
-  std::shared_ptr<FileSystem> fs;
-  SystemClock* clock;
 };
 
 struct MutableDBOptions {

options/options_helper.cc

@@ -86,8 +86,8 @@ DBOptions BuildDBOptions(const ImmutableDBOptions& immutable_db_options,
   options.max_manifest_file_size = immutable_db_options.max_manifest_file_size;
   options.table_cache_numshardbits =
       immutable_db_options.table_cache_numshardbits;
-  options.WAL_ttl_seconds = immutable_db_options.WAL_ttl_seconds;
-  options.WAL_size_limit_MB = immutable_db_options.WAL_size_limit_MB;
+  options.WAL_ttl_seconds = immutable_db_options.wal_ttl_seconds;
+  options.WAL_size_limit_MB = immutable_db_options.wal_size_limit_mb;
   options.manifest_preallocation_size =
       immutable_db_options.manifest_preallocation_size;
   options.allow_mmap_reads = immutable_db_options.allow_mmap_reads;
@@ -257,111 +257,6 @@ ColumnFamilyOptions BuildColumnFamilyOptions(
 
   return cf_opts;
 }
-ColumnFamilyOptions BuildColumnFamilyOptions(const ImmutableCFOptions& ioptions,
-                                             const MutableCFOptions& moptions) {
-  ColumnFamilyOptions cf_opts;
-
-  // Memtable related options
-  cf_opts.write_buffer_size = moptions.write_buffer_size;
-  cf_opts.max_write_buffer_number = moptions.max_write_buffer_number;
-  cf_opts.arena_block_size = moptions.arena_block_size;
-  cf_opts.memtable_prefix_bloom_size_ratio =
-      moptions.memtable_prefix_bloom_size_ratio;
-  cf_opts.memtable_whole_key_filtering = moptions.memtable_whole_key_filtering;
-  cf_opts.memtable_huge_page_size = moptions.memtable_huge_page_size;
-  cf_opts.max_successive_merges = moptions.max_successive_merges;
-  cf_opts.inplace_update_num_locks = moptions.inplace_update_num_locks;
-  cf_opts.prefix_extractor = moptions.prefix_extractor;
-
-  // Compaction related options
-  cf_opts.disable_auto_compactions = moptions.disable_auto_compactions;
-  cf_opts.soft_pending_compaction_bytes_limit =
-      moptions.soft_pending_compaction_bytes_limit;
-  cf_opts.hard_pending_compaction_bytes_limit =
-      moptions.hard_pending_compaction_bytes_limit;
-  cf_opts.level0_file_num_compaction_trigger =
-      moptions.level0_file_num_compaction_trigger;
-  cf_opts.level0_slowdown_writes_trigger =
-      moptions.level0_slowdown_writes_trigger;
-  cf_opts.level0_stop_writes_trigger = moptions.level0_stop_writes_trigger;
-  cf_opts.max_compaction_bytes = moptions.max_compaction_bytes;
-  cf_opts.target_file_size_base = moptions.target_file_size_base;
-  cf_opts.target_file_size_multiplier = moptions.target_file_size_multiplier;
-  cf_opts.max_bytes_for_level_base = moptions.max_bytes_for_level_base;
-  cf_opts.max_bytes_for_level_multiplier =
-      moptions.max_bytes_for_level_multiplier;
-  cf_opts.ttl = moptions.ttl;
-  cf_opts.periodic_compaction_seconds = moptions.periodic_compaction_seconds;
-
-  cf_opts.max_bytes_for_level_multiplier_additional.clear();
-  for (auto value : moptions.max_bytes_for_level_multiplier_additional) {
-    cf_opts.max_bytes_for_level_multiplier_additional.emplace_back(value);
-  }
-
-  cf_opts.compaction_options_fifo = moptions.compaction_options_fifo;
-  cf_opts.compaction_options_universal = moptions.compaction_options_universal;
-
-  // Blob file related options
-  cf_opts.enable_blob_files = moptions.enable_blob_files;
-  cf_opts.min_blob_size = moptions.min_blob_size;
-  cf_opts.blob_file_size = moptions.blob_file_size;
-  cf_opts.blob_compression_type = moptions.blob_compression_type;
-  cf_opts.enable_blob_garbage_collection =
-      moptions.enable_blob_garbage_collection;
-  cf_opts.blob_garbage_collection_age_cutoff =
-      moptions.blob_garbage_collection_age_cutoff;
-
-  // Misc options
-  cf_opts.max_sequential_skip_in_iterations =
-      moptions.max_sequential_skip_in_iterations;
-  cf_opts.check_flush_compaction_key_order =
-      moptions.check_flush_compaction_key_order;
-  cf_opts.paranoid_file_checks = moptions.paranoid_file_checks;
-  cf_opts.report_bg_io_stats = moptions.report_bg_io_stats;
-  cf_opts.compression = moptions.compression;
-  cf_opts.compression_opts = moptions.compression_opts;
-  cf_opts.bottommost_compression = moptions.bottommost_compression;
-  cf_opts.bottommost_compression_opts = moptions.bottommost_compression_opts;
-  cf_opts.sample_for_compression = moptions.sample_for_compression;
-
-  cf_opts.compaction_style = ioptions.compaction_style;
-  cf_opts.compaction_pri = ioptions.compaction_pri;
-  cf_opts.comparator = ioptions.user_comparator;
-  cf_opts.merge_operator = ioptions.merge_operator;
-  cf_opts.compaction_filter = ioptions.compaction_filter;
-  cf_opts.compaction_filter_factory = ioptions.compaction_filter_factory;
-  cf_opts.min_write_buffer_number_to_merge =
-      ioptions.min_write_buffer_number_to_merge;
-  cf_opts.max_write_buffer_number_to_maintain =
-      ioptions.max_write_buffer_number_to_maintain;
-  cf_opts.max_write_buffer_size_to_maintain =
-      ioptions.max_write_buffer_size_to_maintain;
-  cf_opts.inplace_update_support = ioptions.inplace_update_support;
-  cf_opts.inplace_callback = ioptions.inplace_callback;
-  cf_opts.memtable_factory = ioptions.memtable_factory;
-  cf_opts.table_factory = ioptions.table_factory;
-  cf_opts.table_properties_collector_factories =
-      ioptions.table_properties_collector_factories;
-  cf_opts.bloom_locality = ioptions.bloom_locality;
-  cf_opts.purge_redundant_kvs_while_flush =
-      ioptions.purge_redundant_kvs_while_flush;
-  cf_opts.compression_per_level = ioptions.compression_per_level;
-  cf_opts.level_compaction_dynamic_level_bytes =
-      ioptions.level_compaction_dynamic_level_bytes;
-  cf_opts.num_levels = ioptions.num_levels;
-  cf_opts.optimize_filters_for_hits = ioptions.optimize_filters_for_hits;
-  cf_opts.force_consistency_checks = ioptions.force_consistency_checks;
-  cf_opts.memtable_insert_with_hint_prefix_extractor =
-      ioptions.memtable_insert_with_hint_prefix_extractor;
-  cf_opts.cf_paths = ioptions.cf_paths;
-  cf_opts.compaction_thread_limiter = ioptions.compaction_thread_limiter;
-  cf_opts.sst_partitioner_factory = ioptions.sst_partitioner_factory;
-
-  // TODO(yhchiang): find some way to handle the following derived options
-  // * max_file_size
-
-  return cf_opts;
-}
 
 std::map<CompactionStyle, std::string>
     OptionsHelper::compaction_style_to_string = {

options/options_helper.h

@@ -18,7 +18,6 @@ namespace ROCKSDB_NAMESPACE {
 struct ColumnFamilyOptions;
 struct ConfigOptions;
 struct DBOptions;
-struct ImmutableCFOptions;
 struct ImmutableDBOptions;
 struct MutableDBOptions;
 struct MutableCFOptions;
@@ -38,8 +37,6 @@ DBOptions BuildDBOptions(const ImmutableDBOptions& immutable_db_options,
 ColumnFamilyOptions BuildColumnFamilyOptions(
     const ColumnFamilyOptions& ioptions,
     const MutableCFOptions& mutable_cf_options);
-ColumnFamilyOptions BuildColumnFamilyOptions(const ImmutableCFOptions& ioptions,
-                                             const MutableCFOptions& moptions);
 
 #ifndef ROCKSDB_LITE
 std::unique_ptr<Configurable> DBOptionsAsConfigurable(

options/options_test.cc

@@ -1298,36 +1298,6 @@ TEST_F(OptionsTest, OptionsComposeDecompose) {
   delete new_cf_opts.compaction_filter;
 }
 
-TEST_F(OptionsTest, DBOptionsComposeImmutable) {
-  // Build a DBOptions from an Immutable/Mutable one and verify that
-  // we get same constituent options.
-  ConfigOptions config_options;
-  Random rnd(301);
-  DBOptions base_opts, new_opts;
-  test::RandomInitDBOptions(&base_opts, &rnd);
-  MutableDBOptions m_opts(base_opts);
-  ImmutableDBOptions i_opts(base_opts);
-  new_opts = BuildDBOptions(i_opts, m_opts);
-  ASSERT_OK(RocksDBOptionsParser::VerifyDBOptions(config_options, base_opts,
-                                                  new_opts));
-}
-
-TEST_F(OptionsTest, CFOptionsComposeImmutable) {
-  // Build a DBOptions from an Immutable/Mutable one and verify that
-  // we get same constituent options.
-  ConfigOptions config_options;
-  Random rnd(301);
-  ColumnFamilyOptions base_opts, new_opts;
-  DBOptions dummy;  // Needed to create ImmutableCFOptions
-  test::RandomInitCFOptions(&base_opts, dummy, &rnd);
-  MutableCFOptions m_opts(base_opts);
-  ImmutableCFOptions i_opts(ImmutableDBOptions(dummy), base_opts);
-  new_opts = BuildColumnFamilyOptions(i_opts, m_opts);
-  ASSERT_OK(RocksDBOptionsParser::VerifyCFOptions(config_options, base_opts,
-                                                  new_opts));
-  delete new_opts.compaction_filter;
-}
-
 TEST_F(OptionsTest, ColumnFamilyOptionsSerialization) {
   Options options;
   ColumnFamilyOptions base_opt, new_opt;

port/win/env_win.cc

@@ -9,6 +9,8 @@
 
 #if defined(OS_WIN)
 
+#include "port/win/env_win.h"
+
 #include <direct.h>  // _rmdir, _mkdir, _getcwd
 #include <errno.h>
 #include <io.h>   // _access
@@ -27,7 +29,6 @@
 #include "monitoring/thread_status_util.h"
 #include "port/port.h"
 #include "port/port_dirent.h"
-#include "port/win/env_win.h"
 #include "port/win/io_win.h"
 #include "port/win/win_logger.h"
 #include "port/win/win_thread.h"
@@ -88,8 +89,9 @@ WinClock::WinClock()
 
   HMODULE module = GetModuleHandle("kernel32.dll");
   if (module != NULL) {
-    GetSystemTimePreciseAsFileTime_ = (FnGetSystemTimePreciseAsFileTime)(
-        void*)GetProcAddress(module, "GetSystemTimePreciseAsFileTime");
+    GetSystemTimePreciseAsFileTime_ =
+        (FnGetSystemTimePreciseAsFileTime)GetProcAddress(
+            module, "GetSystemTimePreciseAsFileTime");
   }
 }
 

src.mk

@@ -319,9 +319,6 @@ MOCK_LIB_SOURCES =                                              \
 BENCH_LIB_SOURCES =                                             \
   tools/db_bench_tool.cc                                        \
 
-CACHE_BENCH_LIB_SOURCES =					\
-  cache/cache_bench_tool.cc                                     \
-
 STRESS_LIB_SOURCES =                                            \
   db_stress_tool/batched_ops_stress.cc                         \
   db_stress_tool/cf_consistency_stress.cc                      \
@@ -427,7 +424,6 @@ TEST_MAIN_SOURCES =                                                     \
   db/db_universal_compaction_test.cc                                    \
   db/db_wal_test.cc                                                     \
   db/db_with_timestamp_compaction_test.cc                               \
-  db/db_write_buffer_manager_test.cc                                    \
   db/db_write_test.cc                                                   \
   db/dbformat_test.cc                                                   \
   db/deletefile_test.cc                                                 \

table/block_based/block_based_table_builder.cc

@@ -254,10 +254,13 @@ struct BlockBasedTableBuilder::Rep {
   std::atomic<uint64_t> offset;
   size_t alignment;
   BlockBuilder data_block;
-  // Buffers uncompressed data blocks to replay later. Needed when
+  // Buffers uncompressed data blocks and keys to replay later. Needed when
   // compression dictionary is enabled so we can finalize the dictionary before
   // compressing any data blocks.
-  std::vector<std::string> data_block_buffers;
+  // TODO(ajkr): ideally we don't buffer all keys and all uncompressed data
+  // blocks as it's redundant, but it's easier to implement for now.
+  std::vector<std::pair<std::string, std::vector<std::string>>>
+      data_block_and_keys_buffers;
   BlockBuilder range_del_block;
 
   InternalKeySliceTransform internal_prefix_transform;
@@ -308,7 +311,8 @@ struct BlockBasedTableBuilder::Rep {
   };
   State state;
   // `kBuffered` state is allowed only as long as the buffering of uncompressed
-  // data blocks (see `data_block_buffers`) does not exceed `buffer_limit`.
+  // data blocks (see `data_block_and_keys_buffers`) does not exceed
+  // `buffer_limit`.
   uint64_t buffer_limit;
 
   const bool use_delta_encoding_for_index_values;
@@ -949,8 +953,12 @@ void BlockBasedTableBuilder::Add(const Slice& key, const Slice& value) {
     r->last_key.assign(key.data(), key.size());
     r->data_block.Add(key, value);
     if (r->state == Rep::State::kBuffered) {
-      // Buffered keys will be replayed from data_block_buffers during
-      // `Finish()` once compression dictionary has been finalized.
+      // Buffer keys to be replayed during `Finish()` once compression
+      // dictionary has been finalized.
+      if (r->data_block_and_keys_buffers.empty() || should_flush) {
+        r->data_block_and_keys_buffers.emplace_back();
+      }
+      r->data_block_and_keys_buffers.back().second.emplace_back(key.ToString());
     } else {
       if (!r->IsParallelCompressionEnabled()) {
         r->index_builder->OnKeyAdded(key);
@@ -1011,8 +1019,11 @@ void BlockBasedTableBuilder::WriteBlock(BlockBuilder* block,
   block->SwapAndReset(raw_block_contents);
   if (rep_->state == Rep::State::kBuffered) {
     assert(is_data_block);
-    rep_->data_block_buffers.emplace_back(std::move(raw_block_contents));
-    rep_->data_begin_offset += rep_->data_block_buffers.back().size();
+    assert(!rep_->data_block_and_keys_buffers.empty());
+    rep_->data_block_and_keys_buffers.back().first =
+        std::move(raw_block_contents);
+    rep_->data_begin_offset +=
+        rep_->data_block_and_keys_buffers.back().first.size();
     return;
   }
   WriteBlock(raw_block_contents, handle, is_data_block);
@@ -1684,7 +1695,7 @@ void BlockBasedTableBuilder::EnterUnbuffered() {
   const size_t kSampleBytes = r->compression_opts.zstd_max_train_bytes > 0
                                   ? r->compression_opts.zstd_max_train_bytes
                                   : r->compression_opts.max_dict_bytes;
-  const size_t kNumBlocksBuffered = r->data_block_buffers.size();
+  const size_t kNumBlocksBuffered = r->data_block_and_keys_buffers.size();
   if (kNumBlocksBuffered == 0) {
     // The below code is neither safe nor necessary for handling zero data
     // blocks.
@@ -1714,10 +1725,11 @@ void BlockBasedTableBuilder::EnterUnbuffered() {
   for (size_t i = 0;
        i < kNumBlocksBuffered && compression_dict_samples.size() < kSampleBytes;
        ++i) {
-    size_t copy_len = std::min(kSampleBytes - compression_dict_samples.size(),
-                               r->data_block_buffers[buffer_idx].size());
-    compression_dict_samples.append(r->data_block_buffers[buffer_idx], 0,
-                                    copy_len);
+    size_t copy_len =
+        std::min(kSampleBytes - compression_dict_samples.size(),
+                 r->data_block_and_keys_buffers[buffer_idx].first.size());
+    compression_dict_samples.append(
+        r->data_block_and_keys_buffers[buffer_idx].first, 0, copy_len);
     compression_dict_sample_lens.emplace_back(copy_len);
 
     buffer_idx += kPrimeGeneratorRemainder;
@@ -1742,58 +1754,30 @@ void BlockBasedTableBuilder::EnterUnbuffered() {
       dict, r->compression_type == kZSTD ||
                 r->compression_type == kZSTDNotFinalCompression));
 
-  auto get_iterator_for_block = [&r](size_t i) {
-    auto& data_block = r->data_block_buffers[i];
+  for (size_t i = 0; ok() && i < r->data_block_and_keys_buffers.size(); ++i) {
+    auto& data_block = r->data_block_and_keys_buffers[i].first;
+    auto& keys = r->data_block_and_keys_buffers[i].second;
     assert(!data_block.empty());
-
-    Block reader{BlockContents{data_block}};
-    DataBlockIter* iter = reader.NewDataIterator(
-        r->internal_comparator.user_comparator(), kDisableGlobalSequenceNumber);
-
-    iter->SeekToFirst();
-    assert(iter->Valid());
-    return std::unique_ptr<DataBlockIter>(iter);
-  };
-
-  std::unique_ptr<DataBlockIter> iter = nullptr, next_block_iter = nullptr;
-
-  for (size_t i = 0; ok() && i < r->data_block_buffers.size(); ++i) {
-    if (iter == nullptr) {
-      iter = get_iterator_for_block(i);
-      assert(iter != nullptr);
-    };
-
-    if (i + 1 < r->data_block_buffers.size()) {
-      next_block_iter = get_iterator_for_block(i + 1);
-    }
-
-    auto& data_block = r->data_block_buffers[i];
+    assert(!keys.empty());
 
     if (r->IsParallelCompressionEnabled()) {
       Slice first_key_in_next_block;
       const Slice* first_key_in_next_block_ptr = &first_key_in_next_block;
-      if (i + 1 < r->data_block_buffers.size()) {
-        assert(next_block_iter != nullptr);
-        first_key_in_next_block = next_block_iter->key();
+      if (i + 1 < r->data_block_and_keys_buffers.size()) {
+        first_key_in_next_block =
+            r->data_block_and_keys_buffers[i + 1].second.front();
       } else {
         first_key_in_next_block_ptr = r->first_key_in_next_block;
       }
 
-      std::vector<std::string> keys;
-      for (; iter->Valid(); iter->Next()) {
-        keys.emplace_back(iter->key().ToString());
-      }
-
       ParallelCompressionRep::BlockRep* block_rep = r->pc_rep->PrepareBlock(
           r->compression_type, first_key_in_next_block_ptr, &data_block, &keys);
-
       assert(block_rep != nullptr);
       r->pc_rep->file_size_estimator.EmitBlock(block_rep->data->size(),
                                                r->get_offset());
       r->pc_rep->EmitBlock(block_rep);
     } else {
-      for (; iter->Valid(); iter->Next()) {
-        Slice key = iter->key();
+      for (const auto& key : keys) {
         if (r->filter_builder != nullptr) {
           size_t ts_sz =
               r->internal_comparator.user_comparator()->timestamp_size();
@@ -1803,22 +1787,16 @@ void BlockBasedTableBuilder::EnterUnbuffered() {
       }
       WriteBlock(Slice(data_block), &r->pending_handle,
                  true /* is_data_block */);
-      if (ok() && i + 1 < r->data_block_buffers.size()) {
-        assert(next_block_iter != nullptr);
-        Slice first_key_in_next_block = next_block_iter->key();
-
+      if (ok() && i + 1 < r->data_block_and_keys_buffers.size()) {
+        Slice first_key_in_next_block =
+            r->data_block_and_keys_buffers[i + 1].second.front();
         Slice* first_key_in_next_block_ptr = &first_key_in_next_block;
-
-        iter->SeekToLast();
-        std::string last_key = iter->key().ToString();
-        r->index_builder->AddIndexEntry(&last_key, first_key_in_next_block_ptr,
-                                        r->pending_handle);
+        r->index_builder->AddIndexEntry(
+            &keys.back(), first_key_in_next_block_ptr, r->pending_handle);
       }
     }
-
-    std::swap(iter, next_block_iter);
   }
-  r->data_block_buffers.clear();
+  r->data_block_and_keys_buffers.clear();
 }
 
 Status BlockBasedTableBuilder::Finish() {

table/block_based/block_based_table_factory.cc

@@ -428,7 +428,8 @@ BlockBasedTableFactory::BlockBasedTableFactory(
     const BlockBasedTableOptions& _table_options)
     : table_options_(_table_options) {
   InitializeOptions();
-  RegisterOptions(&table_options_, &block_based_table_type_info);
+  ConfigurableHelper::RegisterOptions(*this, &table_options_,
+                                      &block_based_table_type_info);
 }
 
 void BlockBasedTableFactory::InitializeOptions() {

table/cuckoo/cuckoo_table_factory.cc

@@ -95,7 +95,8 @@ static std::unordered_map<std::string, OptionTypeInfo> cuckoo_table_type_info =
 
 CuckooTableFactory::CuckooTableFactory(const CuckooTableOptions& table_options)
     : table_options_(table_options) {
-  RegisterOptions(&table_options_, &cuckoo_table_type_info);
+  ConfigurableHelper::RegisterOptions(*this, &table_options_,
+                                      &cuckoo_table_type_info);
 }
 
 TableFactory* NewCuckooTableFactory(const CuckooTableOptions& table_options) {

table/meta_blocks.cc

@@ -152,8 +152,8 @@ Slice PropertyBlockBuilder::Finish() {
   return properties_block_->Finish();
 }
 
-void LogPropertiesCollectionError(Logger* info_log, const std::string& method,
-                                  const std::string& name) {
+void LogPropertiesCollectionError(
+    Logger* info_log, const std::string& method, const std::string& name) {
   assert(method == "Add" || method == "Finish");
 
   std::string msg =

table/meta_blocks.h

@@ -70,8 +70,8 @@ class PropertyBlockBuilder {
 
 // Were we encounter any error occurs during user-defined statistics collection,
 // we'll write the warning message to info log.
-void LogPropertiesCollectionError(Logger* info_log, const std::string& method,
-                                  const std::string& name);
+void LogPropertiesCollectionError(
+    Logger* info_log, const std::string& method, const std::string& name);
 
 // Utility functions help table builder to trigger batch events for user
 // defined property collectors.

table/plain/plain_table_factory.cc

@@ -52,7 +52,8 @@ static std::unordered_map<std::string, OptionTypeInfo> plain_table_type_info = {
 
 PlainTableFactory::PlainTableFactory(const PlainTableOptions& options)
     : table_options_(options) {
-  RegisterOptions(&table_options_, &plain_table_type_info);
+  ConfigurableHelper::RegisterOptions(*this, &table_options_,
+                                      &plain_table_type_info);
 }
 
 Status PlainTableFactory::NewTableReader(

table/sst_file_writer.cc

@@ -260,7 +260,7 @@ Status SstFileWriter::Open(const std::string& file_path) {
   r->file_writer.reset(new WritableFileWriter(
       std::move(sst_file), file_path, r->env_options, r->ioptions.clock,
       nullptr /* io_tracer */, nullptr /* stats */, r->ioptions.listeners,
-      r->ioptions.file_checksum_gen_factory.get(),
+      r->ioptions.file_checksum_gen_factory,
       tmp_set.Contains(FileType::kTableFile)));
 
   // TODO(tec) : If table_factory is using compressed block cache, we will

table/table_reader_bench.cc

@@ -175,11 +175,11 @@ void TableReaderBenchmark(Options& opts, EnvOptions& env_options,
             PinnableSlice value;
             MergeContext merge_context;
             SequenceNumber max_covering_tombstone_seq = 0;
-            GetContext get_context(
-                ioptions.user_comparator, ioptions.merge_operator.get(),
-                ioptions.info_log, ioptions.statistics, GetContext::kNotFound,
-                Slice(key), &value, nullptr, &merge_context, true,
-                &max_covering_tombstone_seq, clock);
+            GetContext get_context(ioptions.user_comparator,
+                                   ioptions.merge_operator, ioptions.info_log,
+                                   ioptions.statistics, GetContext::kNotFound,
+                                   Slice(key), &value, nullptr, &merge_context,
+                                   true, &max_covering_tombstone_seq, clock);
             s = table_reader->Get(read_options, key, &get_context, nullptr);
           } else {
             s = db->Get(read_options, key, &result);

tools/db_bench_tool.cc

@@ -56,10 +56,8 @@
 #include "rocksdb/slice.h"
 #include "rocksdb/slice_transform.h"
 #include "rocksdb/stats_history.h"
-#include "rocksdb/tiered_cache.h"
 #include "rocksdb/utilities/object_registry.h"
 #include "rocksdb/utilities/optimistic_transaction_db.h"
-#include "rocksdb/utilities/options_type.h"
 #include "rocksdb/utilities/options_util.h"
 #include "rocksdb/utilities/sim_cache.h"
 #include "rocksdb/utilities/transaction.h"
@@ -1414,12 +1412,6 @@ DEFINE_bool(read_with_latest_user_timestamp, true,
             "If true, always use the current latest timestamp for read. If "
             "false, choose a random timestamp from the past.");
 
-#ifndef ROCKSDB_LITE
-DEFINE_string(tiered_cache_uri, "",
-              "Full URI for creating a custom tiered cache object");
-static class std::shared_ptr<ROCKSDB_NAMESPACE::TieredCache> tiered_cache;
-#endif
-
 static const bool FLAGS_soft_rate_limit_dummy __attribute__((__unused__)) =
     RegisterFlagValidator(&FLAGS_soft_rate_limit, &ValidateRateLimit);
 
@@ -2781,37 +2773,22 @@ class Benchmark {
       }
       return cache;
     } else {
-      LRUCacheOptions opts(
-          static_cast<size_t>(capacity), FLAGS_cache_numshardbits,
-          false /*strict_capacity_limit*/, FLAGS_cache_high_pri_pool_ratio,
-#ifdef MEMKIND
-          FLAGS_use_cache_memkind_kmem_allocator
-              ? std::make_shared<MemkindKmemAllocator>()
-              : nullptr
-#else
-          nullptr
-#endif
-      );
       if (FLAGS_use_cache_memkind_kmem_allocator) {
-#ifndef MEMKIND
+#ifdef MEMKIND
+        return NewLRUCache(
+            static_cast<size_t>(capacity), FLAGS_cache_numshardbits,
+            false /*strict_capacity_limit*/, FLAGS_cache_high_pri_pool_ratio,
+            std::make_shared<MemkindKmemAllocator>());
+
+#else
         fprintf(stderr, "Memkind library is not linked with the binary.");
         exit(1);
 #endif
+      } else {
+        return NewLRUCache(
+            static_cast<size_t>(capacity), FLAGS_cache_numshardbits,
+            false /*strict_capacity_limit*/, FLAGS_cache_high_pri_pool_ratio);
       }
-#ifndef ROCKSDB_LITE
-      if (!FLAGS_tiered_cache_uri.empty()) {
-        Status s = ObjectRegistry::NewInstance()->NewSharedObject<TieredCache>(
-            FLAGS_tiered_cache_uri, &tiered_cache);
-        if (tiered_cache == nullptr) {
-          fprintf(stderr,
-                  "No tiered cache registered matching string: %s status=%s\n",
-                  FLAGS_tiered_cache_uri.c_str(), s.ToString().c_str());
-          exit(1);
-        }
-        opts.tiered_cache = tiered_cache;
-      }
-#endif
-      return NewLRUCache(opts);
     }
   }
 

tools/db_crashtest.py

@@ -61,6 +61,7 @@ default_params = {
     "enable_pipelined_write": lambda: random.randint(0, 1),
     "enable_compaction_filter": lambda: random.choice([0, 0, 0, 1]),
     "expected_values_path": lambda: setup_expected_values_file(),
+    "fail_if_options_file_error": lambda: random.randint(0, 1),
     "flush_one_in": 1000000,
     "file_checksum_impl": lambda: random.choice(["none", "crc32c", "xxh64", "big"]),
     "get_live_files_one_in": 1000000,
@@ -137,6 +138,7 @@ default_params = {
     "max_key_len": 3,
     "key_len_percent_dist": "1,30,69",
     "read_fault_one_in": lambda: random.choice([0, 1000]),
+    "open_metadata_write_fault_one_in": lambda: random.choice([0, 8]),
     "sync_fault_injection": False,
     "get_property_one_in": 1000000,
     "paranoid_file_checks": lambda: random.choice([0, 1, 1, 1]),

util/filter_bench.cc

@@ -270,8 +270,8 @@ struct FilterBench : public MockBlockBasedTableTester {
   Random32 random_;
   std::ostringstream fp_rate_report_;
   Arena arena_;
-  double m_queries_;
   StderrLogger stderr_logger_;
+  double m_queries_;
 
   FilterBench()
       : MockBlockBasedTableTester(new BloomFilterPolicy(

utilities/backupable/backupable_db_test.cc

@@ -2168,8 +2168,6 @@ TEST_F(BackupableDBTest, TableFileCorruptionBeforeIncremental) {
 // between incremental backups
 TEST_F(BackupableDBTest, FileSizeForIncremental) {
   const auto share_no_checksum = static_cast<ShareFilesNaming>(0);
-  // TODO: enable blob files once Integrated BlobDB supports DB session id.
-  options_.enable_blob_files = false;
 
   for (ShareFilesNaming option : {share_no_checksum, kLegacyCrc32cAndFileSize,
                                   kNamingDefault, kUseDbSessionId}) {
@@ -2194,9 +2192,9 @@ TEST_F(BackupableDBTest, FileSizeForIncremental) {
     ASSERT_OK(backup_engine_->CreateNewBackup(db_.get(), true /*flush*/));
     CloseDBAndBackupEngine();
 
-    // Corrupt backup SST file
+    // Corrupt backup SST and blob file
     ASSERT_OK(file_manager_->GetChildrenFileAttributes(shared_dir, &children));
-    ASSERT_EQ(children.size(), 1U);  // one sst
+    ASSERT_EQ(children.size(), 2U);  // one sst and one blob file
     for (const auto& child : children) {
       if (child.name.size() > 4 && child.size_bytes > 0) {
         ASSERT_OK(
@@ -2253,10 +2251,10 @@ TEST_F(BackupableDBTest, FileSizeForIncremental) {
     OpenDBAndBackupEngine(false, false, share);
     ASSERT_OK(db_->Put(WriteOptions(), "y", Random(42).RandomString(500)));
 
-    // Count backup SSTs files.
+    // Count backup SSTs and blob files.
     children.clear();
     ASSERT_OK(file_manager_->GetChildrenFileAttributes(shared_dir, &children));
-    ASSERT_EQ(children.size(), 2U);  // two sst files
+    ASSERT_EQ(children.size(), 4U);  // two sst and two blob files
 
     // Try create backup 3
     s = backup_engine_->CreateNewBackup(db_.get(), true /*flush*/);
@@ -2269,18 +2267,18 @@ TEST_F(BackupableDBTest, FileSizeForIncremental) {
       // Acceptable to call it corruption if size is not in name and
       // db session id collision is practically impossible.
       EXPECT_TRUE(s.IsCorruption());
-      EXPECT_EQ(children.size(), 2U);  // no SST file added
+      EXPECT_EQ(children.size(), 4U);  // no SST/Blob file added
     } else if (option == share_no_checksum) {
       // Good to call it corruption if both backups cannot be
       // accommodated.
       EXPECT_TRUE(s.IsCorruption());
-      EXPECT_EQ(children.size(), 2U);  // no SST file added
+      EXPECT_EQ(children.size(), 4U);  // no SST/Blob file added
     } else {
       // Since opening a DB seems sufficient for detecting size corruption
       // on the DB side, this should be a good thing, ...
       EXPECT_OK(s);
       // ... as long as we did actually treat it as a distinct SST file.
-      EXPECT_EQ(children.size(), 3U);  // Another SST added
+      EXPECT_EQ(children.size(), 6U);  // Another SST and blob added
     }
     CloseDBAndBackupEngine();
     ASSERT_OK(DestroyDB(dbname_, options_));

utilities/checkpoint/checkpoint_test.cc

@@ -29,6 +29,7 @@
 #include "test_util/testharness.h"
 #include "test_util/testutil.h"
 #include "utilities/fault_injection_env.h"
+#include "utilities/fault_injection_fs.h"
 
 namespace ROCKSDB_NAMESPACE {
 class CheckpointTest : public testing::Test {
@@ -793,6 +794,50 @@ TEST_F(CheckpointTest, CheckpointWithUnsyncedDataDropped) {
   db_ = nullptr;
 }
 
+TEST_F(CheckpointTest, CheckpointOptionsFileFailedToPersist) {
+  // Regression test for a bug where checkpoint failed on a DB where persisting
+  // OPTIONS file failed and the DB was opened with
+  // `fail_if_options_file_error == false`.
+  Options options = CurrentOptions();
+  options.fail_if_options_file_error = false;
+  auto fault_fs = std::make_shared<FaultInjectionTestFS>(FileSystem::Default());
+
+  // Setup `FaultInjectionTestFS` and `SyncPoint` callbacks to fail one
+  // operation when inside the OPTIONS file persisting code.
+  std::unique_ptr<Env> fault_fs_env(NewCompositeEnv(fault_fs));
+  fault_fs->SetRandomMetadataWriteError(1 /* one_in */);
+  SyncPoint::GetInstance()->SetCallBack(
+      "PersistRocksDBOptions:start", [fault_fs](void* /* arg */) {
+        fault_fs->EnableMetadataWriteErrorInjection();
+      });
+  SyncPoint::GetInstance()->SetCallBack(
+      "FaultInjectionTestFS::InjectMetadataWriteError:Injected",
+      [fault_fs](void* /* arg */) {
+        fault_fs->DisableMetadataWriteErrorInjection();
+      });
+  options.env = fault_fs_env.get();
+  SyncPoint::GetInstance()->EnableProcessing();
+
+  Reopen(options);
+  ASSERT_OK(Put("key1", "val1"));
+  Checkpoint* checkpoint;
+  ASSERT_OK(Checkpoint::Create(db_, &checkpoint));
+  ASSERT_OK(checkpoint->CreateCheckpoint(snapshot_name_));
+  delete checkpoint;
+
+  // Make sure it's usable.
+  options.env = env_;
+  DB* snapshot_db;
+  ASSERT_OK(DB::Open(options, snapshot_name_, &snapshot_db));
+  ReadOptions read_opts;
+  std::string get_result;
+  ASSERT_OK(snapshot_db->Get(read_opts, "key1", &get_result));
+  ASSERT_EQ("val1", get_result);
+  delete snapshot_db;
+  delete db_;
+  db_ = nullptr;
+}
+
 TEST_F(CheckpointTest, CheckpointReadOnlyDB) {
   ASSERT_OK(Put("foo", "foo_value"));
   ASSERT_OK(Flush());

utilities/fault_injection_fs.cc

@@ -22,6 +22,7 @@
 #include "env/composite_env_wrapper.h"
 #include "port/lang.h"
 #include "port/stack_trace.h"
+#include "test_util/sync_point.h"
 #include "util/coding.h"
 #include "util/crc32c.h"
 #include "util/random.h"
@@ -87,8 +88,21 @@ IOStatus TestFSDirectory::Fsync(const IOOptions& options, IODebugContext* dbg) {
   if (!fs_->IsFilesystemActive()) {
     return fs_->GetError();
   }
+  {
+    IOStatus in_s = fs_->InjectMetadataWriteError();
+    if (!in_s.ok()) {
+      return in_s;
+    }
+  }
   fs_->SyncDir(dirname_);
-  return dir_->Fsync(options, dbg);
+  IOStatus s = dir_->Fsync(options, dbg);
+  {
+    IOStatus in_s = fs_->InjectMetadataWriteError();
+    if (!in_s.ok()) {
+      return in_s;
+    }
+  }
+  return s;
 }
 
 TestFSWritableFile::TestFSWritableFile(const std::string& fname,
@@ -159,6 +173,12 @@ IOStatus TestFSWritableFile::Close(const IOOptions& options,
   if (!fs_->IsFilesystemActive()) {
     return fs_->GetError();
   }
+  {
+    IOStatus in_s = fs_->InjectMetadataWriteError();
+    if (!in_s.ok()) {
+      return in_s;
+    }
+  }
   writable_file_opened_ = false;
   IOStatus io_s;
   io_s = target_->Append(state_.buffer_, options, dbg);
@@ -170,6 +190,10 @@ IOStatus TestFSWritableFile::Close(const IOOptions& options,
   }
   if (io_s.ok()) {
     fs_->WritableFileClosed(state_);
+    IOStatus in_s = fs_->InjectMetadataWriteError();
+    if (!in_s.ok()) {
+      return in_s;
+    }
   }
   return io_s;
 }
@@ -294,6 +318,12 @@ IOStatus FaultInjectionTestFS::NewWritableFile(
   if (!IsFilesystemActive()) {
     return GetError();
   }
+  {
+    IOStatus in_s = InjectMetadataWriteError();
+    if (!in_s.ok()) {
+      return in_s;
+    }
+  }
   if (IsFilesystemDirectWritable()) {
     return target()->NewWritableFile(fname, file_opts, result, dbg);
   }
@@ -305,11 +335,19 @@ IOStatus FaultInjectionTestFS::NewWritableFile(
     // WritableFileWriter* file is opened
     // again then it will be truncated - so forget our saved state.
     UntrackFile(fname);
-    MutexLock l(&mutex_);
-    open_files_.insert(fname);
-    auto dir_and_name = TestFSGetDirAndName(fname);
-    auto& list = dir_to_new_files_since_last_sync_[dir_and_name.first];
-    list.insert(dir_and_name.second);
+    {
+      MutexLock l(&mutex_);
+      open_files_.insert(fname);
+      auto dir_and_name = TestFSGetDirAndName(fname);
+      auto& list = dir_to_new_files_since_last_sync_[dir_and_name.first];
+      list.insert(dir_and_name.second);
+    }
+    {
+      IOStatus in_s = InjectMetadataWriteError();
+      if (!in_s.ok()) {
+        return in_s;
+      }
+    }
   }
   return io_s;
 }
@@ -323,6 +361,12 @@ IOStatus FaultInjectionTestFS::ReopenWritableFile(
   if (IsFilesystemDirectWritable()) {
     return target()->ReopenWritableFile(fname, file_opts, result, dbg);
   }
+  {
+    IOStatus in_s = InjectMetadataWriteError();
+    if (!in_s.ok()) {
+      return in_s;
+    }
+  }
   IOStatus io_s = target()->ReopenWritableFile(fname, file_opts, result, dbg);
   if (io_s.ok()) {
     result->reset(
@@ -330,11 +374,19 @@ IOStatus FaultInjectionTestFS::ReopenWritableFile(
     // WritableFileWriter* file is opened
     // again then it will be truncated - so forget our saved state.
     UntrackFile(fname);
-    MutexLock l(&mutex_);
-    open_files_.insert(fname);
-    auto dir_and_name = TestFSGetDirAndName(fname);
-    auto& list = dir_to_new_files_since_last_sync_[dir_and_name.first];
-    list.insert(dir_and_name.second);
+    {
+      MutexLock l(&mutex_);
+      open_files_.insert(fname);
+      auto dir_and_name = TestFSGetDirAndName(fname);
+      auto& list = dir_to_new_files_since_last_sync_[dir_and_name.first];
+      list.insert(dir_and_name.second);
+    }
+    {
+      IOStatus in_s = InjectMetadataWriteError();
+      if (!in_s.ok()) {
+        return in_s;
+      }
+    }
   }
   return io_s;
 }
@@ -348,17 +400,31 @@ IOStatus FaultInjectionTestFS::NewRandomRWFile(
   if (IsFilesystemDirectWritable()) {
     return target()->NewRandomRWFile(fname, file_opts, result, dbg);
   }
+  {
+    IOStatus in_s = InjectMetadataWriteError();
+    if (!in_s.ok()) {
+      return in_s;
+    }
+  }
   IOStatus io_s = target()->NewRandomRWFile(fname, file_opts, result, dbg);
   if (io_s.ok()) {
     result->reset(new TestFSRandomRWFile(fname, std::move(*result), this));
     // WritableFileWriter* file is opened
     // again then it will be truncated - so forget our saved state.
     UntrackFile(fname);
-    MutexLock l(&mutex_);
-    open_files_.insert(fname);
-    auto dir_and_name = TestFSGetDirAndName(fname);
-    auto& list = dir_to_new_files_since_last_sync_[dir_and_name.first];
-    list.insert(dir_and_name.second);
+    {
+      MutexLock l(&mutex_);
+      open_files_.insert(fname);
+      auto dir_and_name = TestFSGetDirAndName(fname);
+      auto& list = dir_to_new_files_since_last_sync_[dir_and_name.first];
+      list.insert(dir_and_name.second);
+    }
+    {
+      IOStatus in_s = InjectMetadataWriteError();
+      if (!in_s.ok()) {
+        return in_s;
+      }
+    }
   }
   return io_s;
 }
@@ -385,9 +451,21 @@ IOStatus FaultInjectionTestFS::DeleteFile(const std::string& f,
   if (!IsFilesystemActive()) {
     return GetError();
   }
+  {
+    IOStatus in_s = InjectMetadataWriteError();
+    if (!in_s.ok()) {
+      return in_s;
+    }
+  }
   IOStatus io_s = FileSystemWrapper::DeleteFile(f, options, dbg);
   if (io_s.ok()) {
     UntrackFile(f);
+    {
+      IOStatus in_s = InjectMetadataWriteError();
+      if (!in_s.ok()) {
+        return in_s;
+      }
+    }
   }
   return io_s;
 }
@@ -399,21 +477,33 @@ IOStatus FaultInjectionTestFS::RenameFile(const std::string& s,
   if (!IsFilesystemActive()) {
     return GetError();
   }
+  {
+    IOStatus in_s = InjectMetadataWriteError();
+    if (!in_s.ok()) {
+      return in_s;
+    }
+  }
   IOStatus io_s = FileSystemWrapper::RenameFile(s, t, options, dbg);
 
   if (io_s.ok()) {
-    MutexLock l(&mutex_);
-    if (db_file_state_.find(s) != db_file_state_.end()) {
-      db_file_state_[t] = db_file_state_[s];
-      db_file_state_.erase(s);
-    }
+    {
+      MutexLock l(&mutex_);
+      if (db_file_state_.find(s) != db_file_state_.end()) {
+        db_file_state_[t] = db_file_state_[s];
+        db_file_state_.erase(s);
+      }
 
-    auto sdn = TestFSGetDirAndName(s);
-    auto tdn = TestFSGetDirAndName(t);
-    if (dir_to_new_files_since_last_sync_[sdn.first].erase(sdn.second) != 0) {
-      auto& tlist = dir_to_new_files_since_last_sync_[tdn.first];
-      assert(tlist.find(tdn.second) == tlist.end());
-      tlist.insert(tdn.second);
+      auto sdn = TestFSGetDirAndName(s);
+      auto tdn = TestFSGetDirAndName(t);
+      if (dir_to_new_files_since_last_sync_[sdn.first].erase(sdn.second) != 0) {
+        auto& tlist = dir_to_new_files_since_last_sync_[tdn.first];
+        assert(tlist.find(tdn.second) == tlist.end());
+        tlist.insert(tdn.second);
+      }
+    }
+    IOStatus in_s = InjectMetadataWriteError();
+    if (!in_s.ok()) {
+      return in_s;
     }
   }
 
@@ -618,6 +708,19 @@ IOStatus FaultInjectionTestFS::InjectWriteError(const std::string& file_name) {
   return IOStatus::OK();
 }
 
+IOStatus FaultInjectionTestFS::InjectMetadataWriteError() {
+  {
+    MutexLock l(&mutex_);
+    if (!enable_metadata_write_error_injection_ ||
+        !metadata_write_error_one_in_ ||
+        !write_error_rand_.OneIn(metadata_write_error_one_in_)) {
+      return IOStatus::OK();
+    }
+  }
+  TEST_SYNC_POINT("FaultInjectionTestFS::InjectMetadataWriteError:Injected");
+  return IOStatus::IOError();
+}
+
 void FaultInjectionTestFS::PrintFaultBacktrace() {
 #if defined(OS_LINUX)
   ErrorContext* ctx =