Compare commits

...

2 Commits

Author SHA1 Message Date
Andrew Kryczka fdf403f591 update HISTORY.md for 8.0.0 2023-02-19 13:44:55 -08:00
Andrew Kryczka 4b87e21f3a Add missing override keyword in env_win.h functions (#11232)
Summary:
I couldn't figure out why this causes failures in our 8.0 release to fbcode while this issue appears to not be new in 8.0. Anyways, we can add the missing `override` keywords to these functions as the compiler insists.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/11232

Reviewed By: pdillinger

Differential Revision: D43420656

Pulled By: ajkr

fbshipit-source-id: da748eeef6ba38dd113dbe4b5143d7558daf38dd
2023-02-19 08:07:07 -08:00
2 changed files with 3 additions and 4 deletions
+1 -2
View File
@@ -1,6 +1,5 @@
# Rocksdb Change Log
## Unreleased
## 8.0.0 (02/19/2023)
### Behavior changes
* `ReadOptions::verify_checksums=false` disables checksum verification for more reads of non-`CacheEntryRole::kDataBlock` blocks.
* In case of scan with async_io enabled, if posix doesn't support IOUring, Status::NotSupported error will be returned to the users. Initially that error was swallowed and reads were switched to synchronous reads.
+2 -2
View File
@@ -97,7 +97,7 @@ class WinClock : public SystemClock {
Status GetCurrentTime(int64_t* unix_time) override;
// Converts seconds-since-Jan-01-1970 to a printable string
virtual std::string TimeToString(uint64_t time);
std::string TimeToString(uint64_t time) override;
uint64_t GetPerfCounterFrequency() const { return perf_counter_frequency_; }
@@ -116,7 +116,7 @@ class WinFileSystem : public FileSystem {
~WinFileSystem() {}
static const char* kClassName() { return "WinFS"; }
const char* Name() const override { return kClassName(); }
const char* NickName() const { return kDefaultName(); }
const char* NickName() const override { return kDefaultName(); }
static size_t GetSectorSize(const std::string& fname);
size_t GetPageSize() const { return page_size_; }