jabberwocky238/rocksdb
1
0
Fork 0
mirror of https://github.com/facebook/rocksdb.git synced 2026-07-07 14:47:40 +08:00
Code Issues Packages Projects Releases Wiki Activity

Disable Incompatible Tests with Remote Compaction (#13843)

Browse Source 
Summary:
To reduce the noise, disable the incompatible ones for now when `remote_compaction_worker_threads > 0`. We will investigate each, fix as needed and re-enable them as follow up.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/13843

Test Plan:
```
python3 -u tools/db_crashtest.py blackbox --remote_compaction_worker_threads=8 --interval=5 --duration=6000 --continuous_verification_interval=10 --disable_wal=1 --use_txn=1 --enable_pipelined_write=0 --checkpoint_one_in=0 --use_timed_put_one_in=0
```

Reviewed By: cbi42

Differential Revision: D79735166

Pulled By: jaykorean

fbshipit-source-id: ae3be38a21073fd3282d6e8cd7d71f0363df3590
This commit is contained in:
Jay Huh
2025-08-06 11:54:23 -07:00
committed by Facebook GitHub Bot
parent dfb4efaae3
commit 3dd6c6f9cb
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/db_crashtest.py
+7 -1
View File
@@ -1086,9 +1086,15 @@ def finalize_and_sanitize(src_params):
# Continuous verification fails with secondaries inside NonBatchedOpsStressTest
if dest_params.get("test_secondary") == 1:
dest_params["continuous_verification_interval"] = 0
# TODO Fix races when both Remote Compaction + BlobDB enabled
if dest_params.get("remote_compaction_worker_threads") > 0:
# TODO Fix races when both Remote Compaction + BlobDB enabled
dest_params["enable_blob_files"] = 0
# TODO Fix - Remote worker shouldn't recover from WAL
dest_params["disable_wal"] = 1
# Disable Incompatible Ones
dest_params["checkpoint_one_in"] = 0
dest_params["enable_pipelined_write"] = 0
dest_params["use_timed_put_one_in"] = 0
return dest_params