mirror of
https://github.com/facebook/rocksdb.git
synced 2026-07-07 14:47:40 +08:00
Remove deprecated remote compaction apis (#13188)
Summary: `StartV2()` and `WaitForCompleteV2()` were deprecated and replaced by`Schedule()` and `Wait()` in 9.1.0. This PR removes them from the codebase completely. Pull Request resolved: https://github.com/facebook/rocksdb/pull/13188 Test Plan: CI Reviewed By: archang19 Differential Revision: D66843687 Pulled By: jaykorean fbshipit-source-id: f13d05845bf5ac4ae736c105035ca1a4d5a96047
This commit is contained in:
committed by
Facebook GitHub Bot
parent
d5345a8ff7
commit
1347bfb07f
@@ -531,25 +531,6 @@ class CompactionService : public Customizable {
|
||||
virtual void OnInstallation(const std::string& /*scheduled_job_id*/,
|
||||
CompactionServiceJobStatus /*status*/) {}
|
||||
|
||||
// Deprecated. Please implement Schedule() and Wait() API to handle remote
|
||||
// compaction
|
||||
|
||||
// Start the remote compaction with `compaction_service_input`, which can be
|
||||
// passed to `DB::OpenAndCompact()` on the remote side. `info` provides the
|
||||
// information the user might want to know, which includes `job_id`.
|
||||
virtual CompactionServiceJobStatus StartV2(
|
||||
const CompactionServiceJobInfo& /*info*/,
|
||||
const std::string& /*compaction_service_input*/) {
|
||||
return CompactionServiceJobStatus::kUseLocal;
|
||||
}
|
||||
|
||||
// Wait for remote compaction to finish.
|
||||
virtual CompactionServiceJobStatus WaitForCompleteV2(
|
||||
const CompactionServiceJobInfo& /*info*/,
|
||||
std::string* /*compaction_service_result*/) {
|
||||
return CompactionServiceJobStatus::kUseLocal;
|
||||
}
|
||||
|
||||
~CompactionService() override = default;
|
||||
};
|
||||
|
||||
|
||||
@@ -0,0 +1 @@
|
||||
Deprecated Remote Compaction APIs (StartV2, WaitForCompleteV2) are completely removed from the codebase
|
||||
Reference in New Issue
Block a user