jabberwocky238/rocksdb
1
0
Fork 0
mirror of https://github.com/facebook/rocksdb.git synced 2026-07-07 14:47:40 +08:00
Code Issues Packages Projects Releases Wiki Activity

Disable skip_stats_update_on_db_open in crash tests for multiscan (#14039)

Browse Source 
Summary:
Multi scan crash/stress tests are failing when skip_stats_update_on_db_open is true, because LevelIterator::Prepare relies on these stats in FileMetaData to make decisions. Disable it in crash tests until the proper fix is ready.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/14039

Reviewed By: archang19

Differential Revision: D84280059

Pulled By: anand1976

fbshipit-source-id: f9f58b94c24d1f455432b05f3bf97f25c7233e3c
This commit is contained in:
anand76
2025-10-09 17:31:54 -07:00
committed by meta-codesync[bot]
parent 2d331cc125
commit 04c085a3fa
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/db_crashtest.py
+3
View File
@@ -1202,6 +1202,9 @@ def finalize_and_sanitize(src_params):
# existing key range, which will cause a reseek that's currently not
# supported by multiscan
dest_params["test_ingest_standalone_range_deletion_one_in"] = 0
# LevelIterator multiscan currently relies on num_entries and num_range_deletions,
# which are not updated if skip_stats_update_on_db_open is true
dest_params["skip_stats_update_on_db_open"] = 0
# inplace update and key checksum verification during seek would cause race condition
# Therefore, when inplace_update_support is enabled, disable memtable_veirfy_per_key_checksum_on_seek