jabberwocky238/libfuse
1
0
Fork 0
mirror of https://github.com/libfuse/libfuse.git synced 2026-07-07 14:47:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

lib/fuse_signals: fix cppcheck warnings

Browse Source 
- Remove redundant assignment after abort() (unreachable code)
- Remove unreachable assignment of fuse_instance->error after abort()
- Mark signals parameters as const in internal functions
- Mark se parameter as const in fuse_remove_signal_handlers

Fixes cppcheck warnings:
- cppcheck-redundantAssignment
- cppcheck-unreachableCode
- cppcheck-constParameter
- cppcheck-constParameterPointer

Signed-off-by: Bernd Schubert <bernd@bsbernd.com>
This commit is contained in:
Bernd Schubert
2026-04-05 13:07:51 +02:00
parent 1a53c92d8c
commit 515f58b79d
2 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
include/fuse_common.h
+1 -1
View File
@@ -1054,7 +1054,7 @@ int fuse_set_fail_signal_handlers(struct fuse_session *se);
* See also:
* fuse_set_signal_handlers()
*/
void fuse_remove_signal_handlers(struct fuse_session *se);
void fuse_remove_signal_handlers(const struct fuse_session *se);
/**
* Config operations.
lib/fuse_signals.c
+3 -4
View File
@@ -76,7 +76,6 @@ static void exit_handler(int sig)
"assertion error: signal value <= 0\n");
dump_stack();
abort();
fuse_instance->error = sig;
}
fuse_instance->error = sig;
@@ -124,7 +123,7 @@ static int set_one_signal_handler(int sig, void (*handler)(int), int remove)
return 0;
}
static int _fuse_set_signal_handlers(int signals[], int nr_signals,
static int _fuse_set_signal_handlers(const int signals[], int nr_signals,
void (*handler)(int))
{
for (int idx = 0; idx < nr_signals; idx++) {
@@ -188,14 +187,14 @@ int fuse_set_fail_signal_handlers(struct fuse_session *se)
return 0;
}
static void _fuse_remove_signal_handlers(int signals[], int nr_signals,
static void _fuse_remove_signal_handlers(const int signals[], int nr_signals,
void (*handler)(int))
{
for (int idx = 0; idx < nr_signals; idx++)
set_one_signal_handler(signals[idx], handler, 1);
}
void fuse_remove_signal_handlers(struct fuse_session *se)
void fuse_remove_signal_handlers(const struct fuse_session *se)
{
size_t nr_signals;