mirror of
https://github.com/facebook/rocksdb.git
synced 2026-07-07 14:47:40 +08:00
b5922eab11
Summary: Pull Request resolved: https://github.com/facebook/rocksdb/pull/14739 Adds public path-level file sync APIs to RocksDB so callers can ask `Env` or `FileSystem` to sync a named file without hand-rolled reopen logic. This diff: - Adds public `Env::SyncFile` and `FileSystem::SyncFile` APIs for syncing or fsyncing a file by name without requiring callers to reopen it directly. - Documents the `SyncFile` contract: filesystems may override it as a no-op when flush/close already provides durability, and RocksDB callers should use it instead of hand-rolled `ReopenWritableFile()+Sync()/Fsync()` so filesystems can reject post-close data-write reopen paths. - Implements the default `Env` and `FileSystem` behavior by reopening the file as writable, calling `Sync` or `Fsync`, closing the handle, returning the sync/fsync error ahead of a close error when both fail, and explicitly consuming the close status on the sync-failure path. - Wires `SyncFile` through the Env/FileSystem bridge and wrapper layers, including `EnvWrapper`, `FileSystemWrapper`, `CompositeEnvWrapper`, `EncryptedFileSystem`, `RemapFileSystem`, read-only file systems, mock file systems, and fault-injection wrappers. - Keeps fault-injection `SyncFile` overrides on the base default implementation so the operation still exercises the wrapper's `ReopenWritableFile`, wrapped-file `Sync`/`Fsync`, and `Close` hooks instead of bypassing them through target forwarding. - Updates external SST ingestion to call `FileSystem::SyncFile` instead of manually reopening an ingested file as writable, while preserving the `NotSupported` skip behavior and failure logging. - Adds release-note coverage for the new public API and unit coverage for default `Env`/`FileSystem` success, reopen failure, close failure, sync-versus-close failure precedence, and external SST sync behavior. There was an earlier version of this API which got reverted (PR #13987) due to internal change broken. Re-apply the change. The internal issue will be resolved in next release. Reviewed By: pdillinger Differential Revision: D104918547 fbshipit-source-id: 3f8d2d127fc962b68b423bbb90de551fe6706224
110 lines
4.2 KiB
C++
110 lines
4.2 KiB
C++
// Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#pragma once
|
|
|
|
#include "rocksdb/file_system.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
// A FileSystem wrapper that only allows read-only operation.
|
|
//
|
|
// This class has not been fully analyzed for providing strong security
|
|
// guarantees.
|
|
class ReadOnlyFileSystem : public FileSystemWrapper {
|
|
static inline IOStatus FailReadOnly() {
|
|
IOStatus s = IOStatus::IOError("Attempted write to ReadOnlyFileSystem");
|
|
assert(s.GetRetryable() == false);
|
|
return s;
|
|
}
|
|
|
|
public:
|
|
explicit ReadOnlyFileSystem(const std::shared_ptr<FileSystem>& base)
|
|
: FileSystemWrapper(base) {}
|
|
|
|
static const char* kClassName() { return "ReadOnlyFileSystem"; }
|
|
const char* Name() const override { return kClassName(); }
|
|
|
|
IOStatus NewWritableFile(const std::string& /*fname*/,
|
|
const FileOptions& /*options*/,
|
|
std::unique_ptr<FSWritableFile>* /*result*/,
|
|
IODebugContext* /*dbg*/) override {
|
|
return FailReadOnly();
|
|
}
|
|
IOStatus ReuseWritableFile(const std::string& /*fname*/,
|
|
const std::string& /*old_fname*/,
|
|
const FileOptions& /*options*/,
|
|
std::unique_ptr<FSWritableFile>* /*result*/,
|
|
IODebugContext* /*dbg*/) override {
|
|
return FailReadOnly();
|
|
}
|
|
IOStatus NewRandomRWFile(const std::string& /*fname*/,
|
|
const FileOptions& /*options*/,
|
|
std::unique_ptr<FSRandomRWFile>* /*result*/,
|
|
IODebugContext* /*dbg*/) override {
|
|
return FailReadOnly();
|
|
}
|
|
IOStatus NewDirectory(const std::string& /*dir*/,
|
|
const IOOptions& /*options*/,
|
|
std::unique_ptr<FSDirectory>* /*result*/,
|
|
IODebugContext* /*dbg*/) override {
|
|
return FailReadOnly();
|
|
}
|
|
IOStatus DeleteFile(const std::string& /*fname*/,
|
|
const IOOptions& /*options*/,
|
|
IODebugContext* /*dbg*/) override {
|
|
return FailReadOnly();
|
|
}
|
|
IOStatus CreateDir(const std::string& /*dirname*/,
|
|
const IOOptions& /*options*/,
|
|
IODebugContext* /*dbg*/) override {
|
|
return FailReadOnly();
|
|
}
|
|
IOStatus CreateDirIfMissing(const std::string& dirname,
|
|
const IOOptions& options,
|
|
IODebugContext* dbg) override {
|
|
// Allow if dir already exists
|
|
bool is_dir = false;
|
|
IOStatus s = IsDirectory(dirname, options, &is_dir, dbg);
|
|
if (s.ok() && is_dir) {
|
|
return s;
|
|
} else {
|
|
return FailReadOnly();
|
|
}
|
|
}
|
|
IOStatus DeleteDir(const std::string& /*dirname*/,
|
|
const IOOptions& /*options*/,
|
|
IODebugContext* /*dbg*/) override {
|
|
return FailReadOnly();
|
|
}
|
|
IOStatus RenameFile(const std::string& /*src*/, const std::string& /*dest*/,
|
|
const IOOptions& /*options*/,
|
|
IODebugContext* /*dbg*/) override {
|
|
return FailReadOnly();
|
|
}
|
|
IOStatus LinkFile(const std::string& /*src*/, const std::string& /*dest*/,
|
|
const IOOptions& /*options*/,
|
|
IODebugContext* /*dbg*/) override {
|
|
return FailReadOnly();
|
|
}
|
|
IOStatus SyncFile(const std::string& /*fname*/,
|
|
const FileOptions& /*file_opts*/,
|
|
const IOOptions& /*io_opts*/, bool /*use_fsync*/,
|
|
IODebugContext* /*dbg*/) override {
|
|
return FailReadOnly();
|
|
}
|
|
IOStatus LockFile(const std::string& /*fname*/, const IOOptions& /*options*/,
|
|
FileLock** /*lock*/, IODebugContext* /*dbg*/) override {
|
|
return FailReadOnly();
|
|
}
|
|
IOStatus NewLogger(const std::string& /*fname*/, const IOOptions& /*options*/,
|
|
std::shared_ptr<Logger>* /*result*/,
|
|
IODebugContext* /*dbg*/) override {
|
|
return FailReadOnly();
|
|
}
|
|
};
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|