jabberwocky238/rocksdb
1
0
Fork 0
mirror of https://github.com/facebook/rocksdb.git synced 2026-07-07 14:47:40 +08:00
Code Issues Packages Projects Releases Wiki Activity

Rename Env::IOActivity::kReadManifest (#13471)

Browse Source 
Summary:
Context/Summary: as mentioned in the [comment](https://github.com/facebook/rocksdb/pull/13178?fbclid=IwZXh0bgNhZW0CMTAAAR1nvz-1Ifh6Pm8PwFZbGHAxhLtwfi4W_XaSe-BqnBx3ICJOq-9DTdqFvs0_aem_ITO_0B6cca0kTViRmsAA8g#issuecomment-2702510373) , we want to rename this public name to align with the naming convention.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/13471

Test Plan:
- Compilation
- Manually check for no internal usage of this name. Hopefully it's good for OSS as well as this field is relatively new and the whole IOActivity is marked "EXPERIMENTAL"

Reviewed By: mszeszko-meta

Differential Revision: D71485300

Pulled By: hx235

fbshipit-source-id: 318c8b6c2a4d874f2f831e3ca690aa2fb8974c0f
This commit is contained in:
Hui Xiao
2025-03-19 12:08:06 -07:00
committed by Facebook GitHub Bot
parent 0a43d8a261
commit 2e175124d8
6 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
db/experimental.cc
+2 -1
View File
@@ -57,7 +57,8 @@ Status GetFileChecksumsFromCurrentManifest(FileSystem* fs,
} }
assert(checksum_list); assert(checksum_list);
const ReadOptions read_options(Env::IOActivity::kReadManifest); const ReadOptions read_options(
Env::IOActivity::kGetFileChecksumsFromCurrentManifest);
checksum_list->reset(); checksum_list->reset();
std::unique_ptr<SequentialFileReader> file_reader; std::unique_ptr<SequentialFileReader> file_reader;
env/env.cc
Vendored
+2 -2
View File
@@ -754,8 +754,8 @@ std::string Env::IOActivityToString(IOActivity activity) {
return "GetEntity"; return "GetEntity";
case Env::IOActivity::kMultiGetEntity: case Env::IOActivity::kMultiGetEntity:
return "MultiGetEntity"; return "MultiGetEntity";
case Env::IOActivity::kReadManifest: case Env::IOActivity::kGetFileChecksumsFromCurrentManifest:
return "ReadManifest"; return "GetFileChecksumsFromCurrentManifest";
case Env::IOActivity::kUnknown: case Env::IOActivity::kUnknown:
return "Unknown"; return "Unknown";
}; };
include/rocksdb/env.h
+1 -1
View File
@@ -455,7 +455,7 @@ class Env : public Customizable {
kVerifyFileChecksums = 7, kVerifyFileChecksums = 7,
kGetEntity = 8, kGetEntity = 8,
kMultiGetEntity = 9, kMultiGetEntity = 9,
kReadManifest = 10, kGetFileChecksumsFromCurrentManifest = 10,
kUnknown, // Keep last for easy array of non-unknowns kUnknown, // Keep last for easy array of non-unknowns
}; };
include/rocksdb/thread_status.h
+1 -1
View File
@@ -64,7 +64,7 @@ struct ThreadStatus {
OP_VERIFY_FILE_CHECKSUMS, OP_VERIFY_FILE_CHECKSUMS,
OP_GETENTITY, OP_GETENTITY,
OP_MULTIGETENTITY, OP_MULTIGETENTITY,
OP_READ_MANIFEST, OP_GET_FILE_CHECKSUMS_FROM_CURRENT_MANIFEST,
NUM_OP_TYPES NUM_OP_TYPES
}; };
monitoring/thread_status_util_debug.cc
+3 -2
View File
@@ -50,8 +50,9 @@ Env::IOActivity ThreadStatusUtil::TEST_GetExpectedIOActivity(
return Env::IOActivity::kGetEntity; return Env::IOActivity::kGetEntity;
case ThreadStatus::OperationType::OP_MULTIGETENTITY: case ThreadStatus::OperationType::OP_MULTIGETENTITY:
return Env::IOActivity::kMultiGetEntity; return Env::IOActivity::kMultiGetEntity;
case ThreadStatus::OperationType::OP_READ_MANIFEST: case ThreadStatus::OperationType::
return Env::IOActivity::kReadManifest; OP_GET_FILE_CHECKSUMS_FROM_CURRENT_MANIFEST:
return Env::IOActivity::kGetFileChecksumsFromCurrentManifest;
default: default:
return Env::IOActivity::kUnknown; return Env::IOActivity::kUnknown;
} }
util/thread_operation.h
+2 -1
View File
@@ -47,7 +47,8 @@ static OperationInfo global_operation_table[] = {
{ThreadStatus::OP_VERIFY_FILE_CHECKSUMS, "VerifyFileChecksums"}, {ThreadStatus::OP_VERIFY_FILE_CHECKSUMS, "VerifyFileChecksums"},
{ThreadStatus::OP_GETENTITY, "GetEntity"}, {ThreadStatus::OP_GETENTITY, "GetEntity"},
{ThreadStatus::OP_MULTIGETENTITY, "MultiGetEntity"}, {ThreadStatus::OP_MULTIGETENTITY, "MultiGetEntity"},
{ThreadStatus::OP_READ_MANIFEST, "ReadManifest"}, {ThreadStatus::OP_GET_FILE_CHECKSUMS_FROM_CURRENT_MANIFEST,
"GetFileChecksumsFromCurrentManifest"},
}; };