Remove deprecated ReadOptions::managed, `ColumnFamilyOptions::snap_refresh_nanos (#14350)

Summary:
**Context/Summary:**
Remove deprecated, unused APIs and options:
- ReadOptions::managed: This option was not used anymore. The functionality it controlled has been removed long ago.
- ColumnFamilyOptions::snap_refresh_nanos: Deprecated and unused option.

Corresponding C API (rocksdb_readoptions_set_managed) and Java API (ReadOptions.managed/setManaged) are also removed. All related checks an db_impl and db_impl_secondary iterators are cleaned up.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/14350

Test Plan: make check

Reviewed By: pdillinger

Differential Revision: D93812438

Pulled By: hx235

fbshipit-source-id: e4a9d21c65f83294b6d0878286ba14024f049bac
This commit is contained in:
Hui Xiao
2026-02-20 14:00:41 -08:00
committed by meta-codesync[bot]
parent 6d6f7d825b
commit 29819f37e1
11 changed files with 2 additions and 93 deletions
-20
View File
@@ -8031,26 +8031,6 @@ jboolean Java_org_rocksdb_ReadOptions_tailing(JNIEnv*, jclass, jlong jhandle) {
return reinterpret_cast<ROCKSDB_NAMESPACE::ReadOptions*>(jhandle)->tailing;
}
/*
* Class: org_rocksdb_ReadOptions
* Method: managed
* Signature: (J)Z
*/
jboolean Java_org_rocksdb_ReadOptions_managed(JNIEnv*, jclass, jlong jhandle) {
return reinterpret_cast<ROCKSDB_NAMESPACE::ReadOptions*>(jhandle)->managed;
}
/*
* Class: org_rocksdb_ReadOptions
* Method: setManaged
* Signature: (JZ)V
*/
void Java_org_rocksdb_ReadOptions_setManaged(JNIEnv*, jclass, jlong jhandle,
jboolean jmanaged) {
reinterpret_cast<ROCKSDB_NAMESPACE::ReadOptions*>(jhandle)->managed =
static_cast<bool>(jmanaged);
}
/*
* Class: org_rocksdb_ReadOptions
* Method: totalOrderSeek
@@ -186,37 +186,6 @@ public class ReadOptions extends RocksObject {
return this;
}
/**
* Returns whether managed iterators will be used.
*
* @return the setting of whether managed iterators will be used,
* by default false
*
* @deprecated This options is not used anymore.
*/
@Deprecated
public boolean managed() {
assert(isOwningHandle());
return managed(nativeHandle_);
}
/**
* Specify to create a managed iterator -- a special iterator that
* uses less resources by having the ability to free its underlying
* resources on request.
*
* @param managed if true, then managed iterators will be enabled.
* @return the reference to the current ReadOptions.
*
* @deprecated This options is not used anymore.
*/
@Deprecated
public ReadOptions setManaged(final boolean managed) {
assert(isOwningHandle());
setManaged(nativeHandle_, managed);
return this;
}
/**
* Returns whether a total seek order will be used
*
@@ -819,8 +788,6 @@ public class ReadOptions extends RocksObject {
private static native void setReadTier(long handle, byte readTierValue);
private static native boolean tailing(long handle);
private static native void setTailing(long handle, boolean tailing);
private static native boolean managed(long handle);
private static native void setManaged(long handle, boolean managed);
private static native boolean totalOrderSeek(long handle);
private static native void setTotalOrderSeek(long handle, boolean totalOrderSeek);
private static native boolean prefixSameAsStart(long handle);
@@ -98,15 +98,6 @@ public class ReadOptionsTest {
}
}
@SuppressWarnings("deprecated")
@Test
public void managed() {
try (final ReadOptions opt = new ReadOptions()) {
opt.setManaged(true);
assertThat(opt.managed()).isTrue();
}
}
@Test
public void totalOrderSeek() {
try (final ReadOptions opt = new ReadOptions()) {