jabberwocky238/libfuse
1
0
Fork 0
mirror of https://github.com/libfuse/libfuse.git synced 2026-07-07 14:47:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

test: Fix null-argument issue in test_signals.c

Browse Source 
Check if mountpoint is NULL before calling rmdir() in the error
path. This fixes CodeChecker warning about use of NULL 'mountpoint'
where non-null expected.

Reported by: CodeChecker (gcc-null-argument)

Signed-off-by: Bernd Schubert <bernd@bsbernd.com>
This commit is contained in:
Bernd Schubert
2026-04-04 21:52:38 +02:00
parent bdd9b96239
commit bb26f81a9e
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/test_signals.c
+8 -7
View File
@@ -72,7 +72,7 @@ static void fork_child(void)
/* Add the program name to arg[0] */ /* Add the program name to arg[0] */
if (fuse_opt_add_arg(&args, "test_signals")) { if (fuse_opt_add_arg(&args, "test_signals")) {
fprintf(stderr, "Failed to add argument\n"); fprintf(stderr, "Failed to add argument\n");
goto out_free_mountpoint; goto out_free;
} }
/* Add debug flag to see more output */ /* Add debug flag to see more output */
@@ -82,14 +82,14 @@ static void fork_child(void)
mountpoint = strdup("/tmp/fuse_test_XXXXXX"); mountpoint = strdup("/tmp/fuse_test_XXXXXX");
if (!mountpoint || !mkdtemp(mountpoint)) { if (!mountpoint || !mkdtemp(mountpoint)) {
fprintf(stderr, "Failed to create temp dir\n"); fprintf(stderr, "Failed to create temp dir\n");
goto out_free_args; goto out_free;
} }
/* Create session */ /* Create session */
se = fuse_session_new(&args, &test_ll_ops, sizeof(test_ll_ops), NULL); se = fuse_session_new(&args, &test_ll_ops, sizeof(test_ll_ops), NULL);
if (!se) { if (!se) {
fprintf(stderr, "Failed to create FUSE session\n"); fprintf(stderr, "Failed to create FUSE session\n");
goto out_free_mountpoint; goto out_free;
} }
/* Mount filesystem */ /* Mount filesystem */
@@ -155,10 +155,11 @@ out_unmount:
fuse_session_unmount(se); fuse_session_unmount(se);
out_destroy_session: out_destroy_session:
fuse_session_destroy(se); fuse_session_destroy(se);
out_free_mountpoint: out_free:
rmdir(mountpoint); if (mountpoint) {
free(mountpoint); rmdir(mountpoint);
out_free_args: free(mountpoint);
}
fuse_opt_free_args(&args); fuse_opt_free_args(&args);
exit(1); exit(1);
} }